Skip to content

Use llvm-libunwind="in-tree" for Fuchsia targets - #100341

Merged
bors merged 1 commit into
rust-lang:masterfrom
andrewpollack:fuchsia-llvm-libunwind
Aug 13, 2022
Merged

Use llvm-libunwind="in-tree" for Fuchsia targets#100341
bors merged 1 commit into
rust-lang:masterfrom
andrewpollack:fuchsia-llvm-libunwind

Conversation

@andrewpollack

Copy link
Copy Markdown
Member

With updates to Fuchsia CI's Zircon libraries #99833, we can introduce llvm-libunwind="in-tree" for Fuchsia targets. This PR restores functionality removed from #93604 (comment).

cc @tmandry@djkoloski

@rustbotrustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 9, 2022
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @jyn514

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2022
@tmandry

Copy link
Copy Markdown
Member

Can you also update the target docs so they don't say you need to override this anymore?

Removing libunwind from Fuchsia target docs
@andrewpollack
andrewpollackforce-pushed the fuchsia-llvm-libunwind branch from 173ac65 to 29238f4CompareAugust 9, 2022 20:02
@andrewpollack

Copy link
Copy Markdown
MemberAuthor

Can you also update the target docs so they don't say you need to override this anymore?

Good call -- done!

@tmandry

Copy link
Copy Markdown
Member

The bootstrap changes were already approved in #93604 (comment).

@bors r+ rollup=never (broke last time)

@bors

bors commented Aug 9, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 29238f4 has been approved by tmandry

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2022
@bors

bors commented Aug 12, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 29238f4 with merge 24041dbeb7a469050367aa1d63309a708fc46af1...

@bors

bors commented Aug 13, 2022

Copy link
Copy Markdown
Collaborator

💥 Test timed out

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 13, 2022
@jyn514

Copy link
Copy Markdown
Member

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2022
@bors

bors commented Aug 13, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 29238f4 with merge e8dc8bc...

@bors

bors commented Aug 13, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: tmandry
Pushing e8dc8bc to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Aug 13, 2022
@bors
bors merged commit e8dc8bc into rust-lang:masterAug 13, 2022
@rustbotrustbot added this to the 1.65.0 milestone Aug 13, 2022
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e8dc8bc): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: ✅ relevant improvement found
mean1maxcount2
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-0.2%-0.2%1
All ❌✅ (primary)--0

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: ✅ relevant improvement found
mean1maxcount2
Regressions ❌
(primary)
1.7%2.3%3
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.9%-2.9%1
Improvements ✅
(secondary)
-3.6%-3.6%1
All ❌✅ (primary)0.5%-2.9%4

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: no relevant changes found
mean1maxcount2
Regressions ❌
(primary)
3.1%3.9%2
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-3.0%-3.0%1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)1.0%3.9%3

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change23

  2. number of relevant changes23

@tmandrytmandry added the O-fuchsia Operating system: Fuchsia label May 24, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.O-fuchsiaOperating system: FuchsiaS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@andrewpollack@rust-highfive@tmandry@bors@jyn514@rust-timer@rustbot