Fuchsia CI zircon lib improvement by andrewpollack · Pull Request #99833 · rust-lang/rust

andrewpollack · 2022-07-27T23:53:50Z

Removing Zircon build process, instead pulling sysroot and related libs directly from Fuchsia SDK

cc. @tmandry @djkoloski

rust-highfive · 2022-07-27T23:53:53Z

r? @pietroalbini

(rust-highfive has picked a reviewer for you, use r? to override)

tmandry · 2022-07-28T01:35:58Z

Also, can you squash your fixup commits?

tmandry

Looks good to me after the last change I requested. @pietroalbini want to give this a once over?

tmandry · 2022-07-29T16:25:38Z

I may have heard that Pietro was on vacation,

r? @rust-lang/infra

jyn514 · 2022-07-29T16:34:56Z

r? rust-lang/infra-ci

(you can see the list of teams highfive accepts at https://github.com/rust-lang/highfive/blob/master/highfive/configs/rust-lang/rust.json)

andrewpollack · 2022-07-29T19:06:46Z

Unable to mark a re-request review; thank you for the feedback @petrhosek ! Please let me know if any other additions would be good to add

Mark-Simulacrum · 2022-07-30T19:01:04Z

@bors r+ rollup=iffy

bors · 2022-07-30T19:01:06Z

📌 Commit d98b6d2d9935eb0fbf78045263c6991b8a5f759e has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors · 2022-08-02T11:55:08Z

⌛ Testing commit d98b6d2d9935eb0fbf78045263c6991b8a5f759e with merge 95ffcfe4ed162665fb8191b6fa69e98f47a47492...

Mark-Simulacrum · 2022-08-07T11:28:40Z

@bors r+

bors · 2022-08-07T11:28:41Z

📌 Commit c913a06937f2952a7c80b142d363e01146a4c2f7 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors · 2022-08-07T12:42:10Z

⌛ Testing commit c913a06937f2952a7c80b142d363e01146a4c2f7 with merge fcb586e9fb67607b468f89e441a036d48938997c...

bors · 2022-08-07T13:17:48Z

💔 Test failed - checks-actions

PR feedback PR Followups Updating clang download Updating clang download Restructuring env used Restructuring env used Adding chmod Adding chmod Adding chmod

Mark-Simulacrum · 2022-08-07T15:21:57Z

@bors r+

bors · 2022-08-07T15:21:59Z

📌 Commit fa4ce7a has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors · 2022-08-07T15:58:34Z

⌛ Testing commit fa4ce7a with merge 9ee22ff...

bors · 2022-08-07T18:44:36Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 9ee22ff to master...

andrewpollack · 2022-08-07T18:50:29Z

Thank you @Mark-Simulacrum for helping on this! I really appreciate it 🙏

rust-timer · 2022-08-07T20:02:03Z

Finished benchmarking commit (9ee22ff): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: no relevant changes found

	mean¹	max	count²
Regressions 😿 (primary)	2.8%	3.3%	2
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	2.8%	3.3%	2

Cycles

Results

Primary benchmarks: 😿 relevant regression found
Secondary benchmarks: 🎉 relevant improvement found

	mean¹	max	count²
Regressions 😿 (primary)	2.5%	2.5%	1
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.3%	-2.3%	1
All 😿🎉 (primary)	2.5%	2.5%	1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change↩↩²
number of relevant changes↩↩²

…, r=tmandry Use llvm-libunwind="in-tree" for Fuchsia targets With updates to Fuchsia CI's Zircon libraries rust-lang#99833, we can introduce `llvm-libunwind="in-tree"` for Fuchsia targets. This PR restores functionality removed from rust-lang#93604 (comment). cc `@tmandry` `@djkoloski`

rust-highfive assigned emilyalbini Jul 27, 2022

rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Jul 27, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 27, 2022

tmandry requested changes Jul 28, 2022
View reviewed changes

andrewpollack force-pushed the fuchsia-rust-ci-zircon-lib-improvement branch from ac4e3e0 to 9eeb2feCompare July 28, 2022 18:48

andrewpollack requested a review from tmandry July 28, 2022 19:40

tmandry reviewed Jul 28, 2022
View reviewed changes

Comment threadsrc/ci/docker/host-x86_64/dist-various-2/Dockerfile Outdated

tmandry approved these changes Jul 28, 2022
View reviewed changes

andrewpollack force-pushed the fuchsia-rust-ci-zircon-lib-improvement branch from 9eeb2fe to 6e03ed6Compare July 28, 2022 20:25

tmandry mentioned this pull request Jul 29, 2022
Update to LLVM 15 #99464
Merged

rust-highfive assigned Mark-Simulacrum and unassigned emilyalbini Jul 29, 2022

petrhosek reviewed Jul 29, 2022
View reviewed changes

Comment threadsrc/ci/docker/host-x86_64/dist-various-2/build-fuchsia-toolchain.sh Outdated

petrhosek reviewed Jul 29, 2022
View reviewed changes

Comment threadsrc/ci/docker/host-x86_64/dist-various-2/build-fuchsia-toolchain.sh Outdated

andrewpollack force-pushed the fuchsia-rust-ci-zircon-lib-improvement branch from 6e03ed6 to 976da4eCompare July 29, 2022 17:56

andrewpollack force-pushed the fuchsia-rust-ci-zircon-lib-improvement branch 4 times, most recently from 242c03f to d98b6d2Compare July 29, 2022 21:07

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 7, 2022

This comment has been minimized.
Sign in to view

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2022

Shifting CI to pull Zircon libraries directly from Fuchsia SDK
fa4ce7a
PR feedback PR Followups Updating clang download Updating clang download Restructuring env used Restructuring env used Adding chmod Adding chmod Adding chmod

andrewpollack force-pushed the fuchsia-rust-ci-zircon-lib-improvement branch from c913a06 to fa4ce7aCompare August 7, 2022 15:19

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 7, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 7, 2022

bors merged commit 9ee22ff into rust-lang:masterAug 7, 2022

rustbot added this to the 1.65.0 milestone Aug 7, 2022

andrewpollack mentioned this pull request Aug 9, 2022
Use llvm-libunwind="in-tree" for Fuchsia targets #100341
Merged

Kobzol mentioned this pull request Mar 18, 2024
Add a batch of 3 repositories for archival #2 rust-lang/team#1388
Merged

workingjubilee added the O-fuchsia Operating system: Fuchsia label May 4, 2024

Uh oh!

Uh oh!

Conversation

andrewpollack commented Jul 27, 2022

Uh oh!

rust-highfive commented Jul 27, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tmandry commented Jul 28, 2022

Uh oh!

Uh oh!

tmandry left a comment

Choose a reason for hiding this comment

Uh oh!

tmandry commented Jul 29, 2022

Uh oh!

jyn514 commented Jul 29, 2022

Uh oh!

Uh oh!

Uh oh!

andrewpollack commented Jul 29, 2022

Uh oh!

Mark-Simulacrum commented Jul 30, 2022

Uh oh!

bors commented Jul 30, 2022

Uh oh!

bors commented Aug 2, 2022

Uh oh!

Mark-Simulacrum commented Aug 7, 2022

Uh oh!

bors commented Aug 7, 2022

Uh oh!

bors commented Aug 7, 2022

Uh oh!

bors commented Aug 7, 2022

Uh oh!

This comment has been minimized.

Mark-Simulacrum commented Aug 7, 2022

Uh oh!

bors commented Aug 7, 2022

Uh oh!

bors commented Aug 7, 2022

Uh oh!

bors commented Aug 7, 2022

Uh oh!

andrewpollack commented Aug 7, 2022

Uh oh!

rust-timer commented Aug 7, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants