Uh oh!
There was an error while loading. Please reload this page.
Migrate "invalid variable declaration" errors to SessionDiagnostic - #100667
Merged
Conversation
rust-highfive
commented
Aug 17, 2022
Contributor
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
Xiretza
commented
Aug 17, 2022
ContributorAuthor
@rustbot label +A-translation |
Xiretza
commented
Aug 17, 2022
Uh oh!
There was an error while loading. Please reload this page.
Xiretza
commented
Aug 17, 2022
Uh oh!
There was an error while loading. Please reload this page.
davidtwco
commented
Aug 17, 2022
Member
r? @davidtwco |
Xiretzaforce-pushed
the
diag-structs-parser-ivd
branch
from
August 17, 2022 17:09
6ce582d to
e8499cfComparedavidtwco
approved these changes
Aug 17, 2022
davidtwco
commented
Aug 17, 2022
Member
r=me once CI passes |
davidtwco
approved these changes
Aug 18, 2022
davidtwco
commented
Aug 18, 2022
Member
@bors r+ |
bors
commented
Aug 18, 2022
Collaborator
compiler-errors
commented
Aug 19, 2022
Contributor
@bors rollup |
ChrisDenton added a commit
to ChrisDenton/rust
that referenced
this pull request
Aug 20, 2022
…=davidtwco Migrate "invalid variable declaration" errors to SessionDiagnostic After seeing the great blog post on Inside Rust, I decided to try my hand at this. Just one diagnostic for now to get used to the workflow and to check if this is the way to do it or if there are any problems.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 20, 2022
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#100186 (Mention `as_mut` alongside `as_ref` in borrowck error message) - rust-lang#100383 (Mitigate stale data reads on SGX platform) - rust-lang#100507 (suggest `once_cell::Lazy` for non-const statics) - rust-lang#100617 (Suggest the right help message for as_ref) - rust-lang#100667 (Migrate "invalid variable declaration" errors to SessionDiagnostic) - rust-lang#100709 (Migrate typeck's `used` expected symbol diagnostic to `SessionDiagnostic`) - rust-lang#100723 (Add the diagnostic translation lints to crates that don't emit them) - rust-lang#100729 (Avoid zeroing a 1kb stack buffer on every call to `std::sys::windows::fill_utf16_buf`) - rust-lang#100750 (improved diagnostic for function defined with `def`, `fun`, `func`, or `function` instead of `fn`) - rust-lang#100763 (triagebot: Autolabel `A-rustdoc-json`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After seeing the great blog post on Inside Rust, I decided to try my hand at this. Just one diagnostic for now to get used to the workflow and to check if this is the way to do it or if there are any problems.