Skip to content

Add the diagnostic translation lints to crates that don't emit them - #100723

Merged
bors merged 1 commit into
masterfrom
unknown repository
Aug 20, 2022
Merged

Add the diagnostic translation lints to crates that don't emit them#100723
bors merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

Copy link
Copy Markdown

Some of these have a note saying that they should build on a stable compiler, does that mean they shouldn't get these lints? Or can we cfg them out on those?

@rustbotrustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 18, 2022
@rustbot

Copy link
Copy Markdown
Collaborator

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank

Changes rustc_apfloat. rustc_apfloat is currently in limbo and you almost certainly don't want to change it (see #55993).

cc @eddyb

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @compiler-errors

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 18, 2022
@compiler-errors

Copy link
Copy Markdown
Contributor

Thanks. I'll mark all these off.

@bors r+ rollup=always

@bors

bors commented Aug 18, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 09ea9f0 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2022
@compiler-errorscompiler-errors mentioned this pull request Aug 18, 2022
84 tasks
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Aug 20, 2022
…errors
Add the diagnostic translation lints to crates that don't emit them
Some of these have a note saying that they should build on a stable compiler, does that mean they shouldn't get these lints? Or can we cfg them out on those?
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 20, 2022
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#100186 (Mention `as_mut` alongside `as_ref` in borrowck error message)
- rust-lang#100383 (Mitigate stale data reads on SGX platform)
- rust-lang#100507 (suggest `once_cell::Lazy` for non-const statics)
- rust-lang#100617 (Suggest the right help message for as_ref)
- rust-lang#100667 (Migrate "invalid variable declaration" errors to SessionDiagnostic)
- rust-lang#100709 (Migrate typeck's `used` expected symbol diagnostic to `SessionDiagnostic`)
- rust-lang#100723 (Add the diagnostic translation lints to crates that don't emit them)
- rust-lang#100729 (Avoid zeroing a 1kb stack buffer on every call to `std::sys::windows::fill_utf16_buf`)
- rust-lang#100750 (improved diagnostic for function defined with `def`, `fun`, `func`, or `function` instead of `fn`)
- rust-lang#100763 (triagebot: Autolabel `A-rustdoc-json`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 84f81e7 into rust-lang:masterAug 20, 2022
@rustbotrustbot added this to the 1.65.0 milestone Aug 20, 2022
@ghost
ghost deleted the the-easy-ones branch August 20, 2022 10:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-translationArea: Translation infrastructure, and migrating existing diagnostics to SessionDiagnosticS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rustbot@rust-highfive@compiler-errors@bors