Add `#[rustc_safe_intrinsic]` by CohenArthur · Pull Request #100719 · rust-lang/rust

CohenArthur · 2022-08-18T14:47:27Z

This PR adds the #[rustc_safe_intrinsic] attribute as mentionned on Zulip. The goal of this attribute is to avoid keeping a list of symbols as the source for stable intrinsics, and instead rely on an attribute. This is similar to #[rustc_const_stable] and #[rustc_const_unstable], which among other things, are used to mark the constness of intrinsic functions.

rust-highfive · 2022-08-18T14:47:31Z

r? @compiler-errors

(rust-highfive has picked a reviewer for you, use r? to override)

rustbot · 2022-08-18T14:47:32Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

compiler-errors · 2022-08-18T14:54:04Z

Hm, Does this need a compiler MCP?

compiler-errors · 2022-08-18T19:40:12Z

r? @wesleywiser since you said you would review the patches :)

bors · 2022-08-28T05:01:35Z

☔ The latest upstream changes (presumably #96946) made this pull request unmergeable. Please resolve the merge conflicts.

CohenArthur · 2022-09-09T14:39:10Z

Following the discussion around the MCP, I've added the logic for checking the presence of the attribute on top of the existing "safe intrinsic list". This allows consumers of the core library to rely on the presence of the attribute, but keeps the compiler as the source of trust for which intrinsics are safe

bjorn3 · 2022-09-10T09:24:51Z

The first commit is a spurious duplicate of a commit that has already landed on master.

bors · 2022-09-10T12:45:36Z

☔ The latest upstream changes (presumably #101483) made this pull request unmergeable. Please resolve the merge conflicts.

CohenArthur · 2022-09-14T16:17:39Z

umbrella The latest upstream changes (presumably #101483) made this pull request unmergeable. Please resolve the merge conflicts.

This was fixed in 9192089 and bb2d43d by the way

wesleywiser

Would you mind also adding a UI test for the compiler error? It would be good to test both #[rustc_safe_intrinsic] on an intrinsic that isn't safe and not having the attribute on an intrinsic that is safe. Since we call err and not fatal, I think you should be able to put both cases in the test.

Other than that, this looks good to me! 🙂

bors · 2022-09-26T17:16:09Z

☔ The latest upstream changes (presumably #102051) made this pull request unmergeable. Please resolve the merge conflicts.

CohenArthur · 2022-09-27T05:24:34Z

I've fixed the formatting, added the test and fixed the merge conflicts. The error does not have any location info at the moment, so I don't mind spending a little more time on that if you think it'd be worth it @wesleywiser

bors · 2022-09-27T13:49:48Z

☔ The latest upstream changes (presumably #102306) made this pull request unmergeable. Please resolve the merge conflicts.

wesleywiser

It should be easy enough to get a nice span associated with the error (I believe the suggestion I left is sufficient for that to happen) so let's go ahead and do that. The rest of this looks good to me!

wesleywiser · 2022-09-28T14:42:51Z

Thanks @CohenArthur!

@bors r+

bors · 2022-09-28T14:42:52Z

📌 Commit b1b8649 has been approved by wesleywiser

It is now in the queue for this repository.

bors · 2022-09-28T19:07:53Z

⌛ Testing commit b1b8649 with merge ce7f0f1...

bors · 2022-09-28T22:11:12Z

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing ce7f0f1 to master...

rust-timer · 2022-09-28T23:44:14Z

Finished benchmarking commit (ce7f0f1): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.4%	[1.2%, 1.6%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.9%	[3.9%, 3.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

the arithmetic mean of the percent change↩↩²
number of relevant changes↩↩²

…ibute, r=wesleywiser Add `#[rustc_safe_intrinsic]` This PR adds the `#[rustc_safe_intrinsic]` attribute as mentionned on Zulip. The goal of this attribute is to avoid keeping a list of symbols as the source for stable intrinsics, and instead rely on an attribute. This is similar to `#[rustc_const_stable]` and `#[rustc_const_unstable]`, which among other things, are used to mark the constness of intrinsic functions.

rust-highfive assigned compiler-errors Aug 18, 2022

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 18, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 18, 2022

CohenArthur mentioned this pull request Aug 18, 2022
Add #[rustc_safe_intrinsic] attribute rust-lang/compiler-team#546
Closed
3 tasks

rust-highfive assigned wesleywiser and unassigned compiler-errors Aug 18, 2022

CohenArthur force-pushed the rust-safe-intrinsic-attribute branch from 3f0b2b8 to a255c4bCompare September 9, 2022 11:24

This comment has been minimized.
Sign in to view

CohenArthur force-pushed the rust-safe-intrinsic-attribute branch from a255c4b to 4a8bdfdCompare September 9, 2022 14:37

CohenArthur force-pushed the rust-safe-intrinsic-attribute branch from 4a8bdfd to 422fad6Compare September 9, 2022 14:39

This comment has been minimized.
Sign in to view

CohenArthur force-pushed the rust-safe-intrinsic-attribute branch from 422fad6 to 79545e3Compare September 10, 2022 09:23

rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Sep 10, 2022

CohenArthur force-pushed the rust-safe-intrinsic-attribute branch 2 times, most recently from d880fd4 to bb2d43dCompare September 13, 2022 13:49

wesleywiser requested changes Sep 23, 2022
View reviewed changes

Comment threadcompiler/rustc_typeck/src/check/intrinsic.rs Outdated

CohenArthur force-pushed the rust-safe-intrinsic-attribute branch from bb2d43d to 062b103Compare September 25, 2022 10:00

wesleywiser reviewed Sep 26, 2022
View reviewed changes

Comment threadcompiler/rustc_typeck/src/check/intrinsic.rs Outdated

CohenArthur force-pushed the rust-safe-intrinsic-attribute branch from 062b103 to 8a38ca1Compare September 27, 2022 05:24

CohenArthur force-pushed the rust-safe-intrinsic-attribute branch from 8a38ca1 to cedc019Compare September 27, 2022 13:53

CohenArthur added 2 commits September 27, 2022 15:55

attributes: Add #[rustc_safe_intrinsic] builtin
0ab2c91

core: Mark all safe intrinsics with #[rustc_safe_intrinsic]
99d57ee

wesleywiser approved these changes Sep 27, 2022
View reviewed changes

Comment threadcompiler/rustc_hir_analysis/src/check/intrinsic.rs Outdated

CohenArthur force-pushed the rust-safe-intrinsic-attribute branch from cedc019 to b1b8649Compare September 28, 2022 07:37

CohenArthur added 2 commits September 28, 2022 09:40

rustc_safe_intrinsic: Keep list of safe intrinsics within the compiler
37bf8f8

rustc_safe_intrinsic: Add UI test
b1b8649

wesleywiser approved these changes Sep 28, 2022
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 28, 2022

bors merged commit ce7f0f1 into rust-lang:masterSep 28, 2022

rustbot added this to the 1.66.0 milestone Sep 28, 2022

CohenArthur deleted the rust-safe-intrinsic-attribute branch September 29, 2022 07:26

Noratrieb mentioned this pull request Dec 30, 2022
Use rustc_safe_intrinsic attribute to check for intrinsic safety rust-lang/rust-analyzer#13866
Merged

Veykril mentioned this pull request May 10, 2023
Latest release bugs (v0.3.1506) missing unsafe errors : when using bit_flags and derive traits rust-lang/rust-analyzer#14766
Closed

Uh oh!

Uh oh!

Conversation

CohenArthur commented Aug 18, 2022

Uh oh!

rust-highfive commented Aug 18, 2022

Uh oh!

rustbot commented Aug 18, 2022

Uh oh!

compiler-errors commented Aug 18, 2022

Uh oh!

compiler-errors commented Aug 18, 2022

Uh oh!

bors commented Aug 28, 2022

Uh oh!

This comment has been minimized.

CohenArthur commented Sep 9, 2022

Uh oh!

This comment has been minimized.

bjorn3 commented Sep 10, 2022

Uh oh!

bors commented Sep 10, 2022

Uh oh!

CohenArthur commented Sep 14, 2022

Uh oh!

Uh oh!

wesleywiser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bors commented Sep 26, 2022

Uh oh!

CohenArthur commented Sep 27, 2022

Uh oh!

bors commented Sep 27, 2022

Uh oh!

wesleywiser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wesleywiser commented Sep 28, 2022

Uh oh!

bors commented Sep 28, 2022

Uh oh!

bors commented Sep 28, 2022

Uh oh!

bors commented Sep 28, 2022

Uh oh!

rust-timer commented Sep 28, 2022

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants