Skip to content

rename rustc_typeck to rustc_hir_analysis - #102306

Merged
bors merged 1 commit into
rust-lang:masterfrom
lcnr:rustc_hir_analysis
Sep 27, 2022
Merged

rename rustc_typeck to rustc_hir_analysis#102306
bors merged 1 commit into
rust-lang:masterfrom
lcnr:rustc_hir_analysis

Conversation

@lcnr

@lcnrlcnr commented Sep 26, 2022

Copy link
Copy Markdown
Contributor

@rustbotrustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 26, 2022
@rustbot

rustbot commented Sep 26, 2022

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2022
@bors

bors commented Sep 26, 2022

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #102224) made this pull request unmergeable. Please resolve the merge conflicts.

Alexendoo
Alexendoo reviewed Sep 26, 2022
View reviewed changes
Comment threadsrc/tools/rust-analyzer/crates/hir-ty/src/infer/coerce.rs Outdated
@lcnr
lcnrforce-pushed the rustc_hir_analysis branch 2 times, most recently from 30766a0 to 668cc19CompareSeptember 26, 2022 15:32
@bors

bors commented Sep 26, 2022

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #102051) made this pull request unmergeable. Please resolve the merge conflicts.

@compiler-errors

compiler-errors commented Sep 27, 2022

Copy link
Copy Markdown
Contributor

This just renames the whole crate? If so, then I guess that's a fine first step. r=me

@bors p=5 rollup=never since it's bitrotty

@lcnr

lcnr commented Sep 27, 2022

Copy link
Copy Markdown
ContributorAuthor

@bors r=compiler-errors

@bors

bors commented Sep 27, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 1fc86a6 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2022
@lcnrlcnr changed the title rustc_typeck to rustc_hir_analysisrename rustc_typeck to rustc_hir_analysisSep 27, 2022
@bors

bors commented Sep 27, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1fc86a6 with merge 57ee5cf...

@bors

bors commented Sep 27, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 57ee5cf to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Sep 27, 2022
@bors
bors merged commit 57ee5cf into rust-lang:masterSep 27, 2022
@rustbotrustbot added this to the 1.66.0 milestone Sep 27, 2022
@borsbors mentioned this pull request Sep 27, 2022
Closed
@lcnr
lcnr deleted the rustc_hir_analysis branch September 27, 2022 13:22
This was referenced Sep 27, 2022
Merged
Merged
Merged
Closed
Merged
This was referenced Sep 27, 2022
Merged
Merged
Merged
Closed
Merged
Closed
Merged
Merged
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Merged
@rust-timer

rust-timer commented Sep 27, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (57ee5cf): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1rangecount2
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		3.3%[3.3%, 3.3%]1
Improvements ✅
(primary)		-2.6%[-2.6%, -2.6%]1
Improvements ✅
(secondary)		-4.0%[-4.0%, -4.0%]1
All ❌✅ (primary)-2.6%[-2.6%, -2.6%]1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1rangecount2
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-3.2%[-3.2%, -3.2%]1
Improvements ✅
(secondary)		-2.6%[-3.1%, -2.1%]2
All ❌✅ (primary)-3.2%[-3.2%, -3.2%]1

Footnotes

  1. the arithmetic mean of the percent change↩↩2

  2. number of relevant changes↩↩2

@davidtwcodavidtwco mentioned this pull request Sep 28, 2022
Merged
davidtwco added a commit to davidtwco/rust that referenced this pull request Sep 28, 2022
@davidtwco
errors: rename typeck.ftl to hir_analysis.ftl
715d61d
In rust-lang#102306, `rustc_typeck` was renamed to `rustc_hir_analysis` but the
diagnostic resources were not renamed - which is what this commit
changes.
Signed-off-by: David Wood <david.wood@huawei.com>
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 28, 2022
@Dylan-DPC
Rollup merge ofrust-lang#102395- davidtwco:translation-rename-typec…
51743a2
…k, r=estebank
errors: rename `typeck.ftl` to `hir_analysis.ftl`
In rust-lang#102306, `rustc_typeck` was renamed to `rustc_hir_analysis` but the diagnostic resources were not renamed - which is what this pull request changes.
davidtwco added a commit to davidtwco/rust that referenced this pull request Oct 3, 2022
@davidtwco
errors: rename typeck.ftl to hir_analysis.ftl
c4418e1
In rust-lang#102306, `rustc_typeck` was renamed to `rustc_hir_analysis` but the
diagnostic resources were not renamed - which is what this commit
changes.
Signed-off-by: David Wood <david.wood@huawei.com>
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 4, 2022
@bors
Auto merge ofrust-lang#102395- davidtwco:translation-rename-typeck,…
d9f8b4b
… r=compiler-errors
errors: rename `typeck.ftl` to `hir_analysis.ftl`
In rust-lang#102306, `rustc_typeck` was renamed to `rustc_hir_analysis` but the diagnostic resources were not renamed - which is what this pull request changes.
@mejrsmejrs mentioned this pull request Oct 4, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexendooAlexendooAlexendoo left review comments

Assignees

@compiler-errorscompiler-errors

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.66.0

Development

Successfully merging this pull request may close these issues.

7 participants

@lcnr@rustbot@bors@compiler-errors@rust-timer@Alexendoo@rust-highfive