Rollup of 6 pull requests by matthiaskrgr · Pull Request #101333 · rust-lang/rust

matthiaskrgr · 2022-09-02T16:22:05Z

Successful merges:

Try normalizing types without RevealAll in ParamEnv in MIR validation #100121 (Try normalizing types without RevealAll in ParamEnv in MIR validation)
Change implementation of -Z gcc-ld and lld-wrapper again #100200 (Change implementation of -Z gcc-ld and lld-wrapper again)
Porting 'compiler/rustc_trait_selection' to translatable diagnostics - Part 1 #100814 ( Porting 'compiler/rustc_trait_selection' to translatable diagnostics - Part 1)
Also replace the version placeholder in rustc_attr #101215 (Also replace the version placeholder in rustc_attr)
Use FILE_ATTRIBUTE_TAG_INFO to get reparse tag #101260 (Use FILE_ATTRIBUTE_TAG_INFO to get reparse tag)
Remove unused .toggle-label CSS rule #101323 (Remove unused .toggle-label CSS rule)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Before, the MIR validator used RevealAll in its ParamEnv for type checking. This could cause false negatives in some cases due to RevealAll ParamEnvs not always use all predicates as expected here. Since some MIR passes like inlining use RevealAll as well, keep using it in the MIR validator too, but when it fails usign RevealAll, also try the check without it, to stop false negatives.

Before, it called `normalize_erasing_regions` twice since `equal_up_to_regions` called it as well for both types.

This avoid unnecessarily getting the full reparse data when all we need is the tag.

…- Part 1

This fixes rustdoc not showing the current version as stabilization version for recently stabilized lang features.

… r=oli-obk Try normalizing types without RevealAll in ParamEnv in MIR validation Before, the MIR validator used RevealAll in its ParamEnv for type checking. This could cause false negatives in some cases due to RevealAll ParamEnvs not always use all predicates as expected here. Since some MIR passes like inlining use RevealAll as well, keep using it in the MIR validator too, but when it fails usign RevealAll, also try the check without it, to stop false negatives. Fixesrust-lang#99866 cc ````````@compiler-errors```````` who nicely helped me on zulip

…imulacrum Change implementation of `-Z gcc-ld` and `lld-wrapper` again This PR partially reverts rust-lang#97375 and uses the strategy described in rust-lang#97402 (comment) instead, thus fixesrust-lang#97755.

…diagnostics, r=davidtwco Porting 'compiler/rustc_trait_selection' to translatable diagnostics - Part 1 ``@rustbot`` label +A-translation r? rust-lang/diagnostics cc rust-lang#100717

… r=Mark-Simulacrum Also replace the version placeholder in rustc_attr Replace the version placeholder with the current version in the rustc_attr crate too so that users won't see the placeholder but instead the explicit version. This especially fixes the bug for rustdoc not showing it but instead the placeholder. Originally reported [here](https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/libs.20stabilization.20placeholder/near/296057188). cc rust-lang#100591 ![Screenshot_20220830_233727](https://user-images.githubusercontent.com/8872119/187548079-6207776b-4481-4351-afff-607f5b3fe03a.png)

Use `FILE_ATTRIBUTE_TAG_INFO` to get reparse tag I've been looking at this code recently and it just occurred to me we don't actually use the full reparse data at this point, only the tag. [`GetFileInformationByHandleEx`](https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-getfileinformationbyhandleex) can do exactly that by filling a [`FILE_ATTRIBUTE_TAG_INFO`](https://docs.microsoft.com/en-us/windows/win32/api/winbase/ns-winbase-file_attribute_tag_info) struct. r? ```````@thomcc``````` since you've made changes here recently (which is why I have this code on my mind atm)

…r=notriddle Remove unused .toggle-label CSS rule It was added in rust-lang#44192 but since we moved to `<details>`, we don't use this rule any more. r? `@notriddle`

matthiaskrgr · 2022-09-02T16:22:20Z

@bors r+ rollup=never p=6

bors · 2022-09-02T16:22:23Z

📌 Commit e77b8ce has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2022-09-02T18:40:24Z

⌛ Testing commit e77b8ce with merge 9ba169a...

bors · 2022-09-02T21:08:02Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 9ba169a to master...

rust-highfive · 2022-09-02T21:08:28Z

📣 Toolstate changed by #101333!

Tested on commit 9ba169a.
Direct link to PR: #101333

💔 miri on windows: test-pass → test-fail (cc @oli-obk @RalfJung).

@oli-obk

Tested on commit rust-lang/rust@9ba169a. Direct link to PR: <rust-lang/rust#101333> 💔 miri on windows: test-pass → test-fail (cc @oli-obk @RalfJung).

rust-timer · 2022-09-02T21:10:03Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#101323	69ebb63296eedd375aa568ef606ae14555762d36
#101260	10809bdb97abf913b485a24ab57c765d67ee3a4c
#101215	3be0f69c3b68b50d469c75b44d45afb4c9cbf45c
#100814	527b0bbe406f911399eab739ca12ec1f92029e6d
#100200	9cb679aec678bf0a56a44fb56ee2bdff86968972
#100121	0033deb2a7990f966a1faaa266145cb9e7875413

previous master: b88e510cc8

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-09-02T22:29:07Z

Finished benchmarking commit (9ba169a): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-0.8%, -0.6%]	6
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	4.0%	[1.2%, 6.8%]	2
Regressions ❌ (secondary)	2.6%	[2.6%, 2.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.6%	[-3.8%, -3.4%]	2
All ❌✅ (primary)	4.0%	[1.2%, 6.8%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

the arithmetic mean of the percent change↩↩²
number of relevant changes↩↩²

petrochenkovand others added 13 commits August 6, 2022 20:05

Change implementation of -Z gcc-ld and lld-wrapper again
6b68921

Only normalize once in mir validator typechecker
96d4137
Before, it called `normalize_erasing_regions` twice since `equal_up_to_regions` called it as well for both types.

Use FILE_ATTRIBUTE_TAG_INFO to get reparse tag
630f831
This avoid unnecessarily getting the full reparse data when all we need is the tag.

Porting 'compiler/rustc_trait_selection' to translatable diagnostics …
8e82200
…- Part 1

Also replace the version placeholder in rustc_attr
0c4ec5d
This fixes rustdoc not showing the current version as stabilization version for recently stabilized lang features.

Remove unused .toggle-label CSS rule
017cfeb

Rollup merge ofrust-lang#100200- petrochenkov:zgccld2, r=lqd,Mark-S…
ed37111
…imulacrum Change implementation of `-Z gcc-ld` and `lld-wrapper` again This PR partially reverts rust-lang#97375 and uses the strategy described in rust-lang#97402 (comment) instead, thus fixesrust-lang#97755.

Rollup merge ofrust-lang#100814- gabrielBusta:port_trait_selection_…
c8749f0
…diagnostics, r=davidtwco Porting 'compiler/rustc_trait_selection' to translatable diagnostics - Part 1 ``@rustbot`` label +A-translation r? rust-lang/diagnostics cc rust-lang#100717

Rollup merge ofrust-lang#101323- GuillaumeGomez:remove-unused-css, …
e77b8ce
…r=notriddle Remove unused .toggle-label CSS rule It was added in rust-lang#44192 but since we moved to `<details>`, we don't use this rule any more. r? `@notriddle`

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 2, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 2, 2022

bors merged commit 9ba169a into rust-lang:masterSep 2, 2022

rust-highfive mentioned this pull request Sep 2, 2022
miri no longer builds after rust-lang/rust#101333 #101344
Closed

rustbot added this to the 1.65.0 milestone Sep 2, 2022

tmandry mentioned this pull request Sep 2, 2022
Try normalizing types without RevealAll in ParamEnv in MIR validation #100121
Merged

davidtwco removed the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Oct 4, 2022

matthiaskrgr deleted the rollup-qpf1otj branch October 9, 2022 00:31

Navigation Menu

Uh oh!

Uh oh!

Rollup of 6 pull requests - #101333

Rollup of 6 pull requests#101333
bors merged 13 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-qpf1otj

matthiaskrgr commented Sep 2, 2022

Uh oh!

matthiaskrgr commented Sep 2, 2022

Uh oh!

bors commented Sep 2, 2022

Uh oh!

bors commented Sep 2, 2022

Uh oh!

bors commented Sep 2, 2022

Uh oh!

rust-highfive commented Sep 2, 2022

Uh oh!

rust-timer commented Sep 2, 2022

Uh oh!

rust-timer commented Sep 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

Uh oh!

Conversation

matthiaskrgr commented Sep 2, 2022

Uh oh!

matthiaskrgr commented Sep 2, 2022

Uh oh!

bors commented Sep 2, 2022

Uh oh!

bors commented Sep 2, 2022

Uh oh!

bors commented Sep 2, 2022

Uh oh!

rust-highfive commented Sep 2, 2022

Uh oh!

rust-timer commented Sep 2, 2022

Uh oh!

rust-timer commented Sep 2, 2022

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants