Uh oh!
There was an error while loading. Please reload this page.
Fix invalid display of enum sub-fields docs - #44192
Conversation
rust-highfive
commented
Aug 30, 2017
Some changes occurred in HTML/CSS. |
rust-highfive
commented
Aug 30, 2017
(rust_highfive has picked a reviewer for you, use r? to override) |
QuietMisdreavus
commented
Aug 30, 2017
What version of rustdoc was used to render that "before" example? It looks like it doesn't include #43862. That said, this does include more changes than that. I like the new styling, so i'm inclined to add this anyway. |
GuillaumeGomez
commented
Aug 31, 2017
No idea. It's an old one which didn't have a JS fix. However, the style was still broken so this PR fixes it. |
nox
commented
Aug 31, 2017
Initial screenshot is with Servo's nightly Rust, which is 13d94d5. |
nox
commented
Aug 31, 2017
So I guess servo/servo#18325 should fix our issue, given that does a rustup. |
QuietMisdreavus
commented
Aug 31, 2017
It fixes the issue, yeah, but this CSS change still adds some much-needed padding to the toggle labels. With just that JS change, there's no space between the For example, here's @bors r+ rollup |
bors
commented
Aug 31, 2017
📌 Commit bde0071 has been approved by |
…QuietMisdreavus Fix invalid display of enum sub-fields docs Before: <img width="1440" alt="screen shot 2017-08-30 at 23 17 00" src="https://user-images.githubusercontent.com/3050060/29895433-61f2bf8c-8dd9-11e7-83e8-cf1dca878100.png"> After: <img width="1440" alt="screen shot 2017-08-30 at 23 16 48" src="https://user-images.githubusercontent.com/3050060/29895441-66dea042-8dd9-11e7-9576-11b0c770c70b.png"> cc @nox @rust-lang/docs
…QuietMisdreavus Fix invalid display of enum sub-fields docs Before: <img width="1440" alt="screen shot 2017-08-30 at 23 17 00" src="https://user-images.githubusercontent.com/3050060/29895433-61f2bf8c-8dd9-11e7-83e8-cf1dca878100.png"> After: <img width="1440" alt="screen shot 2017-08-30 at 23 16 48" src="https://user-images.githubusercontent.com/3050060/29895441-66dea042-8dd9-11e7-9576-11b0c770c70b.png"> cc @nox @rust-lang/docs
…r=notriddle Remove unused .toggle-label CSS rule It was added in rust-lang#44192 but since we moved to `<details>`, we don't use this rule any more. r? `@notriddle`

Before:
After:
cc @nox @rust-lang/docs