Uh oh!
There was an error while loading. Please reload this page.
Do not overwrite lifetime binders for another HirId. - #101454
Conversation
rust-highfive
commented
Sep 5, 2022
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
The diagnostic looks a bit silly. I don't know why we are choosing a 'b for the inner param.
bors
commented
Sep 27, 2022
☔ The latest upstream changes (presumably #102306) made this pull request unmergeable. Please resolve the merge conflicts. |
c7a0220 to
337a73dCompare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1952568 to
dd69ce3Compareestebank
commented
Sep 28, 2022
@bors r+ |
bors
commented
Sep 28, 2022
bors
commented
Sep 28, 2022
bors
commented
Sep 28, 2022
☀️ Test successful - checks-actions |
rust-timer
commented
Sep 28, 2022
Finished benchmarking commit (307dd93): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. |
Do not overwrite lifetime binders for another HirId. This PR makes higher-ranked bounds in where clauses a bit more principled. We used to conflate `for<'a> T: Trait` with `(for<'a> T): Trait`. This PR separates both binders. This caused issued with fn types, which have their own binder, causing us to overwrite the predicates's binders with `fn`'s binders, ICEing. Fixesrust-lang#98594
This PR makes higher-ranked bounds in where clauses a bit more principled.
We used to conflate
for<'a> T: Traitwith(for<'a> T): Trait.This PR separates both binders.
This caused issued with fn types, which have their own binder, causing us to overwrite the predicates's binders with
fn's binders, ICEing.Fixes#98594