Skip to content

Move Queries::new out of the macro - #101635

Merged
bors merged 1 commit into
rust-lang:masterfrom
jyn514:queries-new-derived
Sep 10, 2022
Merged

Move Queries::new out of the macro#101635
bors merged 1 commit into
rust-lang:masterfrom
jyn514:queries-new-derived

Conversation

@jyn514

Copy link
Copy Markdown
Member

Split out from #101178 to make sure it's not contributing to the perf impact.

r? @cjgillot

@rustbotrustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 10, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 10, 2022
@jyn514

Copy link
Copy Markdown
MemberAuthor

@bors try @rust-timer queue

@rust-timer

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 10, 2022
@bors

bors commented Sep 10, 2022

Copy link
Copy Markdown
Collaborator

⌛ Trying commit d2c53ca with merge a256dbf44508d90594a50b5e9a7aa4f1e857b939...

@bors

bors commented Sep 10, 2022

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: a256dbf44508d90594a50b5e9a7aa4f1e857b939 (a256dbf44508d90594a50b5e9a7aa4f1e857b939)

@rust-timer

Copy link
Copy Markdown
Collaborator

Queued a256dbf44508d90594a50b5e9a7aa4f1e857b939 with parent 1d37ed6, future comparison URL.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (a256dbf44508d90594a50b5e9a7aa4f1e857b939): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1rangecount2
Regressions ❌
(primary)
3.4%[1.1%, 5.7%]2
Regressions ❌
(secondary)
3.1%[0.4%, 5.9%]4
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)3.4%[1.1%, 5.7%]2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1rangecount2
Regressions ❌
(primary)
2.5%[2.5%, 2.5%]1
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.2%[-2.2%, -2.2%]1
Improvements ✅
(secondary)
-0.4%[-0.4%, -0.4%]1
All ❌✅ (primary)0.1%[-2.2%, 2.5%]2

Footnotes

  1. the arithmetic mean of the percent change2

  2. number of relevant changes2

@cjgillot

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Sep 10, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit d2c53ca has been approved by cjgillot

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2022
@Dylan-DPCDylan-DPC mentioned this pull request Sep 10, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 10, 2022
Rollup of 6 pull requests
Successful merges:
- rust-lang#101578 (remove bound var hack in `resolve`)
- rust-lang#101606 (doc: fix minor typo)
- rust-lang#101614 (Equate fn outputs when inferring RPITIT hidden types)
- rust-lang#101631 (rustdoc: avoid cleaning modules with duplicate names)
- rust-lang#101635 (Move `Queries::new` out of the macro)
- rust-lang#101641 (Update browser-ui-test version to 0.9.8)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit b0455e9 into rust-lang:masterSep 10, 2022
@rustbotrustbot added this to the 1.65.0 milestone Sep 10, 2022
@jyn514
jyn514 deleted the queries-new-derived branch September 10, 2022 18:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.S-waiting-on-perfStatus: Waiting on a perf run to be completed.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@jyn514@rust-timer@bors@cjgillot@rust-highfive@rustbot