Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #101652
Merged
Merged
Conversation
remove bound var hack in `resolve` somehow dropped that change from rust-lang#98900. r? `@jackh726`
doc: fix minor typo
Equate fn outputs when inferring RPITIT hidden types
When we are trying to infer the hidden types for RPITITs, we need to equate the output tys instead of just subtyping them. For example:
```rust
trait Foo { fn bar() -> impl Sized {} }
impl Foo for () { fn bar() -> &'static str { "" } }
```
If we just subtype the signatures `fn() -> &'static str <: fn() -> _#1t` (where `_#1t` is the variable we've used to infer `impl Sized`), we'll end up `&'static str <: _#1t`, which causes us to infer `_#1t = #'_#2r str`, where `'_#2r` is unconstrained, which gets fixed up to `ReEmpty`, and which is certainly not what we want.
I can't actually think of a way to make this fail to compile, because during borrowck we've already done the method probe, and so we just look at the `impl` method signature and see the `&'static str` any time we call `<() as Foo>::bar()`. But this _does_ cause the ICE [here](rust-lang#98559 (comment)) in `@jackh726's` "Remove ReEmpty" PR (rust-lang#98559) to stop ICEing, because after that PR we were leaking unconstrained region variables into the typeck results.
r? types…le, r=GuillaumeGomez rustdoc: avoid cleaning modules with duplicate names Fixesrust-lang#83375
…llot Move `Queries::new` out of the macro Split out from rust-lang#101178 to make sure it's not contributing to the perf impact. r? `@cjgillot`
…est, r=Dylan-DPC Update browser-ui-test version to 0.9.8 This version improves the error output mostly. r? `@Dylan-DPC`
Dylan-DPC
commented
Sep 10, 2022
MemberAuthor
@bors r+ rollup=never p=5 |
bors
commented
Sep 10, 2022
Collaborator
bors
commented
Sep 10, 2022
Collaborator
bors
commented
Sep 10, 2022
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Sep 10, 2022
Collaborator
📌 Perf builds for each rolled up PR: previous master: 2e44c17c12 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
rust-timer
commented
Sep 11, 2022
Collaborator
Finished benchmarking commit (1463688): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
Contributor
i would expect the perf impact to be from #101578, forgot to mark that pr as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
resolve#101578 (remove bound var hack inresolve)Queries::newout of the macro #101635 (MoveQueries::newout of the macro)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup