Uh oh!
There was an error while loading. Please reload this page.
Resolve async fn signature even without body (e.g., in trait) - #102161
Merged
Conversation
rust-highfive
commented
Sep 22, 2022
Contributor
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
tmandry
reviewed
Sep 22, 2022
Uh oh!
There was an error while loading. Please reload this page.
tmandry
reviewed
Sep 22, 2022
Uh oh!
There was an error while loading. Please reload this page.
tmandry
commented
Sep 22, 2022
Member
r=me after comments |
compiler-errors
commented
Sep 22, 2022
ContributorAuthor
Ugh, actually this passes now and might not after the changes: fnmain(){}traitFoo{fnfn_with_type_named_same_as_local_in_param(b:i32,b:i32);}Let me see if I can avoid this. |
compiler-errorsforce-pushed
the
issue-102138
branch
2 times, most recently
from
September 23, 2022 00:54
3ba9fab to
271a068Comparecompiler-errors
commented
Sep 23, 2022
ContributorAuthor
Okay, fixed that bug by just doing the only part of resolve that we need for AFIT. |
davidtwco
commented
Sep 23, 2022
Member
r? @tmandry |
tmandry
commented
Sep 23, 2022
Member
@bors r+ |
bors
commented
Sep 23, 2022
Collaborator
📌 Commit 271a0680197e08405c67dd0b4d4bac87ea9a28bc has been approved by It is now in the queue for this repository. |
tmandry
commented
Sep 23, 2022
Member
Actually, want to add a test for this? (and r=me) Not sure it's the behavior I would want, but it's too late for that anyway :) @bors r- |
compiler-errorsforce-pushed
the
issue-102138
branch
from
September 24, 2022 19:27
5029212 to
e87fcc0Comparecompiler-errors
commented
Sep 24, 2022
ContributorAuthor
@bors r=tmandry |
bors
commented
Sep 24, 2022
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 24, 2022
…andry Resolve async fn signature even without body (e.g., in trait) Fixesrust-lang#102138 This "bail if no body" behavior was introduced in rust-lang#69539 to fixrust-lang#69401, but that ICE does not reproduce any more. The error message changes a bit, but that's all, and I don't think it's a particularly diagnostic bad regression.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 25, 2022
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#102016 (implied_bounds: deal with inference vars) - rust-lang#102161 (Resolve async fn signature even without body (e.g., in trait)) - rust-lang#102216 (rustdoc: Stabilize --diagnostic-width) - rust-lang#102240 (rustdoc: remove unused CSS `#main-content > .line-numbers`) - rust-lang#102242 (rustdoc: remove unused CSS `.summary`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#102138
This "bail if no body" behavior was introduced in #69539 to fix#69401, but that ICE does not reproduce any more. The error message changes a bit, but that's all, and I don't think it's a particularly diagnostic bad regression.