Skip to content

Rollup of 5 pull requests - #102254

Merged
bors merged 13 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-gitu6li
Sep 25, 2022
Merged

Rollup of 5 pull requests#102254
bors merged 13 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-gitu6li

Conversation

@matthiaskrgr

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

lcnrand others added 13 commits September 19, 2022 15:13
This selector was added in 10b9370. It
became unreachable when 09150f8 made it so
that `.line-numbers` are always nested below `.example-wrap`, even on
source pages.
It was added in 4d16de0 as part of a
stability dashboard that was removed in
0a46933.
…jackh726
implied_bounds: deal with inference vars
fixesrust-lang#101951
while computing implied bounds for `<<T as ConstructionFirm>::Builder as BuilderFn<'_>>::Output` normalization replaces a projection with an inference var (adding a `Projection` obligation). Until we prove that obligation, this inference var remains unknown, which caused us to miss an implied bound necessary to prove that the unnormalized projection from the trait method signature is wf.
r? types
…andry
Resolve async fn signature even without body (e.g., in trait)
Fixesrust-lang#102138
This "bail if no body" behavior was introduced in rust-lang#69539 to fixrust-lang#69401, but that ICE does not reproduce any more. The error message changes a bit, but that's all, and I don't think it's a particularly diagnostic bad regression.
…notriddle
rustdoc: Stabilize --diagnostic-width
This stabilizes the `--diagnostic-width` flag for rustdoc. This flag was stabilized in rustc in rust-lang#95635, but it isn't clear from the discussion there why it wasn't stabilized in rustdoc. I believe this flag works as expected, following the same behavior as rustc.
I'd like to stabilize this so that the same support can be stabilized in cargo, and it would help simplify things if both rustc and rustdoc supported it.
…ers, r=GuillaumeGomez
rustdoc: remove unused CSS `#main-content > .line-numbers`
This selector was added in 10b9370. It became unreachable when 09150f8 made it so that `.line-numbers` are always nested below `.example-wrap`, even on source pages.
…llaumeGomez
rustdoc: remove unused CSS `.summary`
It was added in 4d16de0 as part of a stability dashboard that was removed in 0a46933.
@rustbotrustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 25, 2022
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Sep 25, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit c6870cc has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 25, 2022
@bors

bors commented Sep 25, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c6870cc with merge 6f6010b...

@bors

bors commented Sep 25, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 6f6010b to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Sep 25, 2022
@bors
bors merged commit 6f6010b into rust-lang:masterSep 25, 2022
@rustbotrustbot added this to the 1.66.0 milestone Sep 25, 2022
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#Perf Build Sha
#102242aedb1b8db42adb902eea7aafb489146e38a36024
#1022400cf52f60794482a53f7084072c397b2035ee2b3e
#102216e6fc71cb135a7c914b958701d9245dfcd683f66d
#102161058e69b344911b1d37a820a0c663bddae1eacdfc
#1020165389c90d13b487a515e6e5adb28cfd8d86bc9085

previous master: 8e9c93df46

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (6f6010b): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1rangecount2
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
3.3%[3.3%, 3.3%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1rangecount2
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-4.0%[-4.0%, -4.0%]1
All ❌✅ (primary)--0

Cycles

This benchmark run did not return any relevant results for this metric.

Footnotes

  1. the arithmetic mean of the percent change2

  2. number of relevant changes2

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@matthiaskrgr@bors@rust-timer@rustbot@lcnr@ehuss@notriddle@compiler-errors