Uh oh!
There was an error while loading. Please reload this page.
Allow #[unstable] impls for fn() with unstable abi. - #103239
Merged
Merged
Conversation
rust-highfive
commented
Oct 19, 2022
Contributor
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
commented
Oct 19, 2022
Contributor
|
lcnr
reviewed
Oct 19, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
lcnr
commented
Oct 19, 2022
Contributor
r? @lcnr after dealing with function pointers and |
(But not fn() -> !, which is stable.)
lcnr
commented
Oct 19, 2022
Contributor
@bors r+ rollup |
bors
commented
Oct 19, 2022
Collaborator
Dylan-DPC added a commit
to Dylan-DPC/rust
that referenced
this pull request
Oct 19, 2022
…, r=lcnr Allow #[unstable] impls for fn() with unstable abi. This allows `#[unstable]` trait impls for `extern "unwind-C" fn()`, based on the fact that that abi and therefore that type is unstable. See rust-lang#101263 (comment)
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 19, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#103211 (rustdoc: remove class name `location` from sidebar sibling nav) - rust-lang#103223 (Use already checked RHS ty for LHS deref suggestions) - rust-lang#103237 (Clean up codeblock-tooltip rustdoc-gui test) - rust-lang#103239 (Allow #[unstable] impls for fn() with unstable abi.) - rust-lang#103246 (Mark `rust-analyzer` as a host-only tool) - rust-lang#103257 (rustdoc: move `setting-line` color CSS to settings.css) - rust-lang#103258 (Make miri read_dir test a little more robust) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Aaron1011 pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#103211 (rustdoc: remove class name `location` from sidebar sibling nav) - rust-lang#103223 (Use already checked RHS ty for LHS deref suggestions) - rust-lang#103237 (Clean up codeblock-tooltip rustdoc-gui test) - rust-lang#103239 (Allow #[unstable] impls for fn() with unstable abi.) - rust-lang#103246 (Mark `rust-analyzer` as a host-only tool) - rust-lang#103257 (rustdoc: move `setting-line` color CSS to settings.css) - rust-lang#103258 (Make miri read_dir test a little more robust) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows
#[unstable]trait impls forextern "unwind-C" fn(), based on the fact that that abi and therefore that type is unstable.See #101263 (comment)