Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #103264
Merged
Merged
Conversation
This change tweaks the CSS to apply most of its styles to `.sidebar h2`, cleaning up a few redundant rules from `.mobile-topbar .location` and restoring useful navigation aids in mobile mode.
(But not fn() -> !, which is stable.)
All tools meant to be shipped with host toolchains only should be marked as `ONLY_HOSTS = true`, but rust-analyzer was marked as `ONLY_HOSTS = false` incorrectly. This meant that bootstrap attempted to build rust-analyzer for cross-compilation-only targets, causing errors because libstd is not present on some of them. It will still be possible to cross-compile rust-analyzer by passing a different --host flag to ./x, like you can cross-compile other tools.
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
…r=GuillaumeGomez rustdoc: remove class name `location` from sidebar sibling nav Preview: https://notriddle.com/notriddle-rustdoc-demos/sidebar-location/std/vec/struct.Vec.html This change tweaks the CSS to apply most of its styles to `.sidebar h2`, cleaning up a few redundant rules from `.mobile-topbar .location` and restoring useful navigation aids in mobile mode. ## Before  ## After 
…=wesleywiser Use already checked RHS ty for LHS deref suggestions There's no reason to do the `check_lhs_assignable` and RHS `check_expr_with_hint` in that order, so invert them and use the typeck results to avoid exponential blowup on error. Fixesrust-lang#103219
…leanup, r=notriddle Clean up codeblock-tooltip rustdoc-gui test r? ``@notriddle``
…, r=lcnr Allow #[unstable] impls for fn() with unstable abi. This allows `#[unstable]` trait impls for `extern "unwind-C" fn()`, based on the fact that that abi and therefore that type is unstable. See rust-lang#101263 (comment)
…r=Mark-Simulacrum Mark `rust-analyzer` as a host-only tool All tools meant to be shipped with host toolchains only should be marked as `ONLY_HOSTS = true`, but rust-analyzer was marked as `ONLY_HOSTS = false` incorrectly. This meant that bootstrap attempted to build rust-analyzer for cross-compilation-only targets, causing errors because libstd is not present on some of them. It will still be possible to cross-compile rust-analyzer by passing a different `--host` flag to `./x`, like you can cross-compile other tools. The problem can be reproduced by running: ``` ./x build src/tools/rust-analyzer --target x86_64-unknown-linux-gnu,aarch64-unknown-none ```
…r=GuillaumeGomez rustdoc: move `setting-line` color CSS to settings.css
Make miri read_dir test a little more robust r? `@RalfJung`
matthiaskrgr
commented
Oct 19, 2022
MemberAuthor
@bors r+ rollup=never p=7 |
bors
commented
Oct 19, 2022
Collaborator
bors
commented
Oct 19, 2022
Collaborator
bors
commented
Oct 20, 2022
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Oct 20, 2022
Collaborator
📌 Perf builds for each rolled up PR: previous master: 4b8f431995 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
rust-timer
commented
Oct 20, 2022
Collaborator
Finished benchmarking commit (57781b2): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Footnotes |
Aaron1011 pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#103211 (rustdoc: remove class name `location` from sidebar sibling nav) - rust-lang#103223 (Use already checked RHS ty for LHS deref suggestions) - rust-lang#103237 (Clean up codeblock-tooltip rustdoc-gui test) - rust-lang#103239 (Allow #[unstable] impls for fn() with unstable abi.) - rust-lang#103246 (Mark `rust-analyzer` as a host-only tool) - rust-lang#103257 (rustdoc: move `setting-line` color CSS to settings.css) - rust-lang#103258 (Make miri read_dir test a little more robust) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
locationfrom sidebar sibling nav #103211 (rustdoc: remove class namelocationfrom sidebar sibling nav)rust-analyzeras a host-only tool #103246 (Markrust-analyzeras a host-only tool)setting-linecolor CSS to settings.css #103257 (rustdoc: movesetting-linecolor CSS to settings.css)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup