Don't set `is_preview` for clippy and rustfmt by jyn514 · Pull Request #103648 · rust-lang/rust

jyn514 · 2022-10-27T18:03:13Z

These have been shipped on stable for many years now and it would be very disruptive to ever remove them.
Remove the -preview suffix from their dist components.

Based on #102565.

rustbot · 2022-10-27T18:03:19Z

r? @jyn514

(rustbot has picked a reviewer for you, use r? to override)

jyn514 · 2022-10-27T18:03:27Z

lol

r? @Mark-Simulacrum

Mark-Simulacrum · 2022-10-29T23:24:31Z

@bors try

Want to get a dev-static build here too so we can test it.

bors · 2022-10-29T23:25:08Z

⌛ Trying commit 1401417c677e86b53bfe98358476f94dc6d78b21 with merge 880ff5e0182c0ff4c0c48d3d87cfa6dc92d6dadc...

bors · 2022-10-30T02:05:26Z

☀️ Try build successful - checks-actions
Build commit: 880ff5e0182c0ff4c0c48d3d87cfa6dc92d6dadc (880ff5e0182c0ff4c0c48d3d87cfa6dc92d6dadc)

Mark-Simulacrum · 2022-11-08T13:31:25Z

Kicked off dev-static for this try commit.

jyn514 · 2022-11-09T08:17:27Z

Looks like this is working too :)

; RUSTUP_DIST_SERVER=https://dev-static.rust-lang.org rustup toolchain install nightly-2022-11-08
info: syncing channel updates for 'nightly-2022-11-08-x86_64-unknown-linux-gnu'
info: latest update on 2022-11-08, rust version 1.66.0-nightly (880ff5e01 2022-10-29)
info: downloading component 'cargo'
info: downloading component 'clippy'
info: downloading component 'rust-docs'
19.0 MiB / 19.0 MiB (100 %) 12.5 MiB/s in 2s ETA: 0s
info: downloading component 'rust-std'
29.6 MiB / 29.6 MiB (100 %) 12.4 MiB/s in 3s ETA: 0s
info: downloading component 'rustc'
67.9 MiB / 67.9 MiB (100 %) 11.2 MiB/s in 6s ETA: 0s
info: downloading component 'rustfmt'
info: installing component 'cargo'
info: installing component 'clippy'
info: installing component 'rust-docs'
19.0 MiB / 19.0 MiB (100 %) 894.4 KiB/s in 59s ETA: 0s info: installing component 'rust-std'
29.6 MiB / 29.6 MiB (100 %) 8.2 MiB/s in 6s ETA: 0s
6 IO-ops / 6 IO-ops (100 %) 0 IOPS in 6s ETA: Unknown
info: installing component 'rustc'
67.9 MiB / 67.9 MiB (100 %) 13.3 MiB/s in 5s ETA: 0s
5 IO-ops / 5 IO-ops (100 %) 0 IOPS in 16s ETA: Unknown
info: installing component 'rustfmt'
nightly-2022-11-08-x86_64-unknown-linux-gnu installed - rustc 1.66.0-nightly (880ff5e01 2022-10-29)
info: checking for self-updates
(bash@pop-os) ~/rust-lang/rust2 [02:14:53, dry-run-progress]
; cargo +nightly-2022-11-08-x86_64-unknown-linux-gnu clippy --version
clippy 0.1.66 (880ff5e 2022-10-29)
(bash@pop-os) ~/rust-lang/rust2 [02:16:14, dry-run-progress]
; cargo +nightly-2022-11-08-x86_64-unknown-linux-gnu rustfmt --version
(bash@pop-os) ~/rust-lang/rust2 [02:16:24, dry-run-progress]
; cargo +nightly-2022-11-08-x86_64-unknown-linux-gnu fmt --version
rustfmt 1.5.1-nightly (880ff5e 2022-10-29)

I'll wait for #102565 to merge before approving this PR.

jyn514 · 2022-11-12T21:45:00Z

@bors r=Mark-Simulacrum

bors · 2022-11-12T21:45:02Z

📌 Commit 01b9c88 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

Don't set `is_preview` for clippy and rustfmt These have been shipped on stable for many years now and it would be very disruptive to ever remove them. Remove the `-preview` suffix from their dist components. Based on rust-lang#102565.

JohnTitor · 2022-11-13T07:41:12Z

Failed in rollup: #104340 (comment)
@bors r-

jyn514 · 2022-11-17T03:33:43Z

@bors r=Mark-Simulacrum

(Missed an instance of hardcoding "clippy-preview" in dist.rs)

bors · 2022-11-17T03:33:45Z

📌 Commit da27179c337d9f91bba0af1ce229dbf13f36e0c4 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors · 2022-11-17T03:33:46Z

🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened.

jyn514 · 2022-11-17T04:51:28Z

@bors r-

These have been shipped on stable for many years now and it would be very disruptive to ever remove them. Remove the `-preview` suffix from their dist components.

jyn514 · 2022-11-25T01:25:33Z

@bors r=Mark-Simulacrum

; rg -l -- clippy-preview
RELEASES.md
library/stdarch/ci/style.sh
src/tools/clippy/CHANGELOG.md
src/tools/cargo/CHANGELOG.md
; rg -- rustfmt-preview
src/bootstrap/download.rs
329: // cfg(bootstrap): will need to be changed from `rustfmt-preview` to `rustfmt` the next time you run `bump-stage0`.
331: self.download_component(DownloadSource::Dist, filename, "rustfmt-preview", &date, "stage0");
library/stdarch/ci/style.sh
5:if rustup component add rustfmt-preview ; then

bors · 2022-11-25T01:25:35Z

📌 Commit fb3e724 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

Don't set `is_preview` for clippy and rustfmt These have been shipped on stable for many years now and it would be very disruptive to ever remove them. Remove the `-preview` suffix from their dist components. Based on rust-lang#102565.

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#103648 (Don't set `is_preview` for clippy and rustfmt) - rust-lang#104654 (Add `#![deny(unsafe_op_in_unsafe_fn)]` in liballoc tests) - rust-lang#104793 (unstable-book: Add page for the `abi_efiapi` feature) - rust-lang#104841 (Assert that we don't capture escaping bound vars in `Fn` trait selection) - rust-lang#104849 (Migrate source code elements style to CSS variables) - rust-lang#104873 (RefCell::get_mut: fix typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

cuviper · 2023-01-13T01:49:55Z

This was reverted in #104950.

@rustbot label -relnotes

jyn514 added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Oct 27, 2022

rustbot assigned jyn514 Oct 27, 2022

rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2022

rustbot assigned Mark-Simulacrum and unassigned jyn514 Oct 27, 2022

fmease mentioned this pull request Oct 27, 2022
A case where rustbot assigned the PR author as the reviewer rust-lang/triagebot#1662
Closed

jyn514 force-pushed the no-preview branch from 1401417 to 01b9c88Compare November 12, 2022 21:43

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2022

Manishearth mentioned this pull request Nov 12, 2022
Rollup of 6 pull requests #104340
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 13, 2022

jyn514 force-pushed the no-preview branch 2 times, most recently from fd2fb15 to da27179Compare November 17, 2022 03:33

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 17, 2022

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 17, 2022

This comment has been minimized.
Sign in to view

Don't set is_preview for clippy and rustfmt
fb3e724
These have been shipped on stable for many years now and it would be very disruptive to ever remove them. Remove the `-preview` suffix from their dist components.

jyn514 force-pushed the no-preview branch from da27179 to fb3e724Compare November 25, 2022 01:22

rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Nov 25, 2022

jyn514 added relnotes Marks issues that should be documented in the release notes of the next release. and removed T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 25, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 25, 2022

matthiaskrgr mentioned this pull request Nov 25, 2022
Rollup of 6 pull requests #104869
Closed

matthiaskrgr mentioned this pull request Nov 25, 2022
Rollup of 6 pull requests #104877
Merged

bors merged commit a9313e9 into rust-lang:masterNov 25, 2022

rustbot added this to the 1.67.0 milestone Nov 25, 2022

jyn514 deleted the no-preview branch November 25, 2022 16:06

matthiaskrgr mentioned this pull request Nov 26, 2022
rustfmt / clippy component missing #104930
Closed

rustbot removed the relnotes Marks issues that should be documented in the release notes of the next release. label Jan 13, 2023

Uh oh!

Uh oh!

Conversation

jyn514 commented Oct 27, 2022

Uh oh!

rustbot commented Oct 27, 2022

Uh oh!

jyn514 commented Oct 27, 2022

Uh oh!

Mark-Simulacrum commented Oct 29, 2022

Uh oh!

bors commented Oct 29, 2022

Uh oh!

bors commented Oct 30, 2022

Uh oh!

Mark-Simulacrum commented Nov 8, 2022

Uh oh!

jyn514 commented Nov 9, 2022

Uh oh!

jyn514 commented Nov 12, 2022

Uh oh!

bors commented Nov 12, 2022

Uh oh!

JohnTitor commented Nov 13, 2022

Uh oh!

jyn514 commented Nov 17, 2022

Uh oh!

bors commented Nov 17, 2022

Uh oh!

bors commented Nov 17, 2022

Uh oh!

jyn514 commented Nov 17, 2022

Uh oh!

This comment has been minimized.

jyn514 commented Nov 25, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Nov 25, 2022

Uh oh!

cuviper commented Jan 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jyn514 commented Nov 25, 2022•
edited
Loading