Skip to content

Assert that we don't capture escaping bound vars in Fn trait selection - #104841

Merged
bors merged 3 commits into
rust-lang:masterfrom
compiler-errors:fishy-bound-var
Nov 25, 2022
Merged

Assert that we don't capture escaping bound vars in Fn trait selection#104841
bors merged 3 commits into
rust-lang:masterfrom
compiler-errors:fishy-bound-var

Conversation

@compiler-errors

Copy link
Copy Markdown
Contributor

Fixes#104825

@rustbot

Copy link
Copy Markdown
Collaborator

r? @estebank

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 24, 2022
@jackh726

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 770c3416aa3798ea7c003946a1999bc948b8b961 has been approved by jackh726

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2022
@compiler-errors

Copy link
Copy Markdown
ContributorAuthor

Hold up, wanted to add a check for fn pointers too while we're at it.

@jackh726

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 86c5f0a8347c7b0eea54e9770979a46437a43a68 has been approved by jackh726

It is now in the queue for this repository.

Comment threadcompiler/rustc_trait_selection/src/traits/select/confirmation.rs Outdated
@oli-obk

Copy link
Copy Markdown
Contributor

@bors r=jackh726

@bors

bors commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 581ee96d40314cc88d6a5698c1da7eed8e8fb37d has been approved by jackh726

It is now in the queue for this repository.

@bors

bors commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #104321) made this pull request unmergeable. Please resolve the merge conflicts.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 24, 2022
@compiler-errors

Copy link
Copy Markdown
ContributorAuthor

@bors r=jackh726

@bors

bors commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit d945967 has been approved by jackh726

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 24, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2022
…iaskrgr
Rollup of 11 pull requests
Successful merges:
- rust-lang#104514 (Use node_ty_opt to avoid ICE in visit_ty)
- rust-lang#104704 (Allow power10-vector feature in PowerPC)
- rust-lang#104747 (resolve: Don't use constructor def ids in the map for field names)
- rust-lang#104773 (OpaqueCast projections are always overlapping, they can't possibly be disjoint)
- rust-lang#104774 (Document split{_ascii,}_whitespace() for empty strings)
- rust-lang#104780 (make `error_reported` check for delayed bugs)
- rust-lang#104782 (Bump the const eval step limit)
- rust-lang#104792 (rustdoc: simplify `.search-results-title` CSS)
- rust-lang#104796 (lint: do not warn unused parens around higher-ranked function pointers)
- rust-lang#104820 (Remove normalize_projection_type)
- rust-lang#104822 (with_query_mode -> new)
Failed merges:
- rust-lang#104716 (move 2 candidates into builtin candidate)
- rust-lang#104841 (Assert that we don't capture escaping bound vars in `Fn` trait selection)
r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 25, 2022
…=jackh726
Assert that we don't capture escaping bound vars in `Fn` trait selection
Fixesrust-lang#104825
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 25, 2022
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#103648 (Don't set `is_preview` for clippy and rustfmt)
- rust-lang#104654 (Add `#![deny(unsafe_op_in_unsafe_fn)]` in liballoc tests)
- rust-lang#104793 (unstable-book: Add page for the `abi_efiapi` feature)
- rust-lang#104841 (Assert that we don't capture escaping bound vars in `Fn` trait selection)
- rust-lang#104849 (Migrate source code elements style to CSS variables)
- rust-lang#104873 (RefCell::get_mut: fix typo)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 34f1de8 into rust-lang:masterNov 25, 2022
@rustbotrustbot added this to the 1.67.0 milestone Nov 25, 2022
@compiler-errors
compiler-errors deleted the fishy-bound-var branch August 11, 2023 20:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"fishy" skip_binder actually ignoring bound variables

6 participants

@compiler-errors@rustbot@jackh726@bors@oli-obk@estebank