Skip to content

rustdoc: rename CSS rustdoc-toggle -> toggle and toggle -> settings-toggle - #106693

Merged
bors merged 1 commit into
rust-lang:masterfrom
notriddle:notriddle/toggle-trunc
Jan 14, 2023
Merged

rustdoc: rename CSS rustdoc-toggle -> toggle and toggle -> settings-toggle#106693
bors merged 1 commit into
rust-lang:masterfrom
notriddle:notriddle/toggle-trunc

Conversation

@notriddle

@notriddlenotriddle commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

This swaps things around so that the class that gets used more often has the shorter name.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 10, 2023
@rustbot

rustbot commented Jan 10, 2023

Copy link
Copy Markdown
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@GuillaumeGomez

GuillaumeGomez commented Jan 10, 2023

Copy link
Copy Markdown
Member

CI isn't happy.

@notriddle

notriddle commented Jan 10, 2023

Copy link
Copy Markdown
ContributorAuthor
Not my fault
Caused by:
failed to get successful HTTP response from `[https://crates.io/api/v1/crates/gimli/0.26.1/download`](https://crates.io/api/v1/crates/gimli/0.26.1/download%60), got 503
body:
<!DOCTYPE html>
<html>
<head>
<meta name="viewport" content="width=device-width, initial-scale=1">
<meta charset="utf-8">
<title>Application Error</title>
<style media="screen">
html,body,iframe {
margin: 0;
padding: 0;
}
html,body {
height: 100%;
overflow: hidden;
}
iframe {
width: 100%;
height: 100%;
border: 0;
}
</style>
</head>
<body>
<iframe src="//www.herokucdn.com/error-pages/application-error.html"></iframe>
</body>
</html>

@GuillaumeGomez

GuillaumeGomez commented Jan 10, 2023

Copy link
Copy Markdown
Member

Restarted CI.

@GuillaumeGomez

GuillaumeGomez commented Jan 13, 2023

Copy link
Copy Markdown
Member

That will reduce the generated doc size a bit too. You'll need to rebase though.

@notriddle
rustdoc: rename CSS rustdoc-toggle -> toggle and toggle -> settings-t…
1d328de
…oggle
This swaps things around so that the class that gets used more often has
the shorter name.
@notriddle
notriddleforce-pushed the notriddle/toggle-trunc branch from 3650757 to 1d328deCompareJanuary 13, 2023 19:38
@notriddle

notriddle commented Jan 13, 2023

Copy link
Copy Markdown
ContributorAuthor

@bors r=GuillaumeGomez rollup

@bors

bors commented Jan 13, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 1d328de has been approved by GuillaumeGomez

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2023
@JohnTitorJohnTitor mentioned this pull request Jan 14, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2023
@bors
Auto merge ofrust-lang#106833- JohnTitor:rollup-z8398jk, r=JohnTitor
c0b8735
Rollup of 13 pull requests
Successful merges:
- rust-lang#104965 (reword Option::as_ref and Option::map examples)
- rust-lang#105172 (Added error documentation for write_fmt)
- rust-lang#106605 (rustdoc: fix outdated lint section of the book)
- rust-lang#106670 (Check compiler docs in PR CI)
- rust-lang#106692 (mv binary_heap.rs binary_heap/mod.rs)
- rust-lang#106693 (rustdoc: rename CSS rustdoc-toggle -> toggle and toggle -> settings-toggle)
- rust-lang#106707 (Remove duplicate sha-1 dependency)
- rust-lang#106762 (Add `AtomicPtr::as_mut_ptr`)
- rust-lang#106766 (Remove dead code in rustdoc stripper)
- rust-lang#106775 (Remove stale reference to the test suite location)
- rust-lang#106799 (Stop having unused lifetimes on some `impl`s)
- rust-lang#106816 (Update `rental` hack to work with remapped paths.)
- rust-lang#106819 (rustdoc: remove unnecessary DOM class `h1.fqn`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 1584667 into rust-lang:masterJan 14, 2023
@rustbotrustbot added this to the 1.68.0 milestone Jan 14, 2023
@notriddle
notriddle deleted the notriddle/toggle-trunc branch January 25, 2023 04:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

4 participants

@notriddle@rustbot@GuillaumeGomez@bors