Uh oh!
There was an error while loading. Please reload this page.
Remove dead code in rustdoc stripper - #106766
Merged
Merged
Conversation
notriddle
commented
Jan 13, 2023
Contributor
@bors r+ rollup |
bors
commented
Jan 13, 2023
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 14, 2023
Rollup of 13 pull requests Successful merges: - rust-lang#104965 (reword Option::as_ref and Option::map examples) - rust-lang#105172 (Added error documentation for write_fmt) - rust-lang#106605 (rustdoc: fix outdated lint section of the book) - rust-lang#106670 (Check compiler docs in PR CI) - rust-lang#106692 (mv binary_heap.rs binary_heap/mod.rs) - rust-lang#106693 (rustdoc: rename CSS rustdoc-toggle -> toggle and toggle -> settings-toggle) - rust-lang#106707 (Remove duplicate sha-1 dependency) - rust-lang#106762 (Add `AtomicPtr::as_mut_ptr`) - rust-lang#106766 (Remove dead code in rustdoc stripper) - rust-lang#106775 (Remove stale reference to the test suite location) - rust-lang#106799 (Stop having unused lifetimes on some `impl`s) - rust-lang#106816 (Update `rental` hack to work with remapped paths.) - rust-lang#106819 (rustdoc: remove unnecessary DOM class `h1.fqn`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
aDotInTheVoid
commented
Jan 17, 2023
Member
Hmm, I wounder why this isn't needed anymore. It was added to fix impls/import_from_private.rs, but as that (and all the tests) still pass, I guess this is fine. How did you find out that this wasn't needed? |
GuillaumeGomez
commented
Jan 17, 2023
MemberAuthor
When I was working on #106741, I was trying to figure out what was wrong with the JSON output. Since there wasn't much code specific for it, I tried removing a few things around and then I realized that this code in particular wasn't needed. More luck than insight. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No changes when this code is removed.
cc @aDotInTheVoid
r? @notriddle