Skip to content

ConstBlocks are poly if their substs are poly - #106949

Merged
bors merged 2 commits into
rust-lang:masterfrom
compiler-errors:is-poly
Jan 17, 2023
Merged

ConstBlocks are poly if their substs are poly#106949
bors merged 2 commits into
rust-lang:masterfrom
compiler-errors:is-poly

Conversation

@compiler-errors

@compiler-errorscompiler-errors commented Jan 16, 2023

Copy link
Copy Markdown
Contributor

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 16, 2023
@rustbot

rustbot commented Jan 16, 2023

Copy link
Copy Markdown
Collaborator

Some changes occured in rustc_ty_utils::consts.rs

cc @BoxyUwU

@BoxyUwU

BoxyUwU commented Jan 16, 2023

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jan 16, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit fdaac4e has been approved by BoxyUwU

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2023
@BoxyUwUBoxyUwU added the A-const-generics Area: const generics (parameters and arguments) label Jan 16, 2023
@BoxyUwU

BoxyUwU commented Jan 16, 2023

Copy link
Copy Markdown
Member

@bors r- manual rollup go brrr

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 16, 2023
@rustbotrustbot added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Jan 16, 2023
@rustbot

rustbot commented Jan 16, 2023

Copy link
Copy Markdown
Collaborator

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@compiler-errors

compiler-errors commented Jan 16, 2023

Copy link
Copy Markdown
ContributorAuthor

fixed "generic constant" pluralization

@bors r=BoxyUwU

@bors

bors commented Jan 16, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 9f6fef9 has been approved by BoxyUwU

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 16, 2023
@matthiaskrgrmatthiaskrgr mentioned this pull request Jan 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2023
@bors
Auto merge ofrust-lang#106966- matthiaskrgr:rollup-e34pevi, r=matth…
85357e3
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#106591 (suggestion for attempted integer identifier in patterns)
- rust-lang#106712 (make error emitted on `impl &Trait` nicer)
- rust-lang#106829 (Unify `Opaque`/`Projection` handling in region outlives code)
- rust-lang#106869 (rustdoc: remove redundant item kind class from `.item-decl > pre`)
- rust-lang#106949 (ConstBlocks are poly if their substs are poly)
- rust-lang#106953 (Document `EarlyBinder::subst_identity` and `skip_binder`)
- rust-lang#106958 (Don't add A-bootstrap to PRs modifying Cargo.lock)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 9bcc46e into rust-lang:masterJan 17, 2023
@rustbotrustbot added this to the 1.68.0 milestone Jan 17, 2023
@AlexendooAlexendoo mentioned this pull request Jan 18, 2023
Closed
@compiler-errors
compiler-errors deleted the is-poly branch August 11, 2023 20:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BoxyUwUBoxyUwU

Labels

A-const-genericsArea: const generics (parameters and arguments)A-translationArea: Translation infrastructure, and migrating existing diagnostics to SessionDiagnosticS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

[ICEs]: generic_const_exprs

4 participants

@compiler-errors@rustbot@BoxyUwU@bors