Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #106966
Merged
Merged
Conversation
This class originated in the very first commit of `rustdoc_ng`, and was used to add a color border around the item decl based on its kind. https://github.com/rust-lang/rust/blob/4fd061c426902b0904c65e64a3780b21f9ab3afb/src/rustdoc_ng/html/static/main.css#L102-L106 The item decl no longer has a border, and there aren't any kind-specific styles in modern rustdoc's rendering of this UI item. Most of this commit is updating test cases so that they use `item-decl` to find the `<pre>` tag instead of relying on the fact that the class name had `rust {kind}` in it while other `<pre>` tags only had class `rust`.
Changing Cargo.lock is common even when adding dependencies between existing rustc crates.
…er, r=Estebank suggestion for attempted integer identifier in patterns Fixesrust-lang#106552 Implemented a suggestion on `E0005` that occurs when no bindings are present and the pattern is a literal integer.
make error emitted on `impl &Trait` nicer Fixesrust-lang#106694 Turned out to be simpler than I thought, also added UI test. Before: ([playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=9bda53271ef3a8886793cf427b8cea91)) ```text error: expected one of `:`, ``@`,` or `|`, found `)` --> src/main.rs:2:22 | 2 | fn foo(_: impl &Trait) {} | ^ expected one of `:`, ``@`,` or `|` | = note: anonymous parameters are removed in the 2018 edition (see RFC 1685) help: if this is a parameter name, give it a type | 2 | fn foo(_: impl Trait: &TypeName) {} | ~~~~~~~~~~~~~~~~ help: if this is a type, explicitly ignore the parameter name | 2 | fn foo(_: impl _: &Trait) {} | ++ error: expected one of `!`, `(`, `)`, `,`, `?`, `for`, `~`, lifetime, or path, found `&` --> src/main.rs:2:16 | 2 | fn foo(_: impl &Trait) {} | -^ expected one of 9 possible tokens | | | help: missing `,` error: expected one of `!`, `(`, `,`, `=`, `>`, `?`, `for`, `~`, lifetime, or path, found `&` --> src/main.rs:3:11 | 3 | fn bar<T: &Trait>(_: T) {} | ^ expected one of 10 possible tokens ``` After: ```text error: expected a trait, found type --> <anon>:2:16 | 2 | fn foo(_: impl &Trait) {} | -^^^^^ | | | help: consider removing the indirection error: expected a trait, found type --> <anon>:3:11 | 3 | fn bar<T: &Trait>(_: T) {} | -^^^^^ | | | help: consider removing the indirection ```
…, r=spastorino Unify `Opaque`/`Projection` handling in region outlives code They share basically identical paths in most places which are even easier to unify now that they're both `ty::Alias` r? types
…rust, r=GuillaumeGomez rustdoc: remove redundant item kind class from `.item-decl > pre` This class originated in the very first commit of `rustdoc_ng`, and was used to add a color border around the item decl based on its kind. https://github.com/rust-lang/rust/blob/4fd061c426902b0904c65e64a3780b21f9ab3afb/src/rustdoc_ng/html/static/main.css#L102-L106 The item decl no longer has a border, and there aren't any kind-specific styles in modern rustdoc's rendering of this UI item. Most of this PR is updating test cases so that they use `item-decl` to find the `<pre>` tag instead of relying on the fact that the class name had `rust {kind}` in it while other `<pre>` tags only had class `rust`.
ConstBlocks are poly if their substs are poly r? `@BoxyUwU` fixesrust-lang#106926
…ackh726 Document `EarlyBinder::subst_identity` and `skip_binder` Finishing implementing rust-lang#105779 will change several commonly used queries to return `EarlyBinder` by default. This PR adds documentation for two of the methods used to access data inside the `EarlyBinder`. I tried to summarize some of the [discussion from the issue](rust-lang#105779 (comment)) in writing this. r? `@lcnr`
Don't add A-bootstrap to PRs modifying Cargo.lock Changing Cargo.lock is common even when adding dependencies between existing rustc crates. cc rust-lang#103204 (comment), `@m-ou-se`
matthiaskrgr
commented
Jan 17, 2023
MemberAuthor
@bors r+ rollup=never p=7 |
bors
commented
Jan 17, 2023
Collaborator
bors
commented
Jan 17, 2023
Collaborator
bors
commented
Jan 17, 2023
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Jan 17, 2023
Collaborator
📌 Perf builds for each rolled up PR: previous master: 4781233a77 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
rust-timer
commented
Jan 17, 2023
Collaborator
Finished benchmarking commit (85357e3): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
impl &Traitnicer #106712 (make error emitted onimpl &Traitnicer)Opaque/Projectionhandling in region outlives code #106829 (UnifyOpaque/Projectionhandling in region outlives code).item-decl > pre#106869 (rustdoc: remove redundant item kind class from.item-decl > pre)EarlyBinder::subst_identityandskip_binder#106953 (DocumentEarlyBinder::subst_identityandskip_binder)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup