Skip to content

compiler: Fix E0587 explanation - #107352

Merged
bors merged 1 commit into
rust-lang:masterfrom
sameo:topic/E0587
Jan 27, 2023
Merged

compiler: Fix E0587 explanation#107352
bors merged 1 commit into
rust-lang:masterfrom
sameo:topic/E0587

Conversation

@sameo

Copy link
Copy Markdown
Contributor

We meant to use 8 as the packed argument.

Signed-off-by: Samuel Ortiz sameo@rivosinc.com

We meant to use 8 as the packed argument.
Signed-off-by: Samuel Ortiz <sameo@rivosinc.com>
@rustbot

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

Please see the contribution instructions for more information.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 27, 2023
@JohnTitor

Copy link
Copy Markdown
Member

Good catch, thanks! @bors r+ rollup

@bors

bors commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 706132d has been approved by JohnTitor

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2023
@JohnTitorJohnTitor mentioned this pull request Jan 27, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 27, 2023
Rollup of 9 pull requests
Successful merges:
- rust-lang#106806 (Replace format flags u32 by enums and bools.)
- rust-lang#107194 (Remove dependency on slice_internals feature in rustc_ast)
- rust-lang#107234 (Revisit fix_is_ci_llvm_available logic)
- rust-lang#107316 (Update snap from `1.0.1` to `1.1.0`)
- rust-lang#107321 (solver comments + remove `TyCtxt::evaluate_goal`)
- rust-lang#107332 (Fix wording from `rustbuild` to `bootstrap`)
- rust-lang#107347 (reduce rightward-drift)
- rust-lang#107352 (compiler: Fix E0587 explanation)
- rust-lang#107357 (Fix infinite loop in rustdoc get_all_import_attributes function)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 85dc93b into rust-lang:masterJan 27, 2023
@rustbotrustbot added this to the 1.69.0 milestone Jan 27, 2023
flip1995 pushed a commit to flip1995/rust that referenced this pull request Feb 10, 2023
Rollup of 9 pull requests
Successful merges:
- rust-lang#106806 (Replace format flags u32 by enums and bools.)
- rust-lang#107194 (Remove dependency on slice_internals feature in rustc_ast)
- rust-lang#107234 (Revisit fix_is_ci_llvm_available logic)
- rust-lang#107316 (Update snap from `1.0.1` to `1.1.0`)
- rust-lang#107321 (solver comments + remove `TyCtxt::evaluate_goal`)
- rust-lang#107332 (Fix wording from `rustbuild` to `bootstrap`)
- rust-lang#107347 (reduce rightward-drift)
- rust-lang#107352 (compiler: Fix E0587 explanation)
- rust-lang#107357 (Fix infinite loop in rustdoc get_all_import_attributes function)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@sameo@rustbot@JohnTitor@bors@estebank