Skip to content

Rollup of 9 pull requests - #107372

Merged
bors merged 21 commits into
rust-lang:masterfrom
JohnTitor:rollup-zkl2ges
Jan 27, 2023
Merged

Rollup of 9 pull requests#107372
bors merged 21 commits into
rust-lang:masterfrom
JohnTitor:rollup-zkl2ges

Conversation

@JohnTitor

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

sugar700and others added 21 commits January 22, 2023 13:05
As spotted by @mejrs, snap 1.0.1 emits a future compatibility warning. This was fixed in BurntSushi/rust-snappy#39
We meant to use 8 as the packed argument.
Signed-off-by: Samuel Ortiz <sameo@rivosinc.com>
Replace format flags u32 by enums and bools.
This gets rid of the `flags: u32` field where each bit has a special meaning, and replaces it by simple enums and booleans.
Part of rust-lang#99012
…ency-in-rustc-ast, r=Nilstrieb
Remove dependency on slice_internals feature in rustc_ast
This reduces dependency on unstable features by the compiler.
…vm_available, r=albertlarsan68
Revisit fix_is_ci_llvm_available logic
Fixesrust-lang#107225
Now `supported_platforms` has a knowledge whether llvm asserts artifacts are available for particular host triple.
``@jyn514`` ``@albertlarsan68`` PTAL
Update snap from `1.0.1` to `1.1.0`
As spotted by `@mejrs,` snap 1.0.1 emits a future compatibility warning. This was fixed in BurntSushi/rust-snappy#39
solver comments + remove `TyCtxt::evaluate_goal`
from the `RustcContributor::explore` session yesterday.
This also removes `TyCtxt::evaluate_goal` because to canonicalize you have to use an `InferCtxt` anyways at which point we should just always get people to use `evaluate_root_goal`.
r? ``@spastorino``
…san68
Fix wording from `rustbuild` to `bootstrap`
Fixesrust-lang#107230
compiler: Fix E0587 explanation
We meant to use 8 as the packed argument.
Signed-off-by: Samuel Ortiz <sameo@rivosinc.com>
…n-rustdoc-get_all_import_attributes, r=notriddle
Fix infinite loop in rustdoc get_all_import_attributes function
Fixesrust-lang#107350.
We'll also need to backport this fix to beta.
r? `@notriddle`
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) rollup A PR which is a rollup labels Jan 27, 2023
@JohnTitor

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=9 rollup=never

@bors

bors commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit c64f4c4 has been approved by JohnTitor

It is now in the queue for this repository.

@borsbors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2023
@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 27, 2023
@bors

bors commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c64f4c4 with merge ef98292...

@bors

bors commented Jan 27, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing ef98292 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 27, 2023
@bors
bors merged commit ef98292 into rust-lang:masterJan 27, 2023
@rustbotrustbot added this to the 1.69.0 milestone Jan 27, 2023
@rust-timer

Copy link
Copy Markdown
Collaborator

@JohnTitor
JohnTitor deleted the rollup-zkl2ges branch January 28, 2023 01:53
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (ef98292): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.2%[0.2%, 0.2%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

flip1995 pushed a commit to flip1995/rust that referenced this pull request Feb 10, 2023
Rollup of 9 pull requests
Successful merges:
- rust-lang#106806 (Replace format flags u32 by enums and bools.)
- rust-lang#107194 (Remove dependency on slice_internals feature in rustc_ast)
- rust-lang#107234 (Revisit fix_is_ci_llvm_available logic)
- rust-lang#107316 (Update snap from `1.0.1` to `1.1.0`)
- rust-lang#107321 (solver comments + remove `TyCtxt::evaluate_goal`)
- rust-lang#107332 (Fix wording from `rustbuild` to `bootstrap`)
- rust-lang#107347 (reduce rightward-drift)
- rust-lang#107352 (compiler: Fix E0587 explanation)
- rust-lang#107357 (Fix infinite loop in rustdoc get_all_import_attributes function)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

13 participants

@JohnTitor@bors@rust-timer@rustbot@sugar700@ChrisDenton@lcnr@chansuke@tshepang@Rattenkrieg@m-ou-se@sameo@GuillaumeGomez