Skip to content

ci: use apt install --download-only for solaris debs - #108951

Merged
bors merged 1 commit into
rust-lang:masterfrom
cuviper:solaris-debs
Mar 10, 2023
Merged

ci: use apt install --download-only for solaris debs#108951
bors merged 1 commit into
rust-lang:masterfrom
cuviper:solaris-debs

Conversation

@cuviper

Copy link
Copy Markdown
Member

No description provided.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @pietroalbini

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 9, 2023
@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+ rollup=never p=150

@bors

bors commented Mar 10, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 258c7e7 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors

bors commented Mar 10, 2023

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2023
@bors

bors commented Mar 10, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 258c7e7 with merge f37f854...

@matthiaskrgr

Copy link
Copy Markdown
Member

@bors treeclosed-

@bors

bors commented Mar 10, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing f37f854 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Mar 10, 2023
@bors
bors merged commit f37f854 into rust-lang:masterMar 10, 2023
@rustbotrustbot added this to the 1.70.0 milestone Mar 10, 2023
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (f37f854): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-0.5%[-0.5%, -0.5%]1
All ❌✅ (primary)--0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-1.6%[-1.9%, -1.3%]2
All ❌✅ (primary)--0

Cycles

This benchmark run did not return any relevant results for this metric.

@cuviper
cuviper deleted the solaris-debs branch March 11, 2023 18:45
@Mark-SimulacrumMark-Simulacrum added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Mar 16, 2023
@Mark-SimulacrumMark-Simulacrum modified the milestones: 1.70.0, 1.68.0, 1.69.0Mar 16, 2023
@NoratriebNoratrieb mentioned this pull request Mar 20, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 20, 2023
…Simulacrum
[stable] 1.68.1 release
This packages up a set of release notes, version bump, and backports of:
* Don't eagerly convert principal to string rust-lang#108162
* Revert "enable ThinLTO for rustc on x86_64-pc-windows-msvc dist builds" rust-lang#109094
* Create dirs for build_triple rust-lang#109111
* Fix linker detection for clang with prefix rust-lang#109156
* ci: use apt install --download-only for solaris debs rust-lang#108951
The last of those is not yet stable-accepted but I expect it to be, we will drop it and rebuild artifacts if we don't actually approve it.
r? `@Mark-Simulacrum`
thirteenowls added a commit to thirteenowls/cross that referenced this pull request May 17, 2024
github-merge-queueBot pushed a commit to cross-rs/cross that referenced this pull request May 17, 2024
Fixes#1424.
Adapted from rust-lang/rust#108951 and
rust-lang/rust#81229 (with some minor changes to
satisfy ShellCheck and account for broken symlinks).
This PR also renames `x86_64-sun-solaris` to `x86_64-pc-solaris`, as the
former was [deprecated](rust-lang/rust#82216) in
Rust 1.52.0 and [removed](rust-lang/rust#118091)
in Rust 1.76.0, making this a breaking change.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcbeta-acceptedAccepted for backporting to the compiler in the beta channel.merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@cuviper@rustbot@Mark-Simulacrum@bors@matthiaskrgr@rust-timer@emilyalbini