Skip to content

Make Solaris builder compatible with Solaris 10 retry - #45343

Merged
bors merged 2 commits into
rust-lang:masterfrom
bgermann:master
Oct 19, 2017
Merged

Make Solaris builder compatible with Solaris 10 retry#45343
bors merged 2 commits into
rust-lang:masterfrom
bgermann:master

Conversation

@bgermann

Copy link
Copy Markdown
Contributor

Unfortunately, #45255 does not quite cut it,
so use a different approach to have Solaris 10 compatibility
by tricking libbacktrace's autoconf tests.
The sysroot download routine is slightly changed, too.

Unfortunately, #45255 does not quite cut it,
so use a different approach to have Solaris 10 compatibility
by tricking libbacktrace's autoconf tests.
The sysroot download routine is slightly changed, too.
@kennytmkennytm added beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 17, 2017
@kennytm

Copy link
Copy Markdown
Member

r? @alexcrichton

(highfive disappeared...)

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Oct 19, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 0597bda has been approved by alexcrichton

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2017
@kennytmkennytm mentioned this pull request Oct 19, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Oct 19, 2017
Make Solaris builder compatible with Solaris 10 retry
Unfortunately, rust-lang#45255 does not quite cut it,
so use a different approach to have Solaris 10 compatibility
by tricking libbacktrace's autoconf tests.
The sysroot download routine is slightly changed, too.
bors added a commit that referenced this pull request Oct 19, 2017
Rollup of 8 pull requests
- Successful merges: #45343, #45349, #45352, #45374, #45375, #45376, #45377, #45382
- Failed merges:
@bors
bors merged commit 0597bda into rust-lang:masterOct 19, 2017
@Mark-SimulacrumMark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 22, 2017
bors added a commit that referenced this pull request Oct 23, 2017
[beta] Make Solaris builder compatible with Solaris 10 retry
Backport of #45343.
@alexcrichtonalexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 23, 2017
bors added a commit that referenced this pull request Oct 24, 2017
[beta] Make Solaris builder compatible with Solaris 10 retry
Backport of #45343.
@w-flo

w-flo commented Mar 9, 2023

Copy link
Copy Markdown

The "apt-cache"-based approach introduced in this PR now seems to download >15k packages in CI: https://github.com/rust-lang-ci/rust/actions/runs/4375805054/jobs/7657029939#step:26:2250

@cuviper

Copy link
Copy Markdown
Member

I've put a new approach in #108951.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@bgermann@kennytm@alexcrichton@bors@w-flo@cuviper@Mark-Simulacrum