Uh oh!
There was an error while loading. Please reload this page.
Assemble Unpin candidates specially for generators in new solver - #110207
Merged
Conversation
rustbot
commented
Apr 11, 2023
Collaborator
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
rust-cloud-vmsBotforce-pushed
the
new-solver-unpin
branch
from
April 11, 2023 21:23
9e9f096 to
a8c2f56Comparelcnr
reviewed
Apr 12, 2023
Uh oh!
There was an error while loading. Please reload this page.
lcnr
reviewed
Apr 12, 2023
Comment on lines
615
to
647
Contributor
There was a problem hiding this comment.
ty::Error and opaque types feel weird here. Error shouldn't matter, but I am worried that this is wrong for opaques 🤔 Also unhappy that we treat opaques as PlaceholderSimplifiedType in simplify_type. Want to think more about this, can you add a fixme here?
apart from that r=me
rust-cloud-vmsBotforce-pushed
the
new-solver-unpin
branch
from
April 13, 2023 20:47
49074c6 to
a1d14deComparecompiler-errors
commented
Apr 13, 2023
ContributorAuthor
Added a FIXME for opaques and moved @bors r=lcnr rollup (only affects new solver) |
bors
commented
Apr 13, 2023
Collaborator
📌 Commit a1d14de220b2a570ef673fb6c39ea68a76225e6f has been approved by It is now in the queue for this repository. |
bors
commented
Apr 13, 2023
Collaborator
☔ The latest upstream changes (presumably #110295) made this pull request unmergeable. Please resolve the merge conflicts. |
rust-cloud-vmsBotforce-pushed
the
new-solver-unpin
branch
from
April 14, 2023 00:05
a1d14de to
3d832a4Comparerust-cloud-vmsBotforce-pushed
the
new-solver-unpin
branch
from
April 14, 2023 03:19
3d832a4 to
319c790Comparecompiler-errors
commented
Apr 14, 2023
ContributorAuthor
Unpin note got changed slightly @bors r=lcnr |
bors
commented
Apr 14, 2023
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 14, 2023
…r=lcnr Assemble `Unpin` candidates specially for generators in new solver Fixescompiler-errors/next-solver-hir-issues#16 r? `@lcnr`
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#109225 (Clarify that RUST_MIN_STACK may be internally cached) - rust-lang#109800 (Improve safe transmute error reporting) - rust-lang#110158 (Remove obsolete test case) - rust-lang#110180 (don't uniquify regions when canonicalizing) - rust-lang#110207 (Assemble `Unpin` candidates specially for generators in new solver) - rust-lang#110276 (Remove all but one of the spans in `BoundRegionKind::BrAnon`) - rust-lang#110279 (rustdoc: Correctly handle built-in compiler proc-macros as proc-macro and not macro) - rust-lang#110298 (Cover edge cases for {f32, f64}.hypot() docs) - rust-lang#110299 (Switch to `EarlyBinder` for `impl_subject` query) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixescompiler-errors/next-solver-hir-issues#16
r? @lcnr