Skip to content

Rollup of 8 pull requests - #110295

Merged
bors merged 22 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-xas29a1
Apr 13, 2023
Merged

Rollup of 8 pull requests#110295
bors merged 22 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-xas29a1

Conversation

@matthiaskrgr

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

chenyukangand others added 22 commits March 12, 2023 07:50
Stick `#[rustc_nounwind]` to all except `const_eval_select` to undo the
change for all other intrinsics.
with repect to other dead code lints
- remove unused (pun intentional) `continue`
- improve wording with assoc items in general
…jyn514
Fix diff option conflict in UI test
Trivial fix for test case `tests/run-make/rustdoc-verify-output-files`,
it's failing on MacOS, the `-u` option specifies the unified context format, while the `-q` option specifies only brief output. These two options are incompatible, since the unified context format produces a more detailed output than the brief output format.
…r=WaffleLapkin
Check for body owner fallibly in error reporting
Sometimes the "body id" we use for an obligation cause is not actually a body owner, like when we're doing WF checking on items.
Fixesrust-lang#110157
…, r=cjgillot
Added diagnostic for pin! macro in addition to Box::pin if Unpin isn't implemented
I made a PR earlier, but accidentally renamed a branch and that deleted the PR... sorry for the duplicate
Currently, if an operation on `Pin<T>` is performed that requires `T` to implement `Unpin`, the diagnostic suggestion is to use `Box::pin` ("note: consider using `Box::pin`").
This PR suggests pin! as well, as that's another valid way of pinning a value, and avoids a heap allocation. Appropriate diagnostic suggestions were included to highlight the difference in semantics (local pinning for pin! vs non-local for Box::pin).
Fixesrust-lang#109964
Automatically update the LLVM submodule for musl target (and other places)
Fixesrust-lang#109987
…r=lcnr
dead-code-lint: de-dup multiple unused assoc functions
Fixesrust-lang#109600
Prior art: rust-lang#97853
…ment, r=bjorn3
Only emit alignment checks if we have a panic_impl
Fixesrust-lang#109996
r? `@bjorn3` because you commented that this situation could impact you as well
… r=oli-obk
Implement `Copy` for `LocationDetail`
micro-nano-little-change
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Apr 13, 2023
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=8

@bors

bors commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 46c6301 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 13, 2023
@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 13, 2023
@bors

bors commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 46c6301 with merge a41fc00...

@bors

bors commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing a41fc00 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Apr 13, 2023
@bors
bors merged commit a41fc00 into rust-lang:masterApr 13, 2023
@rustbotrustbot added this to the 1.70.0 milestone Apr 13, 2023
@rust-timer

Copy link
Copy Markdown
Collaborator

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (a41fc00): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-0.5%[-0.6%, -0.4%]3
All ❌✅ (primary)--0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
1.3%[0.5%, 2.4%]3
Regressions ❌
(secondary)
2.3%[2.3%, 2.3%]1
Improvements ✅
(primary)
-0.1%[-0.1%, -0.1%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)0.9%[-0.1%, 2.4%]4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
0.7%[0.4%, 0.9%]2
Regressions ❌
(secondary)
3.7%[2.1%, 5.8%]5
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)0.7%[0.4%, 0.9%]2

@matthiaskrgr
matthiaskrgr deleted the rollup-xas29a1 branch March 16, 2024 18:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

12 participants

@matthiaskrgr@bors@rust-timer@rustbot@chenyukang@compiler-errors@nbdd0121@ndrewxie@KittyBorgX@Ezrashaw@saethlin@WaffleLapkin