Uh oh!
There was an error while loading. Please reload this page.
fix false positives for unused_parens around unary and binary operations - #110257
Merged
bors merged 2 commits intoApr 17, 2023
Merged
Conversation
rustbot
commented
Apr 12, 2023
Collaborator
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
lukas-code
commented
Apr 12, 2023
ContributorAuthor
wait why does this parse fnwhat(){loop{ifbreak{}}}but not fnwhat(){loop{ifreturn{}}}is this a bug or a feature? |
DaniPopes
commented
Apr 12, 2023
Contributor
I believe that can be answered in rust-quiz #20 😄 |
ContributorAuthor
Yeah, looks like this is a feature, and removing the parens can change behavior, so not linting to remove them is correct. |
lukas-code
commented
Apr 12, 2023
ContributorAuthor
I pushed a second commit to deal with |
lukas-codeforce-pushed
the
why-would-anyone-write-code-like-that-anyway
branch
from
April 13, 2023 16:13
8eb0bc9 to
0d0949dCompareunused_parens around binary operationsunused_parens around unary and binary operationsunused_parens around unary and binary operationsunused_parens around unary and binary operationsoli-obk
commented
Apr 17, 2023
Contributor
@bors r+ rollup |
bors
commented
Apr 17, 2023
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#104055 (Migrate diagnostics in `rustc_borrowck`) - rust-lang#110257 (fix false positives for `unused_parens` around unary and binary operations) - rust-lang#110313 (allow `repr(align = x)` on inherent methods) - rust-lang#110337 (Correct default value for default-linker-libraries) - rust-lang#110386 (Clean up traversal macros) - rust-lang#110394 (Various minor Idx-related tweaks) - rust-lang#110425 (Encode def span for `ConstParam`) - rust-lang#110434 (Check freeze with right param-env in `deduced_param_attrs`) - rust-lang#110455 (tests: adapt for LLVM change 5b386b8) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix#110251