Uh oh!
There was an error while loading. Please reload this page.
allow repr(align = x) on inherent methods - #110313
Merged
Merged
Conversation
rustbot
commented
Apr 14, 2023
Collaborator
(rustbot has picked a reviewer for you, use r? to override) |
| #[no_mangle] | ||
| #[repr(align(16))] | ||
| pub fn method_align(self) {} | ||
| } |
Member
There was a problem hiding this comment.
Can you also add a check for trait methods and associated functions, just to be sure? i.e.
Suggested change
| } | |
| // CHECK: align 16 | |
| #[no_mangle] | |
| #[repr(align(16))] | |
| pubfnassociated_fn(){} | |
| } | |
| traitT{ | |
| fntrait_fn(){} | |
| fntrait_method(self){} | |
| } | |
| implTforA{ | |
| // CHECK: align 16 | |
| #[no_mangle] | |
| #[repr(align(16))] | |
| fntrait_fn(){} | |
| // CHECK: align 16 | |
| #[no_mangle] | |
| #[repr(align(16))] | |
| fntrait_method(self){} | |
| } |
MemberAuthor
There was a problem hiding this comment.
Should those be allowed? The current change doesn't allow those, but I can change it to include trait impls as well.
Member
There was a problem hiding this comment.
I think yes, they should? Don't really see a reason to not allow these (btw maybe a test for default bodies should be added too, although I'm not sure if it's easy to do...).
WaffleLapkin
commented
Apr 14, 2023
Member
WaffleLapkin
approved these changes
Apr 17, 2023
WaffleLapkin
commented
Apr 17, 2023
Member
Do we not have a test which shows the @bors r+ rollup |
bors
commented
Apr 17, 2023
Collaborator
fee1-dead
commented
Apr 17, 2023
MemberAuthor
@WaffleLapkin done. |
WaffleLapkin
commented
Apr 17, 2023
Member
@bors r+ |
bors
commented
Apr 17, 2023
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#104055 (Migrate diagnostics in `rustc_borrowck`) - rust-lang#110257 (fix false positives for `unused_parens` around unary and binary operations) - rust-lang#110313 (allow `repr(align = x)` on inherent methods) - rust-lang#110337 (Correct default value for default-linker-libraries) - rust-lang#110386 (Clean up traversal macros) - rust-lang#110394 (Various minor Idx-related tweaks) - rust-lang#110425 (Encode def span for `ConstParam`) - rust-lang#110434 (Check freeze with right param-env in `deduced_param_attrs`) - rust-lang#110455 (tests: adapt for LLVM change 5b386b8) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion: #82232 (comment)