Uh oh!
There was an error while loading. Please reload this page.
Spelling compiler - #110417
Conversation
rustbot
commented
Apr 16, 2023
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Nilstrieb (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
commented
Apr 16, 2023
This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras Some changes occurred in cc @BoxyUwU Some changes occurred in need_type_info.rs cc @lcnr Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in cc @BoxyUwU Changes rustc_apfloat. rustc_apfloat is currently in limbo and you almost certainly don't want to change it (see #55993). cc @eddyb These commits modify compiler targets. Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
Noratrieb
commented
Apr 16, 2023
I will review this once CI passes. Looks like some functions got renamed but not everywhere. |
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
jsoref
commented
Apr 16, 2023
This |
This comment has been minimized.
This comment has been minimized.
jsoref
commented
Apr 16, 2023
I've hit that ordering thing a couple of times and I thought I fixed it a couple of times. It's taken me a while to understand why it's happening (because I see the beginning word and treat it as if it's the same for both of the first two tokens, but, of course by fixing the spelling of the beginning word) -- the second word now sorts properly instead of jumping the queue because it was sorting against the last letter of the previous word. |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
This struct is dead code, no one mentions it. You shouldn't remove it here, but this is interesting anyways. Looks like something from the diagnostics derive is messing up the dead code lint (cc @davidtwco).
bors
commented
Apr 17, 2023
☔ The latest upstream changes (presumably #110458) made this pull request unmergeable. Please resolve the merge conflicts. |
* account * achieved * advising * always * ambiguous * analysis * annotations * appropriate * build * candidates * cascading * category * character * clarification * compound * conceptually * constituent * consts * convenience * corresponds * debruijn * debug * debugable * debuggable * deterministic * discriminant * display * documentation * doesn't * ellipsis * erroneous * evaluability * evaluate * evaluation * explicitly * fallible * fulfill * getting * has * highlighting * illustrative * imported * incompatible * infringing * initialized * into * intrinsic * introduced * javascript * liveness * metadata * monomorphization * nonexistent * nontrivial * obligation * obligations * offset * opaque * opportunities * opt-in * outlive * overlapping * paragraph * parentheses * poisson * precisely * predecessors * predicates * preexisting * propagated * really * reentrant * referent * responsibility * rustonomicon * shortcircuit * simplifiable * simplifications * specify * stabilized * structurally * suggestibility * translatable * transmuting * two * unclosed * uninhabited * visibility * volatile * workaround Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Noratrieb
commented
Apr 18, 2023
@bors r+ |
bors
commented
Apr 18, 2023
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#110417 (Spelling compiler) - rust-lang#110441 (5 little typos) - rust-lang#110485 (Fix bootstrap locking) - rust-lang#110488 (Add a failing rustdoc-ui test for public infinite recursive type) - rust-lang#110490 (Bump `download-ci-llvm-stamp` for loong support) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This is per #110392 (comment)
I'm going to delay performing a squash because I really don't expect people to be perfectly happy w/ my changes, I really am a human and I really do make mistakes.
r? Nilstrieb
I'm going to be flying this evening, but I should be able to squash / respond to reviews w/in a day or two.
I tried to be careful about dropping changes to
tests, afaict only two files had changes that were likely related to the changes for a given commit (this is where not having eagerly squashed should have given me an advantage), but, that said, picking things apart can be error prone.