Skip to content

Add a failing rustdoc-ui test for public infinite recursive type - #110488

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:test-infinite-recursive-type
Apr 18, 2023
Merged

Add a failing rustdoc-ui test for public infinite recursive type#110488
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:test-infinite-recursive-type

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

As suggested in #110450 (comment).

r? @jyn514

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 18, 2023

@jyn514jyn514 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you ❤️ do you mind also moving tests/rustdoc-ui/infinite-recursive-type-impl-trait.rs to this error-in-impl-trait subdirectory while you're at it?

Comment threadtests/rustdoc-ui/error-in-impl-trait/infinite-recursive-type-2.rs Outdated
@GuillaumeGomez
GuillaumeGomezforce-pushed the test-infinite-recursive-type branch from e878e10 to 4fab87dCompareApril 18, 2023 12:13
@GuillaumeGomez
GuillaumeGomezforce-pushed the test-infinite-recursive-type branch from 4fab87d to ca882c0CompareApril 18, 2023 12:13
@jyn514

Copy link
Copy Markdown
Member

Thank you! r=me with CI passing

@GuillaumeGomez

Copy link
Copy Markdown
MemberAuthor

Didn't even have time to write a message to say it was updated. You're too fast! 😆

@GuillaumeGomez

Copy link
Copy Markdown
MemberAuthor

@bors r=jyn514 rollup

@bors

bors commented Apr 18, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit ca882c0 has been approved by jyn514

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2023
…llaumeGomez
Rollup of 5 pull requests
Successful merges:
- rust-lang#110417 (Spelling compiler)
- rust-lang#110441 (5 little typos)
- rust-lang#110485 (Fix bootstrap locking)
- rust-lang#110488 (Add a failing rustdoc-ui test for public infinite recursive type)
- rust-lang#110490 (Bump `download-ci-llvm-stamp` for loong support)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 7e50336 into rust-lang:masterApr 18, 2023
@rustbotrustbot added this to the 1.71.0 milestone Apr 18, 2023
@GuillaumeGomez
GuillaumeGomez deleted the test-infinite-recursive-type branch April 19, 2023 08:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez@jyn514@bors@rustbot