Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #110666
Merged
Merged
Conversation
Atomic operations require 68020 or later on m68k-linux-gnu.
* There's no need to call `history.replaceState` right before calling `searchState.hideResults`, which already does it. * There's no need to implement hiding search results when that is already implemented.
I noticed that `post_inc_start` and `pre_dec_end` were doing this check in different ways https://github.com/rust-lang/rust/blob/d19b64fb54391b64ce99981577c67c93ac2a9ffa/library/core/src/slice/iter/macros.rs#L76-L93 so started making this PR, then added a few more I found since I was already making changes anyway.
…=jsha rustdoc: migrate `document_type_layout` to askama
…errors Stable hash tag (discriminant) of `GenericArg` This is a continuation of my quest of removing `transmute` if generic args and types (rust-lang#110496, rust-lang#110599). r? `@compiler-errors`
More `IS_ZST` in `library` I noticed that `post_inc_start` and `pre_dec_end` were doing this check in different ways https://github.com/rust-lang/rust/blob/d19b64fb54391b64ce99981577c67c93ac2a9ffa/library/core/src/slice/iter/macros.rs#L76-L93 so started making this PR, then added a few more I found since I was already making changes anyway.
compiler/rustc_target: Raise m68k-linux-gnu baseline to 68020 Atomic operations require 68020 or later on m68k-linux-gnu.
…ctor, r=compiler-errors nit: consistent naming for SimplifyConstCondition Fixing a small naming inconsistency that `@JakobDegen` brought up in rust-lang#110477 (comment). Please signal for rollup.
…30421, r=GuillaumeGomez rustdoc: clean up JS * use `Set` for ignored crates in cross-crate trait impl JS, instead of `indexOf` string manipulation * lift constant `window.location.split` code out of a loop in source code sidebar builder * remove redundant history manipulation from search page exit
…y, r=wesleywiser,BoxyUwU
Print ty placeholders pretty
Makes anon placeholders print like `!0` instead of `Placeholder { ... }`.
```
rustc_trait_selection::solve::compute_well_formed_goal goal=Goal{
predicate: !0,
param_env: ParamEnv{
caller_bounds: [
Binder(TraitPredicate(<!0 as std::marker::Copy>, polarity: Positive), []),
Binder(TraitPredicate(<!0 as std::clone::Clone>, polarity: Positive), []),
Binder(TraitPredicate(<!0 as std::marker::Sized>, polarity: Positive), []),
],
reveal: UserFacing,
constness: NotConst,
}
}
```
cc `@BoxyUwU` who might care about this formatting decisionJohnTitor
commented
Apr 22, 2023
MemberAuthor
@bors r+ p=7 rollup=never |
bors
commented
Apr 22, 2023
Collaborator
bors
commented
Apr 22, 2023
Collaborator
⌛ Testing commit 16e2096 with merge f2febb11a42f72cdc348a02da8e09d6b1945b00e... |
rust-log-analyzer
commented
Apr 22, 2023
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
Apr 22, 2023
Collaborator
💔 Test failed - checks-actions |
JohnTitor
commented
Apr 22, 2023
MemberAuthor
Flaky (like #97435 (comment))? PRs in this don't seem to be related, @bors retry |
bors
commented
Apr 22, 2023
Collaborator
bors
commented
Apr 22, 2023
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Apr 22, 2023
Collaborator
📌 Perf builds for each rolled up PR: previous master: 37b22cf2d5 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Apr 22, 2023
rust-timer
commented
Apr 22, 2023
Collaborator
Finished benchmarking commit (3128fd8): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
document_type_layoutto askama #109949 (rustdoc: migratedocument_type_layoutto askama)GenericArg#110622 (Stable hash tag (discriminant) ofGenericArg)IS_ZSTinlibrary#110635 (MoreIS_ZSTinlibrary)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup