') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); library/std: Bump compiler_builtins by Patryk27 · Pull Request #97435 · rust-lang/rust · GitHub
Skip to content

library/std: Bump compiler_builtins - #97435

Merged
bors merged 1 commit into
rust-lang:masterfrom
Patryk27:bump-compiler-builtins
Jun 1, 2022
Merged

library/std: Bump compiler_builtins#97435
bors merged 1 commit into
rust-lang:masterfrom
Patryk27:bump-compiler-builtins

Conversation

@Patryk27

@Patryk27Patryk27 commented May 26, 2022

Copy link
Copy Markdown
Contributor

Some neat changes include faster float conversions & fixes for AVR 🙂

(note that's it's my first time upgrading compiler_builtins, so I'm not 100% sure if bumping library/std/Cargo.toml is enough; certainly seems to be so, though.)

@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 26, 2022
@rust-highfive

rust-highfive commented May 26, 2022

Copy link
Copy Markdown
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive

rust-highfive commented May 26, 2022

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 26, 2022
@Dylan-DPC

Dylan-DPC commented May 27, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented May 27, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 7005f24 has been approved by Dylan-DPC

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2022
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 28, 2022
@GuillaumeGomez
Rollup merge ofrust-lang#97435- Patryk27:bump-compiler-builtins, r=…
565b4c7
…Dylan-DPC
library/std: Bump compiler_builtins
Some neat changes include faster float conversions & fixes for AVR 🙂
(note that's it's my first time upgrading `compiler_builtins`, so I'm not 100% sure if bumping `library/std/Cargo.toml` is enough; certainly seems to be so, though.)
@GuillaumeGomezGuillaumeGomez mentioned this pull request May 28, 2022
Closed
@bors

bors commented May 29, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7005f24 with merge 23c5bb78d30b07cf0f347f923509d5e69b7562dd...

@bors

bors commented May 29, 2022

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 29, 2022
@rust-log-analyzer

rust-log-analyzer commented May 29, 2022

Copy link
Copy Markdown
Collaborator

The job i686-mingw-2 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)
---- [ui] src/test\ui\runtime\backtrace-debuginfo.rs stdout ----
error: test run failed!
status: exit code: 101
command: PATH="D:\a\rust\rust\build\i686-pc-windows-gnu\stage2\lib\rustlib\i686-pc-windows-gnu\lib;D:\a\rust\rust\build\i686-pc-windows-gnu\stage0-bootstrap-tools\i686-pc-windows-gnu\release\deps;D:\a\rust\rust\build\i686-pc-windows-gnu\stage0\bin;D:\a\rust\rust\ninja;D:\a\rust\rust\mingw32\bin;C:\hostedtoolcache\windows\Python\3.10.4\x64\Scripts;C:\hostedtoolcache\windows\Python\3.10.4\x64;C:\msys64\usr\bin;D:\a\rust\rust\sccache;C:\Program Files\MongoDB\Server\5.0\bin;C:\aliyun-cli;C:\vcpkg;C:\cf-cli;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\2.7.5\x64;C:\cabal\bin;C:\ghcup\bin;C:\tools\ghc-9.2.2\bin;C:\Program Files\dotnet;C:\mysql\bin;C:\Program Files\R\R-4.2.0\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\hostedtoolcache\windows\go\1.17.10\x64\bin;C:\hostedtoolcache\windows\Python\3.7.9\x64\Scripts;C:\hostedtoolcache\windows\Python\3.7.9\x64;C:\hostedtoolcache\windows\Ruby\2.5.9\x64\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.332-9\x64\bin;C:\npm\prefix;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\Program Files\Eclipse Foundation\jdk-8.0.302.8-hotspot\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\ProgramData\Chocolatey\bin;C:\Program Files\Docker;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\dotnet;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\150\DTS\Binn;C:\Program Files\nodejs;C:\Program Files\OpenSSL\bin;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.5\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\SeleniumWebDrivers\ChromeDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\bin;C:\Program Files (x86)\Microsoft BizTalk Server;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\test\\ui\\runtime\\backtrace-debuginfo\\a.exe"
---------------------------------------
trace does not match position list
trace does not match position list
still need to find ["backtrace-debuginfo.rs:183"]
--- stdout
backtrace-debuginfo-aux.rs:6
backtrace-debuginfo.rs:82
backtrace-debuginfo.rs:119
backtrace-debuginfo.rs:119
backtrace-debuginfo.rs:183
--- stderr
test case 2
thread 'main' panicked at 'explicit panic', D:\a\rust\rust\src/test\ui\runtime\backtrace-debuginfo.rs:83:9
stack backtrace:
0: 0x71b94e4e - core::fmt::write::hb3de2e02f973e8b6
1: 0x71b270f4 - std::io::Write::write_fmt::h638a5c919110df2c
2: 0x71b367f1 - std::panicking::default_hook::{{closure}}::h8b9dcaf961af952c
3: 0x71b3652f - std::panicking::default_hook::h85ebe8ff13fbfb91
4: 0x71b36ed0 - std::panicking::rust_panic_with_hook::h75c2ad14e652bd23
5: 0x4036b3 - std::panicking::begin_panic::{{closure}}::hb8bd53031aaff874
at D:\a\rust\rust\library\std\src\panicking.rs:617:9
6: 0x4031b5 - std::sys_common::backtrace::__rust_end_short_backtrace::hca95f158e85e3dd1
at D:\a\rust\rust\library\std\src\sys_common\backtrace.rs:138:18
7: 0x403612 - std::panicking::begin_panic::hb8b67146283bf752
at D:\a\rust\rust\library\std\src\panicking.rs:616:12
8: 0x4171fe - backtrace_debuginfo::inner::{{closure}}::h59122acb3b1f10ce
at D:\a\rust\rust\src/test\ui\runtime\backtrace-debuginfo.rs:83:9
9: 0x416beb - backtrace_debuginfo::aux::callback::hce098a2a42e4d40c
10: 0x416fe0 - backtrace_debuginfo::inner::h68711b0a08793708
at D:\a\rust\rust\src/test\ui\runtime\backtrace-debuginfo.rs:82:29
at D:\a\rust\rust\src/test\ui\runtime\backtrace-debuginfo.rs:82:29
11: 0x4175fe - backtrace_debuginfo::outer::h383486e0a6708dcb
at D:\a\rust\rust\src/test\ui\runtime\backtrace-debuginfo.rs:119:5
12: 0x9af798 - <unknown>
13: 0x405129 - core::ops::function::FnOnce::call_once::h03d8f82ea5ccd7c0
at D:\a\rust\rust\library\core\src\ops\function.rs:248:5
14: 0x4031f1 - std::sys_common::backtrace::__rust_begin_short_backtrace::h17a07543e83addb6
at D:\a\rust\rust\library\std\src\sys_common\backtrace.rs:122:18
15: 0x403273 - std::rt::lang_start::{{closure}}::h4431b2c2d1388e98
at D:\a\rust\rust\library\std\src\rt.rs:145:18
16: 0x71b190f0 - std::rt::lang_start_internal::he2a6984270c0caf1
17: 0x403250 - std::rt::lang_start::h6cebe39b335281f9
at D:\a\rust\rust\library\std\src\rt.rs:144:17
18: 0x418ab3 - _main
19: 0x4013e3 - ___tmainCRTStartup
20: 0x77240419 - <unknown>
21: 0x77c372fd - <unknown>
22: 0x77c372cd - <unknown>
--- stderr -------------------------------
--- stderr -------------------------------
thread 'main' panicked at 'found some errors', D:\a\rust\rust\src/test\ui\runtime\backtrace-debuginfo.rs:173:9
------------------------------------------
failures:
[ui] src/test\ui\runtime\backtrace-debuginfo.rs
test result: FAILED. 13095 passed; 1 failed; 193 ignored; 0 measured; 0 filtered out; finished in 541.61s
Some tests failed in compiletest suite=ui mode=ui host=i686-pc-windows-gnu target=i686-pc-windows-gnu
Build completed unsuccessfully in 0:38:42
make: *** [Makefile:80: ci-mingw-subset-2] Error 1

@Mark-Simulacrum

Mark-Simulacrum commented Jun 1, 2022

Copy link
Copy Markdown
Member

@bors retry rollup=never (perf impact possible though unlikely)

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2022
@bors

bors commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7005f24 with merge 02916c4...

@bors

bors commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 02916c4 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jun 1, 2022
@bors
bors merged commit 02916c4 into rust-lang:masterJun 1, 2022
@rustbotrustbot added this to the 1.63.0 milestone Jun 1, 2022
@rust-highfive

rust-highfive commented Jun 1, 2022

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #97435!

Tested on commit 02916c4.
Direct link to PR: #97435

🎉 rls on linux: test-fail → test-pass (cc @Xanewok).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jun 1, 2022
@rust-highfive
📣 Toolstate changed byrust-lang/rust#97435!
bc5a0bf
Tested on commit rust-lang/rust@02916c4.
Direct link to PR: <rust-lang/rust#97435>
🎉 rls on linux: test-fail → test-pass (cc @Xanewok).
@Patryk27
Patryk27 deleted the bump-compiler-builtins branch June 1, 2022 05:03
@rust-timer

rust-timer commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (02916c4): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: mixed results
mean1maxcount2
Regressions 😿
(primary)		N/AN/A0
Regressions 😿
(secondary)		3.6%4.7%3
Improvements 🎉
(primary)		-2.5%-2.5%1
Improvements 🎉
(secondary)		-2.7%-2.7%1
All 😿🎉 (primary)-2.5%-2.5%1

Cycles

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1maxcount2
Regressions 😿
(primary)		2.9%3.0%2
Regressions 😿
(secondary)		N/AN/A0
Improvements 🎉
(primary)		N/AN/A0
Improvements 🎉
(secondary)		-1.9%-1.9%1
All 😿🎉 (primary)2.9%3.0%2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change↩↩2

  2. number of relevant changes↩↩2

@Patryk27Patryk27 mentioned this pull request Jun 14, 2022
Merged
Rahix pushed a commit to Rahix/avr-hal-template that referenced this pull request Jun 16, 2022
@Patryk27@Rahix
Update toolchain, get rid of the std-features hack
dd810ff
The `compiler-builtins-mangled-names` thingie¹ is no longer needed,
since `compiler_builtins` has been improved to avoid pulling the
problematic functions:
- rust-lang/compiler-builtins#462
- rust-lang/compiler-builtins#466
- rust-lang/rust#97435
¹ rust-lang/rust#82242
Rahix added a commit to Rahix/avr-hal that referenced this pull request Jun 16, 2022
@Rahix
Update toolchain, get rid of the std-features hack
497442d
The `compiler-builtins-mangled-names` thingie¹ is no longer needed,
since `compiler_builtins` has been improved to avoid pulling the
problematic functions:
- rust-lang/compiler-builtins#462
- rust-lang/compiler-builtins#466
- rust-lang/rust#97435
¹ rust-lang/rust#82242
Suggested-by: @Patryk27
Link: Rahix/avr-hal-template#8
@RahixRahix mentioned this pull request Jun 16, 2022
Merged
Rahix added a commit to Rahix/avr-hal that referenced this pull request Jun 16, 2022
@Rahix
Update toolchain, get rid of the std-features hack
adc519f
The `compiler-builtins-mangled-names` thingie¹ is no longer needed,
since `compiler_builtins` has been improved to avoid pulling the
problematic functions:
- rust-lang/compiler-builtins#462
- rust-lang/compiler-builtins#466
- rust-lang/rust#97435
¹ rust-lang/rust#82242
Suggested-by: @Patryk27
Link: Rahix/avr-hal-template#8
Rahix added a commit to Rahix/avr-hal that referenced this pull request Jun 16, 2022
@Rahix
Update toolchain, get rid of the std-features hack
4f8ab25
The `compiler-builtins-mangled-names` thingie¹ is no longer needed,
since `compiler_builtins` has been improved to avoid pulling the
problematic functions:
- rust-lang/compiler-builtins#462
- rust-lang/compiler-builtins#466
- rust-lang/rust#97435
¹ rust-lang/rust#82242
Suggested-by: @Patryk27
Link: Rahix/avr-hal-template#8
@JohnTitorJohnTitor mentioned this pull request Apr 22, 2023
Merged
@ehussehuss mentioned this pull request Oct 23, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

8 participants

@Patryk27@rust-highfive@Dylan-DPC@bors@rust-log-analyzer@Mark-Simulacrum@rust-timer@rustbot