Skip to content

Support RISC-V unaligned-scalar-mem target feature - #110884

Merged
bors merged 1 commit into
rust-lang:masterfrom
korran:unaligned-scalar-mem
May 18, 2023
Merged

Support RISC-V unaligned-scalar-mem target feature#110884
bors merged 1 commit into
rust-lang:masterfrom
korran:unaligned-scalar-mem

Conversation

@korran

@korrankorran commented Apr 27, 2023

Copy link
Copy Markdown
Contributor

This adds unaligned-scalar-mem as an allowed RISC-V target feature. Some RISC-V cores support unaligned access to memory without trapping. On such cores, the compiler could significantly improve code-size and performance when using functions like core::ptr::read_unaligned by emitting a single load or store instruction with an unaligned address, rather than a long sequence of byte load/store/bitmanip instructions.

Enabling the unaligned-scalar-mem target feature allows LLVM to do this optimization.

Fixes#110883

@korran
Support RISC-V unaligned-scalar-mem target feature
08f7e32
This adds `unaligned-scalar-mem` as an allowed RISC-V target feature.
Some RISC-V cores support unaligned access to memory without trapping.
On such cores, the compiler could significantly improve code-size and
performance when using functions like core::ptr::read_unaligned<u32>
by emitting a single load or store instruction with an unaligned
address, rather than a long sequence of byte load/store/bitmanip
instructions.
Enabling the `unaligned-scalar-mem` target feature allows LLVM to do
this optimization.
Fixesrust-lang#110883
@rustbot

rustbot commented Apr 27, 2023

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @b-naber (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 27, 2023
@b-naber

b-naber commented Apr 28, 2023

Copy link
Copy Markdown
Contributor

r? rust-lang/compiler

@rustbotrustbot assigned wesleywiser and unassigned b-naberApr 28, 2023
@wesleywiser

wesleywiser commented May 2, 2023

Copy link
Copy Markdown
Member

Thanks @korran!

@bors r+ rollup

@bors

bors commented May 2, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 08f7e32 has been approved by wesleywiser

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2023
@wesleywiser

wesleywiser commented May 2, 2023

Copy link
Copy Markdown
Member

@bors r-

Just realized target features need T-lang signoff.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 2, 2023
@wesleywiser

wesleywiser commented May 2, 2023

Copy link
Copy Markdown
Member

@rustbot label +I-lang-nominated

This adds unaligned-scalar-mem as an allowed RISC-V target feature. Some RISC-V cores support unaligned access to memory without trapping. On such cores, the compiler could significantly improve code-size and performance when using functions like core::ptr::read_unaligned by emitting a single load or store instruction with an unaligned address, rather than a long sequence of byte load/store/bitmanip instructions.
Enabling the unaligned-scalar-mem target feature allows LLVM to do this optimization.

Nominating for T-lang sign off on adding this target feature.

Thanks!

@rustbotrustbot added the I-lang-nominated Nominated for discussion during a lang team meeting. label May 2, 2023
@nikomatsakis

nikomatsakis commented May 16, 2023

Copy link
Copy Markdown
Contributor

Would this be gated on nightly?

@nikomatsakis

nikomatsakis commented May 16, 2023

Copy link
Copy Markdown
Contributor

Discussed in meeting. If this is gated on nightly, we are fine with adding it, and no FCP is required -- just unnominate.

If it will be insta-stable, we will rediscuss.

@wesleywiser

wesleywiser commented May 17, 2023

Copy link
Copy Markdown
Member

Thanks @nikomatsakis! This is gated on the unstable riscv_target_feature feature.

@bors r+ rollup

@bors

bors commented May 17, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 08f7e32 has been approved by wesleywiser

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 17, 2023
@Dylan-DPCDylan-DPC mentioned this pull request May 18, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2023
@bors
Auto merge ofrust-lang#111710- Dylan-DPC:rollup-eutrx54, r=Dylan-DPC
9052ca9
Rollup of 7 pull requests
Successful merges:
- rust-lang#110884 (Support RISC-V unaligned-scalar-mem target feature)
- rust-lang#111160 (Update serde in workspace and non-synced dependencies)
- rust-lang#111168 (Specialize ToString implementation for fmt::Arguments)
- rust-lang#111527 (add examples of port 0 binding behavior)
- rust-lang#111561 (Include better context for "already exists" error in compiletest)
- rust-lang#111633 (Avoid `&format("...")` calls in error message code.)
- rust-lang#111679 (Remove libs message about ACPs from triagebot)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 677da1c into rust-lang:masterMay 18, 2023
@rustbotrustbot added this to the 1.71.0 milestone May 18, 2023
@sethpsethp mentioned this pull request May 25, 2023
Merged
@apirainoapiraino removed the I-lang-nominated Nominated for discussion during a lang team meeting. label Apr 10, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiserwesleywiserwesleywiser approved these changes

Assignees

@wesleywiserwesleywiser

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.71.0

Development

Successfully merging this pull request may close these issues.

RISC-V LLVM feature +unaligned-scalar-mem not recognized by rustc

7 participants

@korran@rustbot@b-naber@wesleywiser@bors@nikomatsakis@apiraino