Uh oh!
There was an error while loading. Please reload this page.
Update serde in workspace and non-synced dependencies - #111160
Conversation
rustbot
commented
May 3, 2023
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
commented
May 3, 2023
These commits modify the If this was intentional then you can ignore this comment. |
chbaker0
commented
May 3, 2023
Added updates to |
This comment has been minimized.
This comment has been minimized.
chbaker0
commented
May 3, 2023
I really hope those test failures aren't related... BTW we have a lot of duplicate dependencies like this, and I think deduping them would improve build times quite a bit. |
bors
commented
May 7, 2023
☔ The latest upstream changes (presumably #110693) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
The main workspace, bootstrap, cargo, miri, and rust-analyzer all lock serde to different versions. It's preferable to share the same version where possible, so update it. Rustfmt is synced from another repository and has its own Cargo.lock, but since it's added to the overall workspace it should respect the version here. Cargo is already at the latest version. Miri and rust-analyzer would require upstream updates.
chbaker0
commented
May 7, 2023
From local testing, looks like the syn 2.0.8 -> 2.0.15 update breaks some rustc macros |
chbaker0
commented
May 7, 2023
@rustbot -S-waiting-on-author +S-waiting-on-review I think this can be reviewed now |
chbaker0
commented
May 7, 2023
mm @rustbot ready |
| [[package]] | ||
| name = "syn" | ||
| version = "2.0.15" | ||
| version = "2.0.8" |
There was a problem hiding this comment.
Why downgrade? There no rustc-workspace-hack now, so no need to sync versions, plus this is bootstrap-only lock file.
There was a problem hiding this comment.
Yeah, let's try to avoid downgrading where possible. That just means another PR coming along eventually trying to bump this back up :)
There was a problem hiding this comment.
From local testing, looks like the syn 2.0.8 -> 2.0.15 update breaks some rustc macros
Ah, missed this comment. Do we have an issue tracking that yet? It seems like that's probably breakage that needs to be reported upstream to syn?
There was a problem hiding this comment.
This is bootstrap lock, and breakage with version bump in workspace lock, i assume.
Mark-Simulacrum
commented
May 18, 2023
@bors r+ rollup I think we can move ahead with this for now. |
bors
commented
May 18, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#110884 (Support RISC-V unaligned-scalar-mem target feature) - rust-lang#111160 (Update serde in workspace and non-synced dependencies) - rust-lang#111168 (Specialize ToString implementation for fmt::Arguments) - rust-lang#111527 (add examples of port 0 binding behavior) - rust-lang#111561 (Include better context for "already exists" error in compiletest) - rust-lang#111633 (Avoid `&format("...")` calls in error message code.) - rust-lang#111679 (Remove libs message about ACPs from triagebot) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
The main workspace, bootstrap, cargo, miri, and rust-analyzer all lock serde to different versions. It's preferable to share the same version where possible, so update it.
Rustfmt is synced from another repository and has its own Cargo.lock, but since it's added to the overall workspace it should respect the version here.
Cargo is already at the latest version. Miri and rust-analyzer would require upstream updates.