Skip to content

Suggest correct signature on missing fn returning RPITIT/AFIT - #112596

Merged
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:missing-sig-with-rpitit
Jun 20, 2023
Merged

Suggest correct signature on missing fn returning RPITIT/AFIT#112596
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:missing-sig-with-rpitit

Conversation

@compiler-errors

Copy link
Copy Markdown
Contributor

Add async and unpeel the future's output type if the function is async

Fixes#108195

@rustbot

Copy link
Copy Markdown
Collaborator

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 13, 2023
@b-naber

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Jun 19, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit dbee24d has been approved by b-naber

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 20, 2023
…mpiler-errors
Rollup of 8 pull requests
Successful merges:
- rust-lang#112232 (Better error for non const `PartialEq` call generated by `match`)
- rust-lang#112499 (Fix python linting errors)
- rust-lang#112596 (Suggest correct signature on missing fn returning RPITIT/AFIT)
- rust-lang#112606 (Alter `Display` for `Ipv6Addr` for IPv4-compatible addresses)
- rust-lang#112781 (Don't consider TAIT normalizable to hidden ty if it would result in impossible item bounds)
- rust-lang#112787 (Add gha problem matcher)
- rust-lang#112799 (Clean up "doc(hidden)" check)
- rust-lang#112803 (Format the examples directory of cg_clif)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit be68e9e into rust-lang:masterJun 20, 2023
@rustbotrustbot added this to the 1.72.0 milestone Jun 20, 2023
@compiler-errors
compiler-errors deleted the missing-sig-with-rpitit branch August 11, 2023 20:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing trait impl suggestion is not async-aware

4 participants

@compiler-errors@rustbot@b-naber@bors