Skip to content

Clean up "doc(hidden)" check - #112799

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:clean-up-doc-hidden-check
Jun 20, 2023
Merged

Clean up "doc(hidden)" check#112799
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:clean-up-doc-hidden-check

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Jun 19, 2023

Copy link
Copy Markdown
Member

It makes the code reading a bit better by putting away the logic inside a common method.

r? @notriddle

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 19, 2023
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

@notriddle

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Jun 19, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 75e2363 has been approved by notriddle

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 20, 2023
…mpiler-errors
Rollup of 8 pull requests
Successful merges:
- rust-lang#112232 (Better error for non const `PartialEq` call generated by `match`)
- rust-lang#112499 (Fix python linting errors)
- rust-lang#112596 (Suggest correct signature on missing fn returning RPITIT/AFIT)
- rust-lang#112606 (Alter `Display` for `Ipv6Addr` for IPv4-compatible addresses)
- rust-lang#112781 (Don't consider TAIT normalizable to hidden ty if it would result in impossible item bounds)
- rust-lang#112787 (Add gha problem matcher)
- rust-lang#112799 (Clean up "doc(hidden)" check)
- rust-lang#112803 (Format the examples directory of cg_clif)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 22c1971 into rust-lang:masterJun 20, 2023
@rustbotrustbot added this to the 1.72.0 milestone Jun 20, 2023
@GuillaumeGomez
GuillaumeGomez deleted the clean-up-doc-hidden-check branch June 20, 2023 07:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez@rustbot@notriddle@bors