Uh oh!
There was an error while loading. Please reload this page.
Rollup of 3 pull requests - #113293
Merged
Merged
Conversation
…, r=lcnr Implement selection via new trait solver Implements selection via the new solver by calling into `assemble_and_evaluate_candidates`, doing a very light-weight "winnow" to choose one candidate over the others, and then re-confirming that candidate outside of the `EvalCtxt` in order to compute the information necessary for the `ImplSource`. This selection routine is best effort -- if it receives an ambiguous response from the `EvalCtxt`, then it may return ambiguity if the work to re-confirm the goal is not "easy" -- right now, that means everything except for object and impl goals. Since we don't want to reimplement all of the work of the `compute_builtin_*` methods in the solver internals, we bail out if we encounter ambiguity more often than the old solver. This should only barely affect [method selection](https://github.com/rust-lang/rust/blob/f798ada7babac06d4611b0b3a6079d8399ab58ab/compiler/rustc_hir_typeck/src/method/probe.rs#L1447) and not codegen. It can be made more precise later if needed. r? `@lcnr`
…-cfg, r=notriddle [rustdoc] Fix display of long inline cfg labels Fixesrust-lang#87957. Fixesrust-lang#112880. Before:  After:  r? `@notriddle`
…led, r=compiler-errors Don't perform selection if inherent associated types are not enabled Fixesrust-lang#113265. As discussed r? `@compiler-errors`
GuillaumeGomez
commented
Jul 3, 2023
MemberAuthor
@bors r+ rollup=never p=3 |
bors
commented
Jul 3, 2023
Collaborator
bors
commented
Jul 3, 2023
Collaborator
bors
commented
Jul 3, 2023
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Jul 3, 2023
Collaborator
📌 Perf builds for each rolled up PR:
previous master: 3ae0ef79fe In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
rust-timer
commented
Jul 3, 2023
Collaborator
Finished benchmarking commit (8931edf): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 670.578s -> 670.457s (-0.02%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup