rustdoc: align stability badge to baseline instead of bottom by notriddle · Pull Request #105666 · rust-lang/rust

notriddle · 2022-12-13T18:35:40Z

desc	img
before

after

Preview: http://notriddle.com/notriddle-rustdoc-demos/stab-baseline/test_dingus/index.html

Based on comment from #105509 (comment)

r? @joshtriplett

rustbot · 2022-12-13T18:35:47Z

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

Antikyth · 2023-02-13T10:52:10Z

This seems sensible to me. A very minor change in the alignment of the stability badge, single line changing the vertical-align CSS attribute to baseline.

bors · 2023-07-03T19:58:53Z

☔ The latest upstream changes (presumably #113293) made this pull request unmergeable. Please resolve the merge conflicts.

workingjubilee · 2023-07-31T21:47:26Z

Would you rebase this, please?

r? @joshtripplet

workingjubilee · 2023-08-01T00:45:25Z

Thanks!

@bors r+ rollup

bors · 2023-08-01T00:45:27Z

📌 Commit c564f81 has been approved by workingjubilee

It is now in the queue for this repository.

GuillaumeGomez · 2023-08-01T09:03:33Z

Please don't approve other teams code.

@bors r-

workingjubilee · 2023-08-01T09:16:53Z

Hokay!

Normally I avoid doing so, the PR in question merely seemed spectacularly inoffensive (the style doesn't actually have much effect due to other css changes, unfortunately, though I suppose that means the original criteria has effectively still been fulfilled? it seems possibly redundant with the display: inline-flex -> display: inline change) and it had been sitting for... 230 days ish?

r? rustdoc

GuillaumeGomez · 2023-08-01T09:41:35Z

There are two approaches to this problem and it's one of the two PRs for it. But at least you brought it back to our attention so we'll discuss it in the next meeting.

notriddle · 2023-09-04T20:23:52Z

I could come up with a design where the badge isn't as close to the name, so alignment matters less. Would that be a good compromise?

notriddle · 2023-09-04T20:24:36Z

Alternatively, if it looks fine as-is, merge it.

@rfcbot fcp merge

rfcbot · 2023-09-04T20:24:37Z

Team member @notriddle has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2023-10-11T21:35:22Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2023-10-21T21:37:31Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

GuillaumeGomez · 2023-10-22T13:16:51Z

Thanks for the improvement!

@bors r+

bors · 2023-10-22T13:16:53Z

📌 Commit c564f81 has been approved by GuillaumeGomez

It is now in the queue for this repository.

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#105666 (rustdoc: align stability badge to baseline instead of bottom) - rust-lang#117042 (coverage: Emit the filenames section before encoding per-function mappings) - rust-lang#117044 (Miri subtree update) - rust-lang#117049 (add a `csky-unknown-linux-gnuabiv2hf` target ) - rust-lang#117051 (fix broken link: update incremental compilation url) - rust-lang#117069 (x.ps1: remove the check for Python from Windows Store) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#105666 - notriddle:notriddle/stab-baseline, r=GuillaumeGomez rustdoc: align stability badge to baseline instead of bottom | desc | img | |------|-----| | before | ![image](https://user-images.githubusercontent.com/1593513/207412598-3a6468ca-a169-4810-a689-4797688385df.png) | | | | | after | ![image](https://user-images.githubusercontent.com/1593513/207412720-b120269a-48a3-40e9-a9b0-6769bb05e104.png) | Preview: http://notriddle.com/notriddle-rustdoc-demos/stab-baseline/test_dingus/index.html Based on comment from rust-lang#105509 (comment) r? ``@joshtriplett``

rustbot assigned joshtriplett Dec 13, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 13, 2022

anden3 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2023

workingjubilee assigned workingjubilee and unassigned joshtriplett Jul 31, 2023

workingjubilee added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2023

rustdoc: align stability badge to baseline instead of bottom
c564f81
r? @joshtripplet

notriddle force-pushed the notriddle/stab-baseline branch from d486513 to c564f81Compare July 31, 2023 22:07

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 1, 2023

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 1, 2023

rustbot assigned jsha and unassigned workingjubilee Aug 1, 2023

rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Sep 4, 2023

rfcbot added the disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. label Sep 4, 2023

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Oct 11, 2023

Dylan-DPC added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 12, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2023

matthiaskrgr mentioned this pull request Oct 23, 2023
Rollup of 6 pull requests #117071
Merged

bors merged commit e86f9b6 into rust-lang:masterOct 23, 2023

rustbot added this to the 1.75.0 milestone Oct 23, 2023

notriddle deleted the notriddle/stab-baseline branch October 23, 2023 13:47

github-actionsBot mentioned this pull request Oct 31, 2023
Automated pull from upstream masterferrocene/ferrocene#74
Merged

apiraino removed the to-announce Announce this issue on triage meeting label Nov 9, 2023

Uh oh!

Uh oh!

Conversation

notriddle commented Dec 13, 2022

Uh oh!

rustbot commented Dec 13, 2022

Uh oh!

Antikyth commented Feb 13, 2023

Uh oh!

bors commented Jul 3, 2023

Uh oh!

workingjubilee commented Jul 31, 2023

Uh oh!

workingjubilee commented Aug 1, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Aug 1, 2023

Uh oh!

GuillaumeGomez commented Aug 1, 2023

Uh oh!

workingjubilee commented Aug 1, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuillaumeGomez commented Aug 1, 2023

Uh oh!

notriddle commented Sep 4, 2023

Uh oh!

notriddle commented Sep 4, 2023

Uh oh!

rfcbot commented Sep 4, 2023• edited by GuillaumeGomez Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfcbot commented Oct 11, 2023

Uh oh!

rfcbot commented Oct 21, 2023

Uh oh!

GuillaumeGomez commented Oct 22, 2023

Uh oh!

bors commented Oct 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

workingjubilee commented Aug 1, 2023•
edited
Loading

workingjubilee commented Aug 1, 2023•
edited
Loading

rfcbot commented Sep 4, 2023•
edited by GuillaumeGomez
Loading