Skip to content

Feature gate #[simd] - #11738

Merged
bors merged 1 commit into
rust-lang:masterfrom
dmanescu:11721
Jan 28, 2014
Merged

Feature gate #[simd]#11738
bors merged 1 commit into
rust-lang:masterfrom
dmanescu:11721

Conversation

@dmanescu

@dmanescudmanescu commented Jan 23, 2014

Copy link
Copy Markdown
Contributor

Fixes#11721

alexcrichton
alexcrichton reviewed Jan 23, 2014
View reviewed changes
Comment threadsrc/test/compile-fail/gated-simd.rs Outdated

@alexcrichtonalexcrichtonJan 23, 2014

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you run this test past make check yet? I think that the feature gating happens at a much earlier phase than the stability lint checking levels. You may just need to split this into two tests.

@alexcrichton

alexcrichton commented Jan 23, 2014

Copy link
Copy Markdown
Member

This looks great, thanks!

@brson

brson commented Jan 23, 2014

Copy link
Copy Markdown
Contributor

Will this actually prevent people from using simd? Doesn't this just make std declare that it's implementing the simd types without preventing people from using them?

@thestinger

thestinger commented Jan 23, 2014

Copy link
Copy Markdown
Contributor

@brson: we could mark those as #[experimental]

@huonw

huonw commented Jan 23, 2014

Copy link
Copy Markdown
Contributor

They are marked experimental by this PR.

@brson

brson commented Jan 23, 2014

Copy link
Copy Markdown
Contributor

Sounds good.

@huonw

huonw commented Jan 23, 2014

Copy link
Copy Markdown
Contributor

Unfortunately it looks like we don't handle cross-crate tuple structs correctly, so this currently doesn't stop people using std::unstable::simd, but when #11741 is fixed it will.

bors added a commit that referenced this pull request Jan 28, 2014
@bors
auto merge of#11738: dmanescu/rust/11721, r=alexcrichton
1ac9bf6
Fixes#11721
@borsbors closed this Jan 28, 2014
@bors
bors merged commit 28b987b into rust-lang:masterJan 28, 2014
@dmanescudmanescu mentioned this pull request Jan 30, 2014
Merged
bors added a commit that referenced this pull request Feb 1, 2014
@bors
auto merge of#11932: dmanescu/rust/11741-stability-cross-crate, r=a…
362cbbe
…lexcrichton
Fixes#11741
Added tests and removed xfail-fast from run-pass/simd-experimental which is now fixed (see #11738).
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 18, 2024
@franciscoBSalgueiro
Fixrust-lang#11738: allowcastlints in macros
ac225a3
Removed the `from_expansion` guard clause for cast lints, so that these warnings can be generated for internal macros.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 18, 2024
@bors
Auto merge ofrust-lang#12631- franciscoBSalgueiro:11738, r=blyxyas
08dac85
Allow `cast` lints in macros
closes: rust-lang#11738
Removed the `from_expansion` guard clause for cast lints, so that these warnings can be generated for internal macros.
changelog: allow `cast` lints in macros
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RFC: feature gate #[simd] & mark the simd types in std #[experimental]

6 participants

@dmanescu@alexcrichton@brson@thestinger@huonw@bors