Handle attributes on cross-crate tuple-structs correctly - #11932
Conversation
There was a problem hiding this comment.
I believe so - how do I fix it?
There was a problem hiding this comment.
(Nevermind - git reset to the rescue!)
|
Nice catch! And while #11741 isn't officially on the 1.0 milestone it probably should be! This is a great bugfix for the real usage of stability attributes in the future. |
There was a problem hiding this comment.
Could you add a comment here explaining why it's calling this function? It seems odd in a get_item function it's calling something which is expecting a tuple_struct_def
There was a problem hiding this comment.
Maybe we could call it get_tuple_struct_def_if_ctor(..) to (attempt to) indicate that it only gets the def if it's actually a tuple struct constructor.
There was a problem hiding this comment.
I'd be down with that. Comments are still welcome too :)
There was a problem hiding this comment.
Of course (I didn't mean to imply that there shouldn't be a comment).
|
Just a minor comment for future readers, otherwise r=me (feel free to comment when updated) |
|
The test failures aren't your fault, I'm trying to fix mac-64 and I'll retry this when I think I have a fix. |
- `T: ~const Drop` has a special meaning in Rust 1.61 that we don't implement. (So ideally, we'd only ignore `~const Drop`, but this should be fine for now.) - `Destruct` impls are built-in in 1.62 (current nightlies as of 08-04-2022), so until the builtin impls are supported by Chalk, we ignore them as well. Since `Destruct` is implemented for everything in non-const contexts IIUC, this should also work fine. Fixes rust-lang#11932.
11936: Ignore `Drop` and `Destruct` bounds for now r=flodiebold a=flodiebold - `T: ~const Drop` has a special meaning in Rust 1.61 that we don't implement. (So ideally, we'd only ignore `~const Drop`, but this should be fine for now.) - `Destruct` impls are built-in in 1.62 (current nightlies), so until the builtin impls are supported by Chalk, we ignore them as well. Since `Destruct` is implemented for everything in non-const contexts IIUC, this should also work fine. Fixes rust-lang#11932. Co-authored-by: Florian Diebold <flodiebold@gmail.com>
Fixes #11741
Added tests and removed xfail-fast from run-pass/simd-experimental which is now fixed (see #11738).