Skip to content

Update mingw-w64 + GNU toolchain - #119229

Merged
bors merged 1 commit into
rust-lang:masterfrom
mati865:update-mingw-toolchain
Sep 9, 2024
Merged

Update mingw-w64 + GNU toolchain#119229
bors merged 1 commit into
rust-lang:masterfrom
mati865:update-mingw-toolchain

Conversation

@mati865

@mati865mati865 commented Dec 22, 2023

Copy link
Copy Markdown
Member

The list of packaged tools and their versions is available at: https://github.com/niXman/mingw-builds-binaries/releases/tag/14.1.0-rt_v12-rev0

Fixes: #112368

@rustbot

Copy link
Copy Markdown
Collaborator

r? @Kobzol

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 22, 2023
@mati865

Copy link
Copy Markdown
MemberAuthor

Can I get @bors try please?

@petrochenkov

Copy link
Copy Markdown
Contributor

@bors try

@bors

bors commented Dec 22, 2023

Copy link
Copy Markdown
Collaborator

⌛ Trying commit a9d4088 with merge 498e29e...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 22, 2023
Update mingw-w64 + GNU toolchain
Let's see if it works.
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors

This comment was marked as resolved.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 22, 2023
@mati865

Copy link
Copy Markdown
MemberAuthor

Should be good for another go, added redirection follow argument, the download will hopefully work now.
Dunno if zstd is present, so enabled it's stdout just in case.

@ChrisDenton

Copy link
Copy Markdown
Member

@bors try

@bors

bors commented Dec 23, 2023

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 3660130 with merge d400ea1...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 23, 2023
Update mingw-w64 + GNU toolchain
Let's see if it works.
@rust-log-analyzer

This comment has been minimized.

@bors

This comment was marked as resolved.

@mati865

Copy link
Copy Markdown
MemberAuthor

Crosstool creates even more messed up toolchain structure than I though, let's see with this release.

@mati865

Copy link
Copy Markdown
MemberAuthor

Manged to build and run tests locally with x86_64 after few more fixes but stdlib's mspc tests fail in a weird way so let's see the CI.

@mati865

Copy link
Copy Markdown
MemberAuthor

Could somebody run try build out delegate me?

@Kobzol

Copy link
Copy Markdown
Member

@bors try

@bors

bors commented Jan 2, 2024

Copy link
Copy Markdown
Collaborator

⌛ Trying commit bd2de7d with merge f4588bf...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 2, 2024
Update mingw-w64 + GNU toolchain
Let's see if it works.
@rust-log-analyzer

This comment has been minimized.

@bors

This comment was marked as resolved.

@mati865

Copy link
Copy Markdown
MemberAuthor

Dunno how it didn't manifest locally, can we try again with a new version?

@Kobzol

Copy link
Copy Markdown
Member

@bors try

@bors

bors commented Sep 4, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 4ee58db has been approved by jieyouxu,petrochenkov

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2024
tgross35 added a commit to tgross35/rust that referenced this pull request Sep 5, 2024
…jieyouxu,petrochenkov
Update mingw-w64 + GNU toolchain
The list of packaged tools and their versions is available at: https://github.com/niXman/mingw-builds-binaries/releases/tag/14.1.0-rt_v12-rev0Fixes: rust-lang#112368
@tgross35tgross35 mentioned this pull request Sep 5, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 6, 2024
…jieyouxu,petrochenkov
Update mingw-w64 + GNU toolchain
The list of packaged tools and their versions is available at: https://github.com/niXman/mingw-builds-binaries/releases/tag/14.1.0-rt_v12-rev0Fixes: rust-lang#112368
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 6, 2024
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#119229 (Update mingw-w64 + GNU toolchain)
- rust-lang#128871 (bypass linker configuration and cross target check for specific commands)
- rust-lang#128939 (Distribute rustc_codegen_cranelift for Windows)
- rust-lang#129529 (Add test to build crates used by r-a on stable)
- rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`)
- rust-lang#129835 (enable const-float-classify test, and test_next_up/down on 32bit x86)
- rust-lang#130009 (rustdoc-search: allow trailing `Foo ->` arg search)
r? `@ghost`
`@rustbot` modify labels: rollup
@GuillaumeGomez

Copy link
Copy Markdown
Member

I wonder if this the one which failed in #130027...

@ChrisDenton

Copy link
Copy Markdown
Member

That would seem very unlikely considering it's msvc that failed.

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 9, 2024
…jieyouxu,petrochenkov
Update mingw-w64 + GNU toolchain
The list of packaged tools and their versions is available at: https://github.com/niXman/mingw-builds-binaries/releases/tag/14.1.0-rt_v12-rev0Fixes: rust-lang#112368
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 9, 2024
…jieyouxu,petrochenkov
Update mingw-w64 + GNU toolchain
The list of packaged tools and their versions is available at: https://github.com/niXman/mingw-builds-binaries/releases/tag/14.1.0-rt_v12-rev0Fixes: rust-lang#112368
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2024
…kingjubilee
Rollup of 16 pull requests
Successful merges:
- rust-lang#119229 (Update mingw-w64 + GNU toolchain)
- rust-lang#128345 (added support for GNU/Hurd on x86_64)
- rust-lang#128667 (rustdoc: normalise type/field names)
- rust-lang#128939 (Distribute rustc_codegen_cranelift for Windows)
- rust-lang#129529 (Add test to build crates used by r-a on stable)
- rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`)
- rust-lang#129876 (Use sysroot crates maximally in `rustc_codegen_gcc`.)
- rust-lang#130034 ( Fix enabling wasm-component-ld to match other tools )
- rust-lang#130048 (run-make-support: Add llvm-pdbutil)
- rust-lang#130068 (Test codegen when setting deployment target)
- rust-lang#130070 (Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`)
- rust-lang#130087 (remove 'const' from 'Option::iter')
- rust-lang#130090 (make Result::copied unstably const)
- rust-lang#130092 (Fixes typo in wasm32-wasip2 doc comment)
- rust-lang#130107 (const: make ptr.is_null() stop execution on ambiguity)
- rust-lang#130115 (Remove needless returns detected by clippy in libraries)
r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee

Copy link
Copy Markdown
Member

It's not about you, it's about Windows.

@bors rollup=iffy

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2024
…kingjubilee
Rollup of 14 pull requests
Successful merges:
- rust-lang#119229 (Update mingw-w64 + GNU toolchain)
- rust-lang#128345 (added support for GNU/Hurd on x86_64)
- rust-lang#128667 (rustdoc: normalise type/field names)
- rust-lang#129876 (Use sysroot crates maximally in `rustc_codegen_gcc`.)
- rust-lang#130034 ( Fix enabling wasm-component-ld to match other tools )
- rust-lang#130048 (run-make-support: Add llvm-pdbutil)
- rust-lang#130068 (Test codegen when setting deployment target)
- rust-lang#130070 (Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`)
- rust-lang#130087 (remove 'const' from 'Option::iter')
- rust-lang#130090 (make Result::copied unstably const)
- rust-lang#130092 (Fixes typo in wasm32-wasip2 doc comment)
- rust-lang#130107 (const: make ptr.is_null() stop execution on ambiguity)
- rust-lang#130115 (Remove needless returns detected by clippy in libraries)
- rust-lang#130130 (Miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 1ea466b into rust-lang:masterSep 9, 2024
@rustbotrustbot added this to the 1.83.0 milestone Sep 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2024
Rollup merge of rust-lang#119229 - mati865:update-mingw-toolchain, r=jieyouxu,petrochenkov
Update mingw-w64 + GNU toolchain
The list of packaged tools and their versions is available at: https://github.com/niXman/mingw-builds-binaries/releases/tag/14.1.0-rt_v12-rev0Fixes: rust-lang#112368
@mati865
mati865 deleted the update-mingw-toolchain branch September 28, 2024 09:05
rust-borsBot pushed a commit that referenced this pull request Nov 7, 2025
The comment here was a bit misleading, #13846 was about an LLVM assertion
that failed when `-Zfunction-sections` was enabled. However, that bug
has been fixed for a long time and the actual issue was that older `ld`
versions would not correctly link binaries (see #75604 for the prior
attempt at this change). This bug was fixed in version 2.32 of binutils
and Rust now ships binutils 2.42 as of #119229 so we can remove this
workaround!
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GNU linker warns “corrupt .drectve” on staticlib binary generated with Rust 1.70 on Windows

13 participants

@mati865@rustbot@petrochenkov@bors@rust-log-analyzer@ChrisDenton@Kobzol@Dylan-DPC@jyn514@jieyouxu@matthiaskrgr@GuillaumeGomez@workingjubilee