Add test to build crates used by r-a on stable by lqd · Pull Request #129529 · rust-lang/rust

lqd · 2024-08-24T21:27:07Z

I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.

rustbot · 2024-08-24T21:27:10Z

Could not assign reviewer from: Kobzol.
User(s) Kobzol are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

lqd · 2024-08-25T11:04:40Z

I've also removed the cargo nightly feature / RUSTC_BOOTSTRAP

…n stable

otherwise the test would build in the source root's `target` folder

it'll be easier to see and update the list: the other cmd args can just be ignored

lqd · 2024-08-27T17:52:19Z

All the prerequisite PRs have landed.

rustbot · 2024-08-27T17:52:22Z

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

The run-make-support library was changed

cc @jieyouxu

Kobzol

Left a few nits, otherwise LGTM. Thank you for pushing this through!

Kobzol · 2024-09-02T09:23:42Z

Thanks! You can r=me once CI is green.

Kobzol · 2024-09-02T12:35:52Z

@bors r+

bors · 2024-09-02T12:35:55Z

📌 Commit a178559 has been approved by Kobzol

It is now in the queue for this repository.

Rollup of 8 pull requests Successful merges: - rust-lang#101339 (enable -Zrandomize-layout in debug CI builds ) - rust-lang#127021 (Add target support for RTEMS Arm) - rust-lang#128871 (bypass linker configuration and cross target check for specific commands) - rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance) - rust-lang#129529 (Add test to build crates used by r-a on stable) - rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`) - rust-lang#129796 (Unify scraped examples with other code examples) - rust-lang#129939 (explain why Rvalue::Len still exists) r? `@ghost` `@rustbot` modify labels: rollup

Add test to build crates used by r-a on stable r? `@Kobzol` I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#129529 (Add test to build crates used by r-a on stable) - rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`) - rust-lang#129720 (Simplify DestProp memory management) - rust-lang#129796 (Unify scraped examples with other code examples) - rust-lang#129891 (Do not request sanitizers for naked functions) - rust-lang#129938 (Elaborate on deriving vs implementing `Copy`) Failed merges: - rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance) r? `@ghost` `@rustbot` modify labels: rollup

Add test to build crates used by r-a on stable r? ``@Kobzol`` I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.

…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#119229 (Update mingw-w64 + GNU toolchain) - rust-lang#128871 (bypass linker configuration and cross target check for specific commands) - rust-lang#128939 (Distribute rustc_codegen_cranelift for Windows) - rust-lang#129529 (Add test to build crates used by r-a on stable) - rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`) - rust-lang#129835 (enable const-float-classify test, and test_next_up/down on 32bit x86) - rust-lang#130009 (rustdoc-search: allow trailing `Foo ->` arg search) r? `@ghost` `@rustbot` modify labels: rollup

Add test to build crates used by r-a on stable r? ```@Kobzol``` I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#129337 (rustdoc rfc#3662 changes under unstable flags) - rust-lang#129473 (use `download-ci-llvm=true` in the default compiler config) - rust-lang#129529 (Add test to build crates used by r-a on stable) - rust-lang#130025 (Also emit `missing_docs` lint with `--test` to fulfil expectations) - rust-lang#130070 (Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`) - rust-lang#130087 (remove 'const' from 'Option::iter') - rust-lang#130092 (Fixes typo in wasm32-wasip2 doc comment) r? `@ghost` `@rustbot` modify labels: rollup

Add test to build crates used by r-a on stable r? ````@Kobzol```` I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#129473 (use `download-ci-llvm=true` in the default compiler config) - rust-lang#129529 (Add test to build crates used by r-a on stable) - rust-lang#130025 (Also emit `missing_docs` lint with `--test` to fulfil expectations) - rust-lang#130048 (run-make-support: Add llvm-pdbutil) - rust-lang#130070 (Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`) - rust-lang#130087 (remove 'const' from 'Option::iter') - rust-lang#130092 (Fixes typo in wasm32-wasip2 doc comment) r? `@ghost` `@rustbot` modify labels: rollup

Add test to build crates used by r-a on stable r? `````@Kobzol````` I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.

Add test to build crates used by r-a on stable r? ``````@Kobzol`````` I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.

…kingjubilee Rollup of 16 pull requests Successful merges: - rust-lang#119229 (Update mingw-w64 + GNU toolchain) - rust-lang#128345 (added support for GNU/Hurd on x86_64) - rust-lang#128667 (rustdoc: normalise type/field names) - rust-lang#128939 (Distribute rustc_codegen_cranelift for Windows) - rust-lang#129529 (Add test to build crates used by r-a on stable) - rust-lang#129624 (Adjust `memchr` pinning and run `cargo update`) - rust-lang#129876 (Use sysroot crates maximally in `rustc_codegen_gcc`.) - rust-lang#130034 ( Fix enabling wasm-component-ld to match other tools ) - rust-lang#130048 (run-make-support: Add llvm-pdbutil) - rust-lang#130068 (Test codegen when setting deployment target) - rust-lang#130070 (Rename variant `AddrOfRegion` of `RegionVariableOrigin` to `BorrowRegion`) - rust-lang#130087 (remove 'const' from 'Option::iter') - rust-lang#130090 (make Result::copied unstably const) - rust-lang#130092 (Fixes typo in wasm32-wasip2 doc comment) - rust-lang#130107 (const: make ptr.is_null() stop execution on ambiguity) - rust-lang#130115 (Remove needless returns detected by clippy in libraries) r? `@ghost` `@rustbot` modify labels: rollup

Add test to build crates used by r-a on stable r? ```````@Kobzol``````` I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.

…kingjubilee Rollup of 14 pull requests Successful merges: - rust-lang#128316 (Stabilize most of `io_error_more`) - rust-lang#129473 (use `download-ci-llvm=true` in the default compiler config) - rust-lang#129529 (Add test to build crates used by r-a on stable) - rust-lang#129778 (interpret: make typed copies lossy wrt provenance and padding) - rust-lang#129981 (Remove `serialized_bitcode` from `LtoModuleCodegen`.) - rust-lang#130025 (Also emit `missing_docs` lint with `--test` to fulfil expectations) - rust-lang#130040 (unify `llvm-bitcode-linker`, `wasm-component-ld` and llvm-tools logics) - rust-lang#130094 (Inform the solver if evaluation is concurrent) - rust-lang#130132 ([illumos] enable SIGSEGV handler to detect stack overflows) - rust-lang#130146 (bootstrap `naked_asm!` for `compiler-builtins`) - rust-lang#130149 (Helper function for formatting with `LifetimeSuggestionPosition`) - rust-lang#130152 (adapt a test for llvm 20) - rust-lang#130162 (bump download-ci-llvm-stamp) - rust-lang#130164 (move some const fn out of the const_ptr_as_ref feature) r? `@ghost` `@rustbot` modify labels: rollup

…kingjubilee Rollup of 11 pull requests Successful merges: - rust-lang#128316 (Stabilize most of `io_error_more`) - rust-lang#129473 (use `download-ci-llvm=true` in the default compiler config) - rust-lang#129529 (Add test to build crates used by r-a on stable) - rust-lang#129981 (Remove `serialized_bitcode` from `LtoModuleCodegen`.) - rust-lang#130094 (Inform the solver if evaluation is concurrent) - rust-lang#130132 ([illumos] enable SIGSEGV handler to detect stack overflows) - rust-lang#130146 (bootstrap `naked_asm!` for `compiler-builtins`) - rust-lang#130149 (Helper function for formatting with `LifetimeSuggestionPosition`) - rust-lang#130152 (adapt a test for llvm 20) - rust-lang#130162 (bump download-ci-llvm-stamp) - rust-lang#130164 (move some const fn out of the const_ptr_as_ref feature) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#129529 - lqd:stable-new-solver, r=Kobzol Add test to build crates used by r-a on stable r? ````````@Kobzol```````` I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.

Veykril · 2024-10-22T06:27:48Z

A very late thanks for this test btw :)

rustbot assigned jieyouxu Aug 24, 2024

This comment was marked as outdated.
Sign in to view

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 24, 2024

lqd assigned Kobzol and unassigned jieyouxu Aug 24, 2024

lqd force-pushed the stable-new-solver branch from 49b5c1f to a7dbf4cCompare August 25, 2024 11:00

lqd commented Aug 25, 2024
View reviewed changes

Comment threadtests/run-make/rustc-crates-on-stable/rmake.rs Outdated

lqd force-pushed the stable-new-solver branch from a7dbf4c to 71ab5efCompare August 25, 2024 22:41

lqd mentioned this pull request Aug 25, 2024
Use FxHasher on new solver unconditionally #129526
Merged

lqd force-pushed the stable-new-solver branch from 71ab5ef to 0b7eba2Compare August 25, 2024 23:10

Kobzoland others added 6 commits August 26, 2024 09:52

Add a run-make test for checking that certain rustc_ crates build o…
893413d
…n stable

inhibit proc-macro2 nightly detection
7957140

run test in tmp dir and emit artifacts there
d9794a9
otherwise the test would build in the source root's `target` folder

remove use of RUSTC_BOOTSTRAP and cargo nightly features
2190c28

separate the crates to test from the test setup
0577035
it'll be easier to see and update the list: the other cmd args can just be ignored

remove unneeded type ascription
f1df0c5

lqd force-pushed the stable-new-solver branch from 0b7eba2 to f1df0c5Compare August 26, 2024 09:57

lqd commented Aug 27, 2024
View reviewed changes

Comment threadtests/run-make/rustc-crates-on-stable/rmake.rs Outdated

lqd marked this pull request as ready for review August 27, 2024 17:52

Kobzol reviewed Sep 2, 2024
View reviewed changes

address review comments
a178559

matthiaskrgr mentioned this pull request Sep 5, 2024
Rollup of 6 pull requests #129985
Closed

GuillaumeGomez mentioned this pull request Sep 6, 2024
Rollup of 7 pull requests #130027
Closed

matthiaskrgr mentioned this pull request Sep 8, 2024
Rollup of 7 pull requests #130100
Closed

matthiaskrgr mentioned this pull request Sep 8, 2024
Rollup of 7 pull requests #130109
Closed

workingjubilee mentioned this pull request Sep 9, 2024
Rollup of 19 pull requests #130127
Closed

workingjubilee mentioned this pull request Sep 9, 2024
Rollup of 16 pull requests #130129
Closed

workingjubilee mentioned this pull request Sep 10, 2024
Rollup of 14 pull requests #130177
Closed

workingjubilee mentioned this pull request Sep 10, 2024
Rollup of 11 pull requests #130179
Merged

bors merged commit a4c6104 into rust-lang:masterSep 10, 2024

rustbot added this to the 1.83.0 milestone Sep 10, 2024

lqd deleted the stable-new-solver branch September 10, 2024 10:42

Uh oh!

Uh oh!

Conversation

lqd commented Aug 24, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 24, 2024

Uh oh!

This comment was marked as outdated.

lqd commented Aug 25, 2024

Uh oh!

Uh oh!

Uh oh!

lqd commented Aug 27, 2024

Uh oh!

rustbot commented Aug 27, 2024

Uh oh!

Kobzol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kobzol commented Sep 2, 2024

Uh oh!

Kobzol commented Sep 2, 2024

Uh oh!

bors commented Sep 2, 2024

Uh oh!

Veykril commented Oct 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lqd commented Aug 24, 2024•
edited
Loading