Skip to content

Couple of random coroutine pass simplifications - #119322

Merged
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:async-gen-resume-ty
Dec 30, 2023
Merged

Couple of random coroutine pass simplifications#119322
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:async-gen-resume-ty

Conversation

@compiler-errors

Copy link
Copy Markdown
Contributor

Just aesthetic changes, except for a random Ty::new_task_context(tcx) call that was redundant.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 26, 2023
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

} else {
body.local_decls[resume_local].ty
};
let resume_ty = body.local_decls[resume_local].ty;

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The call to transform_async_context above ensures that body.local_decls[resume_local].ty == Ty::new_task_context(tcx)

@bors

bors commented Dec 28, 2023

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #119174) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Dec 29, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit d71f7be has been approved by cjgillot

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 30, 2023
…iaskrgr
Rollup of 5 pull requests
Successful merges:
- rust-lang#119322 (Couple of random coroutine pass simplifications)
- rust-lang#119374 (Italicise "bytes" in the docs of some `Vec` methods)
- rust-lang#119388 (rustc_lint: Prevent triplication of various lints)
- rust-lang#119406 (Add non-regression test for ATPIT ICE rust-lang#114325)
- rust-lang#119410 (Rename test to be more descriptive)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit b75ba15 into rust-lang:masterDec 30, 2023
@rustbotrustbot added this to the 1.77.0 milestone Dec 30, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 30, 2023
Rollup merge of rust-lang#119322 - compiler-errors:async-gen-resume-ty, r=cjgillot
Couple of random coroutine pass simplifications
Just aesthetic changes, except for a random `Ty::new_task_context(tcx)` call that was redundant.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@compiler-errors@rustbot@bors@cjgillot