Rollup of 5 pull requests by matthiaskrgr · Pull Request #119421 · rust-lang/rust

matthiaskrgr · 2023-12-29T20:40:25Z

Successful merges:

Couple of random coroutine pass simplifications #119322 (Couple of random coroutine pass simplifications)
Italicise "bytes" in the docs of some Vec methods #119374 (Italicise "bytes" in the docs of some Vec methods)
rustc_lint: Prevent triplication of various lints #119388 (rustc_lint: Prevent triplication of various lints)
Add non-regression test for ATPIT ICE #114325 #119406 (Add non-regression test for ATPIT ICE ICE unexpected unsized tail: std::alloc::Global #114325)
Rename test to be more descriptive #119410 (Rename test to be more descriptive)

r? @ghost
@rustbot modify labels: rollup

So we can apply more kinds of lints to added lints without having to add another parameter.

Prevent multiple 'ignored unless specified at crate level' lints. The multiplication happens because we run the same lint three times: * In BuiltinCombinedEarlyLintPass * In BuiltinCombinedPreExpansionLintPass * In shallow_lint_levels_on Only run the lint one time by checking the `lint_added_lints` bool.

because on a cursory read it's easy to miss that the limit is in terms of bytes not no. of elements. The italics should help with that.

…y, r=cjgillot Couple of random coroutine pass simplifications Just aesthetic changes, except for a random `Ty::new_task_context(tcx)` call that was redundant.

…uviper Italicise "bytes" in the docs of some `Vec` methods On a cursory read it's easy to miss that the limit is in terms of bytes not no. of elements. The italics should help with that. Fixesrust-lang#119149

… r=cjgillot rustc_lint: Prevent triplication of various lints Prevent triplication of various lints. The triplication happens because we run the same lint three times (or less in some cases): * In `BuiltinCombinedPreExpansionLintPass` * In `BuiltinCombinedEarlyLintPass` * In `shallow_lint_levels_on()` Only run the lints one time by checking the `lint_added_lints` bool. Set your GitHub diff setting to ignore whitespaces changes when reviewing this PR, since I had to enclose a block inside an if. Closesrust-lang#73301 (I found this while exploring the code related to [this](rust-lang#119251 (comment)) comment.)

Add non-regression test for ATPIT ICE rust-lang#114325 ATPIT issue rust-lang#114325 had been unknowingly fixed by rust-lang#107421, so this PR adds its [MCVE](rust-lang#114325 (comment)) as a non-regression test. Closesrust-lang#114325.

…rieb Rename test to be more descriptive As suggested in rust-lang#119402 (comment) r? ``@Nilstrieb``

matthiaskrgr · 2023-12-29T20:40:55Z

@bors r+ rollup=never p=5

bors · 2023-12-29T20:40:57Z

📌 Commit bfc1643 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-12-30T01:44:44Z

⌛ Testing commit bfc1643 with merge 03b5019...

bors · 2023-12-30T03:44:50Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 03b5019 to master...

rust-timer · 2023-12-30T03:46:16Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#119322	Couple of random coroutine pass simplifications	`38e416886d042755becc8bea67abddc12cba9f19` (link)
#119374	Italicise "bytes" in the docs of some `Vec` methods	`f0b25d5cf3e73f4a66758f2b9cc8a3df3dfa9571` (link)
#119388	rustc_lint: Prevent triplication of various lints	`a243ef5274311b38fdd7a7add25b72d78dc18028` (link)
#119406	Add non-regression test for ATPIT ICE #114325	`0f2a1b736b42c5cf317364308c9ec1b999572280` (link)
#119410	Rename test to be more descriptive	`6b1dcea4e98ea421bc43645f15babfd4f7ba0a9f` (link)

previous master: 3cdd004e55

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-12-30T05:04:50Z

Finished benchmarking commit (03b5019): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.7%	[-3.4%, -2.1%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.7%	[-3.4%, -2.1%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.4%, 0.4%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.886s -> 670.291s (-0.24%)
Artifact size: 312.01 MiB -> 312.00 MiB (-0.00%)

Enselicand others added 14 commits December 28, 2023 19:46

rustc_error_codes: Update expected error in E0453.md
a4bcd47

rustc_lint: Rename warn_about_weird_lints to lint_added_lints
eef02c4
So we can apply more kinds of lints to added lints without having to add another parameter.

rustc_lint: Prevent multiple 'incompatible with previous forbid' lints
741884d

rustc_lint: Prevent triplication of 'unknown lint' lint
7ca4e9f

Couple of random coroutine pass simplifications
d71f7be

Italicise "bytes" in the docs of some Vec methods
e3aca01
because on a cursory read it's easy to miss that the limit is in terms of bytes not no. of elements. The italics should help with that.

add non-regression test for issue 114325
21e8710

Rename test
740378c

Rollup merge ofrust-lang#119322- compiler-errors:async-gen-resume-t…
b75ba15
…y, r=cjgillot Couple of random coroutine pass simplifications Just aesthetic changes, except for a random `Ty::new_task_context(tcx)` call that was redundant.

Rollup merge ofrust-lang#119374- gurry:119149-improve-vec-docs, r=c…
ef55e75
…uviper Italicise "bytes" in the docs of some `Vec` methods On a cursory read it's easy to miss that the limit is in terms of bytes not no. of elements. The italics should help with that. Fixesrust-lang#119149

Rollup merge ofrust-lang#119410- est31:fix_if_guard_unused, r=Nilst…
bfc1643
…rieb Rename test to be more descriptive As suggested in rust-lang#119402 (comment) r? ``@Nilstrieb``

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 30, 2023

bors merged commit 03b5019 into rust-lang:masterDec 30, 2023

rustbot added this to the 1.77.0 milestone Dec 30, 2023

This was referenced Dec 30, 2023
Suggest Upgrading Compiler for Gated Features #119088
Merged
rustc_lint: Enforce rustc::potential_query_instability lint #119251
Merged

matthiaskrgr deleted the rollup-dbera1b branch March 16, 2024 18:19

Navigation Menu

Uh oh!

Uh oh!

Rollup of 5 pull requests - #119421

Rollup of 5 pull requests#119421
bors merged 14 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-dbera1b

matthiaskrgr commented Dec 29, 2023

Uh oh!

matthiaskrgr commented Dec 29, 2023

Uh oh!

bors commented Dec 29, 2023

Uh oh!

bors commented Dec 30, 2023

Uh oh!

bors commented Dec 30, 2023

Uh oh!

rust-timer commented Dec 30, 2023

Uh oh!

rust-timer commented Dec 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Uh oh!

Conversation

matthiaskrgr commented Dec 29, 2023

Uh oh!

matthiaskrgr commented Dec 29, 2023

Uh oh!

bors commented Dec 29, 2023

Uh oh!

bors commented Dec 30, 2023

Uh oh!

bors commented Dec 30, 2023

Uh oh!

rust-timer commented Dec 30, 2023

Uh oh!

rust-timer commented Dec 30, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants