Bump some deps with syn 1.0 dependencies by clubby789 · Pull Request #120201 · rust-lang/rust

clubby789 · 2024-01-21T17:21:47Z

cargo updateing unic-langid and object removes two dependencies on Syn 1.0.

rustbot · 2024-01-21T17:21:54Z

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2024-01-21T17:21:57Z

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

dtolnay

Thank you!

dtolnay · 2024-01-22T02:47:49Z

@bors r+

bors · 2024-01-22T02:47:51Z

📌 Commit b50b333 has been approved by dtolnay

It is now in the queue for this repository.

Bump some deps with syn 1.0 dependencies cc rust-lang#109302 `cargo update`ing `unic-langid` and `object` removes two dependencies on Syn 1.0.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#119433 (rc,sync: Do not create references to uninitialized values) - rust-lang#119460 (coverage: Never emit improperly-ordered coverage regions) - rust-lang#119766 (Split tait and impl trait in assoc items logic) - rust-lang#120160 (Manually implement derived `NonZero` traits.) - rust-lang#120177 (Remove duplicate dependencies for rustc) - rust-lang#120183 (Add `#[coverage(off)]` to closures introduced by `#[test]` and `#[bench]`) - rust-lang#120185 (coverage: Don't instrument `#[automatically_derived]` functions) - rust-lang#120201 (Bump some deps with syn 1.0 dependencies) - rust-lang#120246 (Re-add estebank to review rotation) r? `@ghost` `@rustbot` modify labels: rollup

Bump some deps with syn 1.0 dependencies cc rust-lang#109302 `cargo update`ing `unic-langid` and `object` removes two dependencies on Syn 1.0.

Rollup of 13 pull requests Successful merges: - rust-lang#119028 (Add more weirdness to weird-exprs.rs) - rust-lang#119805 (Suggest array::from_fn for array initialization) - rust-lang#120124 (Split assembly tests for ELF and MachO) - rust-lang#120177 (Remove duplicate dependencies for rustc) - rust-lang#120185 (coverage: Don't instrument `#[automatically_derived]` functions) - rust-lang#120188 (compiler: update freebsd and netbsd base specs.) - rust-lang#120201 (Bump some deps with syn 1.0 dependencies) - rust-lang#120215 (Update some deps with `bitflags` v1 dependencies) - rust-lang#120244 (Use `Self` in `NonZero*` implementations.) - rust-lang#120246 (Re-add estebank to review rotation) - rust-lang#120252 (rename `RawTy` to `LoweredTy`) - rust-lang#120255 (correct my mailmap entry) - rust-lang#120270 (A bunch of random modifications) r? `@ghost` `@rustbot` modify labels: rollup

fmease · 2024-01-23T20:27:45Z

#120249 (comment)
#120271 (comment)

@bors rollup=iffy

fmease · 2024-01-23T20:44:55Z

Do you think that updating object from 0.32.1 to 0.32.2 (changelog) might cause https://github.com/rust-lang/rust/blob/master/tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs, revision thin0, to fail or is that utter nonsense?

clubby789 · 2024-01-23T21:07:07Z

Unsure. The linker warnings I think are just #112368 and not relevant, but the errors reference memchr, which was updated in the other PR.

fmease · 2024-01-23T21:15:39Z

Ah, good catch, that makes sense! Thanks for linking #112368 I wasn't aware of that.

fmease · 2024-01-23T21:26:28Z

@bors rollup=maybe

Bump some deps with syn 1.0 dependencies cc rust-lang#109302 `cargo update`ing `unic-langid` and `object` removes two dependencies on Syn 1.0.

Rollup of 8 pull requests Successful merges: - rust-lang#119305 (Add `AsyncFn` family of traits) - rust-lang#119389 (Provide more context on recursive `impl` evaluation overflow) - rust-lang#120062 (llvm: change data layout bug to an error and make it trigger more) - rust-lang#120099 (linker: Refactor library linking methods in `trait Linker`) - rust-lang#120201 (Bump some deps with syn 1.0 dependencies) - rust-lang#120230 (Assert that a single scope is passed to `for_scope`) - rust-lang#120278 (Remove --fatal-warnings on wasm targets) - rust-lang#120292 (coverage: Dismantle `Instrumentor` and flatten span refinement) r? `@ghost` `@rustbot` modify labels: rollup

Bump some deps with syn 1.0 dependencies cc rust-lang#109302 `cargo update`ing `unic-langid` and `object` removes two dependencies on Syn 1.0.

…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#118803 (Add the `min_exhaustive_patterns` feature gate) - rust-lang#119286 (show linker output even if the linker succeeds) - rust-lang#119616 (Add a new `wasm32-wasi-preview2` target) - rust-lang#120124 (Split assembly tests for ELF and MachO) - rust-lang#120201 (Bump some deps with syn 1.0 dependencies) - rust-lang#120204 (Builtin macros effectively have implicit #[collapse_debuginfo(yes)]) - rust-lang#120322 (Don't manually resolve async closures in `rustc_resolve`) - rust-lang#120356 (Fix broken markdown in csky-unknown-linux-gnuabiv2.md) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-01-27T14:19:15Z

⌛ Testing commit b50b333 with merge 6b4f1c5...

bors · 2024-01-27T16:15:51Z

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 6b4f1c5 to master...

rust-timer · 2024-01-27T17:34:02Z

Finished benchmarking commit (6b4f1c5): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.6%	[4.6%, 4.6%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.4%	[-2.4%, -2.4%]	1
Improvements ✅ (secondary)	-3.6%	[-4.6%, -2.9%]	3
All ❌✅ (primary)	1.1%	[-2.4%, 4.6%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	1
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-0.7%	[-0.7%, -0.7%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 662.371s -> 659.977s (-0.36%)
Artifact size: 308.10 MiB -> 308.14 MiB (0.01%)

clubby789 added 2 commits January 21, 2024 17:19

Bump object version
56bc552

Bump uniq-langid version
b50b333

rustbot assigned Mark-Simulacrum Jan 21, 2024

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 21, 2024

dtolnay assigned dtolnay and unassigned Mark-Simulacrum Jan 22, 2024

dtolnay approved these changes Jan 22, 2024
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2024

matthiaskrgr mentioned this pull request Jan 22, 2024
Rollup of 9 pull requests #120249
Closed

fmease mentioned this pull request Jan 23, 2024
Rollup of 13 pull requests #120271
Closed

fmease mentioned this pull request Jan 23, 2024
Remove duplicate dependencies for rustc #120177
Closed

fmease mentioned this pull request Jan 24, 2024
Rollup of 8 pull requests #120304
Closed

compiler-errors mentioned this pull request Jan 26, 2024
Rollup of 8 pull requests #120359
Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 27, 2024

bors merged commit 6b4f1c5 into rust-lang:masterJan 27, 2024

rustbot added this to the 1.77.0 milestone Jan 27, 2024

Uh oh!

Uh oh!

Conversation

clubby789 commented Jan 21, 2024

Uh oh!

rustbot commented Jan 21, 2024

Uh oh!

rustbot commented Jan 21, 2024

Uh oh!

dtolnay left a comment

Choose a reason for hiding this comment

Uh oh!

dtolnay commented Jan 22, 2024

Uh oh!

bors commented Jan 22, 2024

Uh oh!

fmease commented Jan 23, 2024

Uh oh!

fmease commented Jan 23, 2024

Uh oh!

clubby789 commented Jan 23, 2024

Uh oh!

fmease commented Jan 23, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fmease commented Jan 23, 2024

Uh oh!

bors commented Jan 27, 2024

Uh oh!

bors commented Jan 27, 2024

Uh oh!

rust-timer commented Jan 27, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

fmease commented Jan 23, 2024•
edited
Loading