Skip to content

[cleanup] [llvm backend] Prevent creating the same Instance::mono multiple times - #124178

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:llvm-backend
Apr 23, 2024
Merged

[cleanup] [llvm backend] Prevent creating the same Instance::mono multiple times#124178
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:llvm-backend

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

Just a little thing I came across while going through the code.

r? @oli-obk

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 19, 2024
@oli-obk

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Apr 22, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit d34be93 has been approved by oli-obk

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 22, 2024
…-obk
[cleanup] [llvm backend] Prevent creating the same `Instance::mono` multiple times
Just a little thing I came across while going through the code.
r? `@oli-obk`
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2024
…llaumeGomez
Rollup of 5 pull requests
Successful merges:
- rust-lang#104087 (Stabilise inline_const)
- rust-lang#123792 (Require explicitly marking closures as coroutines)
- rust-lang#124057 (Fix ICE when ADT tail has type error)
- rust-lang#124178 ([cleanup] [llvm backend] Prevent creating the same `Instance::mono` multiple times)
- rust-lang#124220 (Miri: detect wrong vtables in wide pointers)
r? `@ghost`
`@rustbot` modify labels: rollup
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 22, 2024
…-obk
[cleanup] [llvm backend] Prevent creating the same `Instance::mono` multiple times
Just a little thing I came across while going through the code.
r? ``@oli-obk``
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2024
…llaumeGomez
Rollup of 5 pull requests
Successful merges:
- rust-lang#124178 ([cleanup] [llvm backend] Prevent creating the same `Instance::mono` multiple times)
- rust-lang#124183 (Stop taking `ParamTy`/`ParamConst`/`EarlyParamRegion`/`AliasTy` by ref)
- rust-lang#124217 (coverage: Prepare for improved branch coverage)
- rust-lang#124220 (Miri: detect wrong vtables in wide pointers)
- rust-lang#124252 (Improve ICE message for forbidden dep-graph reads.)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2024
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#115913 (checked_ilog: improve performance)
- rust-lang#124178 ([cleanup] [llvm backend] Prevent creating the same `Instance::mono` multiple times)
- rust-lang#124183 (Stop taking `ParamTy`/`ParamConst`/`EarlyParamRegion`/`AliasTy` by ref)
- rust-lang#124217 (coverage: Prepare for improved branch coverage)
- rust-lang#124230 (Stabilize generic `NonZero`.)
- rust-lang#124252 (Improve ICE message for forbidden dep-graph reads.)
- rust-lang#124268 (Update books)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 23, 2024
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#115913 (checked_ilog: improve performance)
- rust-lang#124178 ([cleanup] [llvm backend] Prevent creating the same `Instance::mono` multiple times)
- rust-lang#124183 (Stop taking `ParamTy`/`ParamConst`/`EarlyParamRegion`/`AliasTy` by ref)
- rust-lang#124217 (coverage: Prepare for improved branch coverage)
- rust-lang#124230 (Stabilize generic `NonZero`.)
- rust-lang#124252 (Improve ICE message for forbidden dep-graph reads.)
- rust-lang#124268 (Update books)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 1a12ec4 into rust-lang:masterApr 23, 2024
@rustbotrustbot added this to the 1.79.0 milestone Apr 23, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 23, 2024
Rollup merge of rust-lang#124178 - GuillaumeGomez:llvm-backend, r=oli-obk
[cleanup] [llvm backend] Prevent creating the same `Instance::mono` multiple times
Just a little thing I came across while going through the code.
r? ```@oli-obk```
@GuillaumeGomez
GuillaumeGomez deleted the llvm-backend branch April 23, 2024 09:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez@oli-obk@bors@rustbot