Skip to content

Stop taking ParamTy/ParamConst/EarlyParamRegion/AliasTy by ref - #124183

Merged
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:unnecessary-by-ref
Apr 23, 2024
Merged

Stop taking ParamTy/ParamConst/EarlyParamRegion/AliasTy by ref#124183
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:unnecessary-by-ref

Conversation

@compiler-errors

@compiler-errorscompiler-errors commented Apr 20, 2024

Copy link
Copy Markdown
Contributor

It's unnecessary and is annoying when we have it by value.

@compiler-errors

compiler-errors commented Apr 20, 2024

Copy link
Copy Markdown
ContributorAuthor

@bors try @rust-timer queue

@rustbot

rustbot commented Apr 20, 2024

Copy link
Copy Markdown
Collaborator

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-timer

This comment has been minimized.

Sign in to view
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Apr 20, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 20, 2024
@bors
Auto merge ofrust-lang#124183- compiler-errors:unnecessary-by-ref, …
43c2ad0
…r=<try>
Stop taking `ParamTy`/`ParamConst`/`EarlyParamRegion`/`AliasTy` by ref
It's unnecessary and is annoying when we have it by value.
@bors

bors commented Apr 20, 2024

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 86756c1 with merge 43c2ad0...

@bors

bors commented Apr 20, 2024

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 43c2ad0 (43c2ad003f74abb9e68c2dc11dae84633acbdd02)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Apr 20, 2024

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (43c2ad0): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		2.3%[2.3%, 2.3%]1
Regressions ❌
(secondary)		3.0%[3.0%, 3.1%]2
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)2.3%[2.3%, 2.3%]1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-2.7%[-2.7%, -2.7%]1
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.274s -> 672.599s (0.20%)
Artifact size: 315.25 MiB -> 315.26 MiB (0.00%)

@rustbotrustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 20, 2024
@oli-obk

oli-obk commented Apr 22, 2024

Copy link
Copy Markdown
Contributor

r? @oli-obk

@bors r+

@bors

bors commented Apr 22, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 86756c1 has been approved by oli-obk

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2024
@oli-obk

oli-obk commented Apr 22, 2024

Copy link
Copy Markdown
Contributor

@bors rollup

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 22, 2024
@GuillaumeGomez
Rollup merge ofrust-lang#124183- compiler-errors:unnecessary-by-ref…
2a7ec56
…, r=oli-obk
Stop taking `ParamTy`/`ParamConst`/`EarlyParamRegion`/`AliasTy` by ref
It's unnecessary and is annoying when we have it by value.
@GuillaumeGomezGuillaumeGomez mentioned this pull request Apr 22, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2024
@bors
Auto merge ofrust-lang#124264- GuillaumeGomez:rollup-l0i1t6q, r=Gui…
a7c8f57
…llaumeGomez
Rollup of 5 pull requests
Successful merges:
- rust-lang#124178 ([cleanup] [llvm backend] Prevent creating the same `Instance::mono` multiple times)
- rust-lang#124183 (Stop taking `ParamTy`/`ParamConst`/`EarlyParamRegion`/`AliasTy` by ref)
- rust-lang#124217 (coverage: Prepare for improved branch coverage)
- rust-lang#124220 (Miri: detect wrong vtables in wide pointers)
- rust-lang#124252 (Improve ICE message for forbidden dep-graph reads.)
r? `@ghost`
`@rustbot` modify labels: rollup
@GuillaumeGomezGuillaumeGomez mentioned this pull request Apr 22, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2024
@bors
Auto merge ofrust-lang#124271- GuillaumeGomez:rollup-7st9wd7, r=Gui…
9a158d3
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#115913 (checked_ilog: improve performance)
- rust-lang#124178 ([cleanup] [llvm backend] Prevent creating the same `Instance::mono` multiple times)
- rust-lang#124183 (Stop taking `ParamTy`/`ParamConst`/`EarlyParamRegion`/`AliasTy` by ref)
- rust-lang#124217 (coverage: Prepare for improved branch coverage)
- rust-lang#124230 (Stabilize generic `NonZero`.)
- rust-lang#124252 (Improve ICE message for forbidden dep-graph reads.)
- rust-lang#124268 (Update books)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 23, 2024
@bors
Auto merge ofrust-lang#124271- GuillaumeGomez:rollup-7st9wd7, r=Gui…
9cf10bc
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#115913 (checked_ilog: improve performance)
- rust-lang#124178 ([cleanup] [llvm backend] Prevent creating the same `Instance::mono` multiple times)
- rust-lang#124183 (Stop taking `ParamTy`/`ParamConst`/`EarlyParamRegion`/`AliasTy` by ref)
- rust-lang#124217 (coverage: Prepare for improved branch coverage)
- rust-lang#124230 (Stabilize generic `NonZero`.)
- rust-lang#124252 (Improve ICE message for forbidden dep-graph reads.)
- rust-lang#124268 (Update books)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit e984447 into rust-lang:masterApr 23, 2024
@rustbotrustbot added this to the 1.79.0 milestone Apr 23, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 23, 2024
@rust-timer
Unrolled build forrust-lang#124183
8993baf
Rollup merge of rust-lang#124183 - compiler-errors:unnecessary-by-ref, r=oli-obk
Stop taking `ParamTy`/`ParamConst`/`EarlyParamRegion`/`AliasTy` by ref
It's unnecessary and is annoying when we have it by value.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obkoli-obk

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

6 participants

@compiler-errors@rustbot@rust-timer@bors@oli-obk@wesleywiser