Directly add extension instead of using `Path::with_extension` by tbu- · Pull Request #125406 · rust-lang/rust

tbu- · 2024-05-22T13:20:52Z

Path::with_extension has a nice footgun when the original path doesn't contain an extension: Anything after the last dot gets removed.

rustbot · 2024-05-22T13:21:00Z

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Nadrieril · 2024-05-22T17:43:28Z

Good spot!

@bors r+ rollup

bors · 2024-05-22T17:43:31Z

📌 Commit 87b77a2 has been approved by Nadrieril

It is now in the queue for this repository.

…Nadrieril Directly add extension instead of using `Path::with_extension` `Path::with_extension` has a nice footgun when the original path doesn't contain an extension: Anything after the last dot gets removed.

Rollup of 7 pull requests Successful merges: - rust-lang#122665 (Add some tests for public-private dependencies.) - rust-lang#125210 (Cleanup: Fix up some diagnostics) - rust-lang#125316 (Tweak `Spacing` use) - rust-lang#125401 (Migrate `run-make/rustdoc-scrape-examples-macros` to `rmake.rs`) - rust-lang#125406 (Directly add extension instead of using `Path::with_extension`) - rust-lang#125409 (Rename `FrameworkOnlyWindows` to `RawDylibOnlyWindows`) - rust-lang#125416 (Use correct param-env in `MissingCopyImplementations`) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2024-05-23T05:40:15Z

@bors rollup=iffy

bors · 2024-05-23T09:25:31Z

⌛ Testing commit 87b77a2 with merge bba736a...

…drieril Directly add extension instead of using `Path::with_extension` `Path::with_extension` has a nice footgun when the original path doesn't contain an extension: Anything after the last dot gets removed.

bors · 2024-05-23T10:22:11Z

💔 Test failed - checks-actions

tbu- · 2024-05-24T09:50:34Z

Anything after the last dot gets removed.

Interesting. This was apparently already hit by the existing code, because the added suffix just got dropped entirely. ^^

Nadrieril · 2024-05-24T13:01:02Z

Do you think that might have been intentional?

tbu- · 2024-05-24T15:07:44Z

Do you think that might have been intentional?

I don't think so. There's no point in adding a suffix that is immediately removed again. The name_suffix was purely dead code.

Nadrieril · 2024-05-29T21:27:29Z

Alright, let's try again

@bors r+

bors · 2024-05-29T21:27:32Z

📌 Commit 0a3ecea has been approved by Nadrieril

It is now in the queue for this repository.

bors · 2024-05-29T22:28:08Z

⌛ Testing commit 0a3ecea with merge f839e1d...

…drieril Directly add extension instead of using `Path::with_extension` `Path::with_extension` has a nice footgun when the original path doesn't contain an extension: Anything after the last dot gets removed.

bors · 2024-05-29T22:33:07Z

💔 Test failed - checks-actions

fmease · 2024-05-30T05:43:48Z

sync @bors r-

Nadrieril · 2024-06-01T18:54:47Z

The test failure is due to formatting, I'm surprised that tidy didn't catch it. Anyway, please run rustfmt and we should be good

`Path::with_extension` has a nice footgun when the original path doesn't contain an extension: Anything after the last dot gets removed.

tbu- · 2024-06-04T20:13:05Z

Autoformatted.

@rustbot ready

Nadrieril · 2024-06-05T17:14:14Z

@bors r+

bors · 2024-06-05T17:14:17Z

📌 Commit f7c51a2 has been approved by Nadrieril

It is now in the queue for this repository.

bors · 2024-06-06T10:24:28Z

⌛ Testing commit f7c51a2 with merge 67caf52...

bors · 2024-06-06T12:50:58Z

☀️ Test successful - checks-actions
Approved by: Nadrieril
Pushing 67caf52 to master...

rust-timer · 2024-06-06T14:07:05Z

Finished benchmarking commit (67caf52): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.6%, secondary 4.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.6%	[3.6%, 3.6%]	1
Regressions ❌ (secondary)	4.4%	[4.4%, 4.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.6%	[3.6%, 3.6%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.761s -> 670.655s (-0.31%)
Artifact size: 319.40 MiB -> 319.39 MiB (-0.00%)

rustbot assigned Nadrieril May 22, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 22, 2024

This comment has been minimized.
Sign in to view

tbu-force-pushed the pr_rm_path_with_extension branch from 70d39cd to 87b77a2Compare May 22, 2024 13:30

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2024

fmease mentioned this pull request May 22, 2024
Rollup of 7 pull requests #125424
Closed

fmease mentioned this pull request May 22, 2024
Rollup of 7 pull requests #125425
Closed

This comment has been minimized.
Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 23, 2024

tbu-force-pushed the pr_rm_path_with_extension branch from 87b77a2 to 0a3eceaCompare May 24, 2024 09:49

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 29, 2024

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 29, 2024

This comment has been minimized.
Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 29, 2024

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2024

Directly add extension instead of using Path::with_extension
f7c51a2
`Path::with_extension` has a nice footgun when the original path doesn't contain an extension: Anything after the last dot gets removed.

tbu-force-pushed the pr_rm_path_with_extension branch from 0a3ecea to f7c51a2Compare June 4, 2024 20:12

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 4, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 6, 2024

bors merged commit 67caf52 into rust-lang:masterJun 6, 2024

rustbot added this to the 1.80.0 milestone Jun 6, 2024

cyrgani mentioned this pull request Jul 27, 2025
ICE: Panic when using constant from associated type trait impl #144547
Closed

Uh oh!

Uh oh!

Conversation

tbu- commented May 22, 2024

Uh oh!

rustbot commented May 22, 2024

Uh oh!

This comment has been minimized.

Nadrieril commented May 22, 2024

Uh oh!

bors commented May 22, 2024

Uh oh!

matthiaskrgr commented May 23, 2024

Uh oh!

bors commented May 23, 2024

Uh oh!

This comment has been minimized.

bors commented May 23, 2024

Uh oh!

tbu- commented May 24, 2024

Uh oh!

Nadrieril commented May 24, 2024

Uh oh!

tbu- commented May 24, 2024

Uh oh!

Nadrieril commented May 29, 2024

Uh oh!

bors commented May 29, 2024

Uh oh!

bors commented May 29, 2024

Uh oh!

This comment has been minimized.

bors commented May 29, 2024

Uh oh!

fmease commented May 30, 2024

Uh oh!

Nadrieril commented Jun 1, 2024

Uh oh!

tbu- commented Jun 4, 2024

Uh oh!

Nadrieril commented Jun 5, 2024

Uh oh!

bors commented Jun 5, 2024

Uh oh!

bors commented Jun 6, 2024

Uh oh!

bors commented Jun 6, 2024

Uh oh!

rust-timer commented Jun 6, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants