Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #125424
Closed
fmease wants to merge 12 commits into
Closed
Conversation
`Path::with_extension` has a nice footgun when the original path doesn't contain an extension: Anything after the last dot gets removed.
Frameworks are Apple-specific, no idea why it had "framework" in the name before.
Add some tests for public-private dependencies. This adds some tests to show more scenarios for the `exported_private_dependencies` lint. Several of these illustrate that the lint is not working as expected, and I have annotated those places with `FIXME`. Note also that this includes some diamond dependency structures which compiletest doesn't exactly support. However, I don't think it should be a problem, it just results in the common dependency being built twice.
Cleanup: Fix up some diagnostics Several diagnostics contained their error code inside their primary message which is no bueno. This PR moves them out of the message and turns them into structured error codes. Also fixes another occurrence of `->` after a selector in a Fluent message which is not correct. I've fixed two other instances of this issue in rust-lang#104345 (2022) but didn't update all instances as I've noted here: rust-lang#104345 (comment) (“the future is now!”).
…ape-examples-macros, r=jieyouxu Migrate `run-make/rustdoc-scrape-examples-macros` to `rmake.rs` Part of rust-lang#121876. r? `@jieyouxu`
…Nadrieril Directly add extension instead of using `Path::with_extension` `Path::with_extension` has a nice footgun when the original path doesn't contain an extension: Anything after the last dot gets removed.
…lcnr Rename `FrameworkOnlyWindows` to `RawDylibOnlyWindows` Frameworks are Apple-specific, no idea why it had "framework" in the name before.
…copy, r=lcnr Use correct param-env in `MissingCopyImplementations` We shouldn't assume the param-env is empty for this lint, since although we check the struct has no parameters, there still may be trivial where-clauses. fixesrust-lang#125394
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
FnMut/Fnif it has no self-borrows #125259 (An async closure may implementFnMut/Fnif it has no self-borrows)run-make/rustdoc-scrape-examples-macrostormake.rs#125401 (Migraterun-make/rustdoc-scrape-examples-macrostormake.rs)Path::with_extension#125406 (Directly add extension instead of usingPath::with_extension)FrameworkOnlyWindowstoRawDylibOnlyWindows#125409 (RenameFrameworkOnlyWindowstoRawDylibOnlyWindows)MissingCopyImplementations#125416 (Use correct param-env inMissingCopyImplementations)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup